The proposal to merge
lp:~widelands-dev/widelands/bug-1753230-working-with-tempfiles into
lp:widelands has been updated.
Commit message changed to:
Fix bugs with missing files/folders in savegames
- Whenever a map is fully loaded (editor/game/replay) the map is
immediately saved to a temp
Code LGTM - just some minor nits.
Diff comments:
>
> === modified file 'src/editor/ui_menus/main_menu_save_map.cc'
> --- src/editor/ui_menus/main_menu_save_map.cc 2018-06-01 08:50:29 +
> +++ src/editor/ui_menus/main_menu_save_map.cc 2018-10-22 18:50:51 +
> @@ -272,16 +272,14 @@
>
Continuous integration builds have changed state:
Travis build 4161. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/444762108.
Appveyor build 3959. State: success. Details:
On second thought, this fix is kind of broken. I haven't tested it but it will
most likely fail if a building has the same worker type as an "input" worker
and as a "worker" worker. In that case, the input workers will probably be
deleted as well.
Unfortunately the PlayerImmovable given as a
Review: Approve playtest and review
Code LGTM ;-)
tested it as well.
good spot.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/not-yet-implemented-rt-tags/+merge/356680
Your team Widelands Developers is subscribed to branch
Code is looking good and the game appears in the load menu.
Two issues:
- My single player replay savegame also shows up in the multiplayer load game
screen (even before this change). Not that much of an issue, might even be
intentional?
- The savegame isn't shown in the "save game" dialog. So
Review: Approve diff, test
Fix is looking good and I loaded the provided savegame a few times without it
crashing.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1798024-heap-use-after-free/+merge/356825
Your team Widelands Developers is subscribed to branch
The proposal to merge lp:~widelands-dev/widelands/not-yet-implemented-rt-tags
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/not-yet-implemented-rt-tags/+merge/356680
--
Your team Widelands
Notabilis has proposed merging
lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands.
Commit message:
Ignore workers in WorkerQueues when setting the amount of "worker" workers by
script.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1795871
Continuous integration builds have changed state:
Travis build 4162. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/445335793.
Appveyor build 3960. State: success. Details:
10 matches
Mail list logo
