> * As Serial is uint32_t so we have 2^32 different Economies, ok
> Should we do some stress testing with a Mutiplayergame
placing and removing flags and roads like mad?
> We could run this some more to see if we ever hit the limit
If by testing the limit you mean the number 2^32, this is probab
ypopezios has proposed merging
lp:~widelands-dev/widelands/previous_song_exclusion into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1735938 in widelands: "Random song selection should exclude the previous
song"
https://bugs.lau
I tested it (both paths) and I found it to be a mature improvement. A few
points:
- I would like a tiny battle to take place, instead of conquering through a
mere touch.
- The following comment doesn't reflect what actually happens:
"remove all workers from p3 to avoid having them wandering ar
My bad. I thought that the code-comment was for both paths. There is no crowd
in the cooperative way.
So my own comment was about the conquering. I would expect less people in a
monastery, especially if some of them get killed during the attack. Or you
could make it so as most of them to be fem
ypopezios has proposed merging lp:~widelands-dev/widelands/congestion into
lp:widelands.
Commit message:
For windows testing.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1535115 in widelands: "ai roads getting jammed a lot"
https://bugs.lau
The proposal to merge lp:~widelands-dev/widelands/congestion into lp:widelands
has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/congestion/+merge/348132
--
Your team Widelands Developers is requested to rev
Review: Resubmit
--
https://code.launchpad.net/~widelands-dev/widelands/congestion/+merge/348132
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/congestion.
___
Mailing list: https://launchpad.net/~widelands-dev
Pos
ypopezios has proposed merging lp:~widelands-dev/widelands/congestion into
lp:widelands.
Commit message:
For windows testing.
Requested reviews:
ypopezios (ypopezios)
Related bugs:
Bug #1535115 in widelands: "ai roads getting jammed a lot"
https://bugs.launchpad.net/widelands/+b
The proposal to merge lp:~widelands-dev/widelands/congestion into lp:widelands
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/congestion/+merge/348132
--
Your team Widelands Developers is subscribed to branch
ypopezios has proposed merging lp:~widelands-dev/widelands/congestion into
lp:widelands.
Commit message:
Repeat request for AppVeyor, after bot's failure.
Requested reviews:
ypopezios (ypopezios)
Related bugs:
Bug #1535115 in widelands: "ai roads getting jammed a lo
ypopezios has proposed merging lp:~widelands-dev/widelands/congestion into
lp:widelands.
Commit message:
Another effort to get windows builds.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1535115 in widelands: "ai roads getting jammed a lot&quo
ypopezios has proposed merging lp:~widelands-dev/widelands/congestion2 into
lp:widelands.
Commit message:
Another attempt to get windows builds.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/congestion2
That has been waiting for testers (and especially those who doubted every step
of its development). Since no other testers appeared, I'd be happy to have this
merged, thus forcing everyone to indirectly test it.
--
https://code.launchpad.net/~widelands-dev/widelands/road_promotions/+merge/344182
The proposal to merge lp:~widelands-dev/widelands/road_promotions into
lp:widelands has been updated.
Description changed to:
This is supposed to improve how roads get promoted and demoted under all
possible scenarios, without surprises or other negative side-effects (basically
without oscilla
Description fixed.
--
https://code.launchpad.net/~widelands-dev/widelands/road_promotions/+merge/344182
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/road_promotions.
___
Mailing list: https://launchpad.net/~widelan
@klaus
Road promotion was just the "appetizer". Congestion here is the "first plate".
There will hopefully come a "main plate" as well, which will seriously improve
routing performance. There will also come some other improvements related to
economy.
Concerning the description of this merge, r
I'd rather write a paper on theoretical aspects of Widelands in graph theory...
And I'm not interested in publicity, thanks. I'm interested in testing though.
You can test current code the way you said (specific congestion scenarios and
strange maps) or you can wait to test after I update the co
@klaus
I suggest you don't spend your energy with this before I have a review of the
code myself, cause I haven't looked at it after the two merges took place.
--
https://code.launchpad.net/~widelands-dev/widelands/congestion2/+merge/348525
Your team Widelands Developers is subscribed to branch
Replied to inline comments. Will update the code soon.
Diff comments:
> === modified file 'src/economy/flag.cc'
> --- src/economy/flag.cc 2018-04-07 16:59:00 +
> +++ src/economy/flag.cc 2018-06-26 21:40:51 +
> @@ -394,101 +406,112 @@
> #define MAX_TRANSFER_PRIORITY 16
>
>
Replied to inline comments. Will update the code soon.
Diff comments:
> === modified file 'src/economy/flag.cc'
> --- src/economy/flag.cc 2018-07-11 08:32:54 +
> +++ src/economy/flag.cc 2018-07-30 09:36:58 +
> @@ -505,14 +576,43 @@
> sizeof(wares_[0]) * (ware_fil
I would not create a special extra tribe. I would instead use a nullptr as a
default value and have it represent the random tribe by convention and only
where it makes sense.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1783878_editor_random_map_tribe/+merge/352038
Your team Widela
ypopezios has proposed merging lp:~widelands-dev/widelands/ship_scheduling_2
into lp:widelands.
Commit message:
Get windows builds and ask for testing.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands
My suggestion has been based solely on general programming principles, not on
reading the code. I'm not familiar with the relevant files. I had a look and
they are a mess (as most of the codebase is). If someone points me to specific
places in the code, maybe I could do it.
--
https://code.laun
Inline comment.
Also, if you haven't done it, check this comment:
https://bugs.launchpad.net/widelands/+bug/1535115/comments/33
Diff comments:
> === modified file 'src/logic/map_objects/tribes/carrier.cc'
> --- src/logic/map_objects/tribes/carrier.cc 2018-08-09 11:11:15 +
> +++ src/logic/ma
In current problematic design, a carrier in an invalid state can easily get
stuck, so we will need to test some actual savegames to answer that.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1786597-test-suite/+merge/352928
Your team Widelands Developers is subscribed to branch
lp:~
Review: Needs Information
Does this end this branch' reason of existence?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1786597-test-suite/+merge/352928
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1786597-test-suite.
__
Review: Approve
As far as it concerns me, this looks ok ;-P
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1786597-test-suite/+merge/352928
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1786597-test-suite.
In principle, if I was given a range to compromise with, I would go the
conservative route and pick the edge of the range which is closer to the
previous value. In this case, the given range is 500 to 1000ms, the previous
value is 1ms, so I would go with 1000ms.
Having said that, in my eyes
Added inline comment.
Diff comments:
>
> === modified file 'src/ui_fsmenu/launch_spg.cc'
> --- src/ui_fsmenu/launch_spg.cc 2018-07-07 20:22:12 +
> +++ src/ui_fsmenu/launch_spg.cc 2018-08-26 11:35:09 +
> @@ -283,7 +283,14 @@
> Widelands::PlayerNumber const nrplayers = ma
The proposal to merge lp:~widelands-dev/widelands/ship_scheduling_2 into
lp:widelands has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ship_scheduling_2/+merge/352335
--
Your team Widelands Developers is requeste
ypopezios has proposed merging lp:~widelands-dev/widelands/ship_scheduling_2
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ship_scheduling_2/+merge/354019
See description of the branch
AppVeyor seems broken. Otherwise, this branch is now mature and big enough. Not
going to add anything more into it, so as to keep it easier for reviewers. If
people test it, it can make it into build 20.
--
https://code.launchpad.net/~widelands-dev/widelands/ship_scheduling_2/+merge/354019
Your
Added inline comments concerning the NOCOM comments.
Diff comments:
>
> === modified file 'src/economy/portdock.cc'
> --- src/economy/portdock.cc 2018-04-16 07:03:12 +
> +++ src/economy/portdock.cc 2018-09-04 18:46:42 +
> @@ -281,44 +286,70 @@
> }
> }
>
> -void PortDock::upd
The proposal to merge lp:~widelands-dev/widelands/ship_scheduling_2 into
lp:widelands has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ship_scheduling_2/+merge/354019
--
Your team Widelands Developers is subscrib
ypopezios has proposed merging lp:~widelands-dev/widelands/ship_scheduling_2
into lp:widelands.
Commit message:
Improved ware/worker routing algorithm for ships and portdocks.
Requested reviews:
GunChleoc (gunchleoc)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands
>From what I understand, the test suite forces the removal of ports and ships
>without running clean-up code. That invalidates the state of transports and
>breaks the advanced logic. I'm not sure if it is worthy to change the logic,
>instead of changing the tests.
--
https://code.launchpad.net/
Are you sure that there is proper simulation of user-actions here? Cause I
suspect that there is just a magical removal, without calling e.g. sinking
function. Of course the code should cover cases of destruction, but how to do
that if it is not properly called? The old code was checking every t
This is not perfect, but should be enough for this branch.
--
https://code.launchpad.net/~widelands-dev/widelands/ship_scheduling_2/+merge/355510
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ship_scheduling_2.
___
Concerning the specific TODO, the code for invalid destinations pre-existed my
involvement and is suspicious enough. I just moved it earlier in the function,
in order to catch more cases. I don't know which are those cases (they don't
happen in any part of the code that I touched), only that som
Thanks for clarifying the TODO tags. I would expect the creator to be written
on the left and the assignee on the right of it.
The only way for this branch to slow down the game is if the ports and the
ships become hundreds. Even in that case, it should be lighter than the
previous code, so I d
You keep calling that a feature, while it is mostly a fix for the long-standing
poor scheduling, so technically it still applies despite the feature freeze.
Furthermore, the freeze was announced on 2018-09-17, while this branch has been
approved on 2018-09-14. The late problems with the test sui
"Widelands is too mature for the player base to find bugs like that acceptable
in a release."
Unless you have asked the player-base about the matter, the above statement is
arbitrary. If you dare, you can conduct a poll on the issue. Projects much
bigger and much more serious than Widelands hav
You can end a discussion, but you cannot help your case. Quite expectedly, the
"few weeks" of the "release coming shortly" turned out to be more than half a
year (and still counting). Congratulations for the upcoming release, and I wish
it to really happen and not to be "too little too late". I
It is funny how you still mention "this instance" when the scale of things here
is whole months. Of course introducing new bugs doesn't speed-up things, but I
don't remember you ever bothering with project's speed to begin with. Still
introducing developers can definitely speed-up things. Especi
What has been common practice when Widelands started development, is not the
favorite approach anymore and doesn't have to remain the same practice forever.
Big fails in prediction is not in the nature of programming, but in the nature
of old-fashioned development. Collaborative development is n
45 matches
Mail list logo
