Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
@Klaus: Sorry, I overlooked your question. No, you do not need to register at AppVeyor in order to look at logs and download .exe files. -- https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_cmakelist. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_cmakelist. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
Review: Approve Anything that's in the src dir only needs to be added to a local CMakeList.txt, which you have done. @Klaus: Travis can't do Windows, which is why we have AppVeyor. Let's get this in ASAP, thanks for the fix! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_cmakelist. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
Also there are new logic/ai_dna_handler.* files, maybe they should be mentioned somewhere as well.. -- https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_cmakelist. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
Thanks Tino :-) Maybe there should be added a comment to the CMakeLists.txt to not forget adjusting the Widelands.iss file if some folders get added/removed? -- https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_cmakelist. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
Yes, new files/directories have to be added to the Innosetup file. Give me a few minutes... -- https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_cmakelist. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
>From my understanding the file utils/win32/innosetup/Widelands.iss has to be >adjusted for windows. See: http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/utils/win32/innosetup/Widelands.iss Afaik innosetup is the installer program for windows. It's a bit ambiguous that the folder is called win32 but from what i can see appveyor uses this file also when creating x64 builds. See the line 2300 in e.g.: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ai_cmakelist-2330/job/q4s7wglxiqno2hwh#L2300 Maybe we should ping Tino? -- https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_cmakelist. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
Well, on linux it works, I am but afraid that windows build is not governed by CmakeList, but by some other file - that needs to be updated. On my linux everything works fine, including loading maps. -- https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_cmakelist. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
Review: Needs Fixing Uhmm this does not even run. when starting a network gae it dies with: ... GameSaver::save() took 98ms SaveHandler::save_game() took 102ms InternetGaming: logout(SERVER_CRASHED) [NetClient] Closing network socket connected to 2a01:238:4326:5100:b5ce:5c0b:f1f4:2e40:7395. ObjectManager: ouch! remaining objects lastserial: 474 [NetHost]: Closing a listening IPv4 socket. [NetHost]: Closing a listening IPv6 socket. ... was the Map Compatibiliy broken here? -- https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_cmakelist. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
Review: Needs Fixing Mhh, did not find that folder in the fnal deployment? D:\develop\wldev\ai_cmakelist\data>dir /B campaigns i18n images locale maps scripting shaders sound tribes txts world can someone check on linux? -- https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_cmakelist. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
Hmm, that Link in the message: > https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ai_cmakelist-2330. gives me. Build not found or access denied. I can find it however at: https://ci.appveyor.com/project/widelands-dev/widelands Do I have to register at appveyor? Will download and cehck this now -- https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
Once again I dont see the windows build? Where in travis is this hidden? -- https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
Continuous integration builds have changed state: Travis build 2506. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/261323352. Appveyor build 2330. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ai_cmakelist-2330. -- https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
When will be executed? I assume when the final binay is build. So the test would be to check if e.g. travis binary contains that folder. I will wait for bunnybot and then check. -- https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
TiborB has proposed merging lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands. Commit message: CMakeList.txt modification - adding AI folder to be copied to installation location. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 I forget to enter AI folder to a list of folders to be copied to installation location -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands. === modified file 'CMakeLists.txt' --- CMakeLists.txt 2017-07-01 13:14:08 + +++ CMakeLists.txt 2017-08-05 14:43:02 + @@ -265,6 +265,7 @@ # install files to the correct locations here install( DIRECTORY +data/ai data/campaigns data/i18n data/images ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands has been updated. Commit Message changed to: CMakeList.txt modification - adding AI folder to be copied to installation location. For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
