I believe that I can merge it
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1526903/+merge/281410
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1526903.
___
Mailing list:
> But there is another issue with the number of players: Open editor, open "set
> players", set number of players to two but place only one player to the map.
> Save the map and after reload the map the "set player" window will always show
> two players. If you try to start a game with this map, a
merge of
lp:~widelands-dev/widelands/bug-1526903 into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https
Review: Approve
I couldn't trigger any of the errors described in the related bug reports
anymore :-)
The file "allowed_building_types" is never been created. So for this it seems
to be fixed and i give approve for testing.
But there is another issue with the number of players: Open editor,
> Could you go through the map saver and have a look at other packets that we
> don't need?
There is couple of sections we can discuss, or perhaps can be ommited for
saving in editor:
log("Writing Flag Data ... ");
log("Writing Road Data ... ");
log("Writing Map Objects ... "); - this is
>Fatal exception: Widelands could not start the game, because player 2 has no
>starting position.
You can manually add a starting position with the Widelands Editor to fix this
problem.
For me this is "unfinished map" not a "bug".
--
Could you go through the map saver and have a look at other packets that we
don't need?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1526903/+merge/281410
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1526903
owed_building_types in
editor (=creating particular file). Should not cause problems, but must be
tested
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1526903 into lp:widelands.
=== modified file 'src/map_io/map_saver.cc'
--- src/map_io
The diff looks bit complex, but really only thing that was added is:
if (is_a(Game, _egbase)) { }
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1526903/+merge/281410
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug
9 matches
Mail list logo
