You trigger those by conquering a foreign military site and then again by
destroying it. I ran a setup on Golden Peninsula where I gave the opponent the
"Village" starting condition. so that I could easily conquer something.
--
The proposal to merge lp:~widelands-dev/widelands/smaller_building_statistics
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/smaller_building_statistics/+merge/342828
--
Your team Widela
Review: Approve compile, revied, debug for coverage, testplay
I testplayed this now on a seafaring Map:
* I was unable to reach the following lies of code:
* BuildingStatisticsMenu::foreign_tribe_building_is_valid()
...
if (descr.type() == MapObjectType::CONSTRUCTIONSITE ||
I did some testplaying with a debugger now and gained some coverage of that
code:
* Everything worked as expected so far.
* The Handling of the forward / backward buttons has room for improvement:
* no need so use large switch blocks -> call the repective function directly.
* Maybe I can do
fetched it again, no idea if I have time at the weekend.
--
https://code.launchpad.net/~widelands-dev/widelands/smaller_building_statistics/+merge/342828
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/smaller_building_statistics.
Review: Resubmit
I know - I have taken care of it. Branch is ready; I'll put it up for review as
soon as Launchpad has finished parsing it.
https://code.launchpad.net/~widelands-dev/widelands/allows_seafaring_performance
--
/smaller_building_statistics/+merge/342828
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/smaller_building_statistics into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands
/342828
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/smaller_building_statistics into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev
ault:
> + throw wexception(
> +"Building statictics: Found building without a size:
> %s", descr.name().c_str());
> + }
> + }
> + NEVER_HERE();
> +}
> +
> +
date_building_list() {
> + for (DescriptionIndex index = 0; index <
> iplayer().egbase().tribes().nrbuildings(); ++index) {
Better extract nrbuildings, compiler may not be able to deduce this is const
during the loop.
Extract const Widelands::Player& player for own_bui
ers is requested to review the proposed merge of
lp:~widelands-dev/widelands/smaller_building_statistics into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : http
/_widelands_dev_widelands_smaller_building_statistics-3163.
--
https://code.launchpad.net/~widelands-dev/widelands/smaller_building_statistics/+merge/342828
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/smaller_building_statistics into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/smaller_building_statistics
into lp:widelands has been updated.
Commit message changed to:
Building Statistics now only show relevant buildings
- Military sites not belonging to the tribe are omitted, unless the payer
currently owns one
on became impossible to reach on 800x600
resolution without moving the window around. So, I have implemented a dynamic
approach that will only show allowed and currently owned buildings.
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~wid
14 matches
Mail list logo
