Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/actionconfirm_improvements into lp:widelands

2016-12-13 Thread GunChleoc 
Duh, I let Travis do the compiling for me :)

@bunnybot merge
-- 
https://code.launchpad.net/~widelands-dev/widelands/actionconfirm_improvements/+merge/312301
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/actionconfirm_improvements.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/actionconfirm_improvements into lp:widelands

2016-12-12 Thread GunChleoc 
Does somebody have the time to fix the nit for me? Compiling Widelands on my VM 
takes hours.
-- 
https://code.launchpad.net/~widelands-dev/widelands/actionconfirm_improvements/+merge/312301
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/actionconfirm_improvements.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/actionconfirm_improvements into lp:widelands

2016-12-11 Thread SirVer 
Review: Approve

code lgtm.

Diff comments:

> === modified file 'src/ui_basic/multilinetextarea.cc'
> --- src/ui_basic/multilinetextarea.cc 2016-10-29 06:41:42 +
> +++ src/ui_basic/multilinetextarea.cc 2016-12-01 20:48:08 +
> @@ -158,11 +158,11 @@
>   uint32_t blit_height = std::min(text_im->height(), 
> static_cast(get_inner_h()));
>  
>   if (blit_width > 0 && blit_height > 0) {
> - float anchor = 0.f;
> + float anchor = 0;

I think this should be an int now since in this function you force it to be one.

>   Align alignment = mirror_alignment(align_);
>   switch (alignment & UI::Align::kHorizontal) {
>   case UI::Align::kHCenter:
> - anchor = (get_eff_w() - blit_width) / 2.f;
> + anchor = (get_eff_w() - blit_width) / 2;
>   break;
>   case UI::Align::kRight:
>   anchor = get_eff_w() - blit_width - 
> RICHTEXT_MARGIN;


-- 
https://code.launchpad.net/~widelands-dev/widelands/actionconfirm_improvements/+merge/312301
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/actionconfirm_improvements.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp