Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands

2018-10-28 Thread Notabilis
Travis failed for GCC 7 Debug Build with "No output has been received in the last 10m0s" when running the new test. Since all other builds succeeded, I think this is transitional error. At least, I am not aware of any loops related to this branch that could end up in an endless loop. @bunnybot

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands

2018-10-27 Thread GunChleoc
Yep! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1795871-lua-set_workers/+merge/357716 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1795871-lua-set_workers. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands

2018-10-27 Thread Notabilis
Worked fine now, thanks! So I guess this can be merged now? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1795871-lua-set_workers/+merge/357716 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1795871-lua-set_workers.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands

2018-10-27 Thread GunChleoc
I have added a function to stop the barracks. The test should be green now. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1795871-lua-set_workers/+merge/357716 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1795871-lua-set_workers.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands

2018-10-26 Thread Notabilis
Thanks for adding the test. The code is looking good, but for me the test fails: Error in Lua Coroutine [../src/scripting/lua_errors.cc:22] [string "test/maps/plain.wmf/scripting/test_inputqueue..."]:9: expected '8' but was '7'! I think the problem is that the barracks starts working

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands

2018-10-25 Thread Notabilis
Seems indeed as if something failed within Launchpad. For convenience, here is the change: https://bazaar.launchpad.net/~widelands-dev/widelands/bug-1795871-lua-set_workers/revision/8897 Interesting is only the first block, the rest are added brackets. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands

2018-10-25 Thread hessenfarmer
This seems to be some Launchpad error. If you click browse the code it is shown including the diff. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1795871-lua-set_workers/+merge/357716 Your team Widelands Developers is requested to review the proposed merge of

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands

2018-10-24 Thread GunChleoc
I don't see any diff here. Did you push your changes? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1795871-lua-set_workers/+merge/357716 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands

2018-10-23 Thread Notabilis
On second thought, this fix is kind of broken. I haven't tested it but it will most likely fail if a building has the same worker type as an "input" worker and as a "worker" worker. In that case, the input workers will probably be deleted as well. Unfortunately the PlayerImmovable given as a