@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/savegame-menu.
___
Mailing list:
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/savegame-menu.
___
Mailing list:
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/savegame-menu.
___
Mailing list: https://launchpad.net/~widelands-dev
Thanks for pointing that out - fixed by adding a dummy file.
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/savegame-menu.
___
If I interpret the Travis output right, it is complaining about the cmake
library liblogic_constants. Wasn't there something that header-only libraries
do not work? Might be the problem here, it only contains widelands.h.
--
Review: Approve commit diff and short test
Code looks good and compiling & starting games works. As far as I am concerned,
this branch can be merged.
I guess filesystem_constants is a good enough name for the file. After all,
that is what it contains.
--
OK, everything should be addressed now.
I renamed logic/constants.h to logic/filesystem_constants.h, because I couldn't
think of a better place to put them. I moved the statistics sample time
constant out into game.h.
--
We're trying to keep the base directory as free as possible. How about putting
them in src/io, since it's all filesystem stuff? Not entirely happy with that
though, since it's all widelands-specific, and io is widelands-agnostic.
kStatisticsSampleTime could be moved to logic/game.h, since it's
Review: Needs Fixing
I only looked at the commit-diffs, but the changes are mostly fine with me,
thanks.
However, there are two problems:
- Codecheck complains about wrong include order in logic/game.cc
- For me, it does not compile. Strangely, Travis seems to be happy with the
code. The
Review: Resubmit
This is now ready again, the crash is gone.
I added the things I couldn't solve right now as TODO comments to the code -
those are wider issues with the UI toolbox that are already in trunk.
I also cleaned up the file system constants, because it was really annoying me.
Answered the diff comments, I'm still waiting for the compiler for the fixes.
Will have a look at the bugs after that.
Diff comments:
> === modified file 'src/game_io/game_preload_packet.cc'
> --- src/game_io/game_preload_packet.cc2017-08-17 15:34:45 +
> +++
I have been testing the branch and today got it crash.
This is how it crashes:
Single Player
New Game
Click Crater and then OK
Start game
Main Menu
Save Game
Write some Filename and then OK
Main Menu
Exit Game
OK
Watch Replay
Choose the saved game and then OK
Wait until the end of replay and
Thanks for the detailed review :)
This will need some TLC from a real machine, so I'll take care of this one when
I'm back home.
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is subscribed to branch
Review: Needs Fixing
I did a round of code diff review and a bit of testing. The code looks good to
me, just some small remarks. I haven't retraced the whole refactoring process,
but it seems to be okay.
However, there are some issues with the removal of save games:
- Just a suggestion: After
Review: Approve testing
Opened all menus and all looks good to me :-)
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/savegame-menu.
Had a quick look and it LGTM :-)
Don't know if this related to your changes:
- Fullscreen toggling does not work for the save game menu, as well for Editor
Load/Save map menu. But for me this is ok.
- I have some incompatible maps showing an Error message. Hovering with the
mouse over the
Review: Resubmit
I have implemented all your suggestions except for the colors, and it looks
much better now :)
The color scheme is as follows:
Fullscreen menu text: Yellow, bold headers/variable names. Grey, bold
paragraph-level texts. Due to the background images, all texts have to be bold
> Colors are reversed between the Fullscreen menus and the in.game menus on
> purpose. This is necessary because the background makes non-bold text
> unreadable in the Fullscreen menus
Can't follow you here. The Save game menu shows currently (in this branch) bold
white constants ('Map name:')
Colors are reversed between the Fullscreen menus and the in.game menus on
purpose. This is necessary because the background makes non-bold text
unreadable in the Fullscreen menus - the coloring is consistent with the
mapselect screen though.
I used the arrow in the replay in an attempt to
Sorry for confusing, i was much tired yesterday. I meant: '... white for
variables':
In Load screen there is yellow for constants (like 'Map Name:') and white for
variables.
In save screen this is vice versa.
Another inconsistency:
In 'Watch Replay' the column 'Description' contains an arrow,
I am struggling with the different coloring of texts:
In Load screen there is yellow for constants (like 'Map Name:') and yellow for
variables.
In save screen this is vice versa.
In general an improvement though :-)
--
21 matches
Mail list logo
