[Maniphest] [Updated] T493: Prevent that private information is leaked via Herald notifications

2014-10-26 Thread mmodell
mmodell added a project: Patch-For-Review. mmodell added a comment. @chasemp: check out my first stab at sanitizing CC's and assignee: https://gerrit.wikimedia.org/r/#/c/168907/ TASK DETAIL https://phabricator.wikimedia.org/T493 REPLY HANDLER ACTIONS Reply to comment or attach files

[Maniphest] [Commented On] T643: conduit api method for creating comments

2014-10-23 Thread mmodell
mmodell added a comment. @chasemp can I close this one as resolved? TASK DETAIL https://phabricator.wikimedia.org/T643 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, chasemp, Qgil, jeremyb, Aklapper

[Maniphest] [Changed CC] T838: install and configure Pygments for syntax highlighting

2014-10-23 Thread mmodell
mmodell added a subscriber: mmodell. mmodell added a comment. this should be as simple as installing the ubuntu package, either `python-pygments` (python 2 version) or `python-pygments3` (python3 version) TASK DETAIL https://phabricator.wikimedia.org/T838 REPLY HANDLER ACTIONS Reply

[Maniphest] [Commented On] T763: Phabricator far too spammy to continue posting to wikibugs-l

2014-10-23 Thread mmodell
mmodell added a comment. Ok I think we should create a 'bug' tag (project)... the only problem I can see is that users unfamiliar with out conventions would most likely omit the 'bug' project when submitting bug reports. We could handle this in triage by simply adding the tag when it's

[Maniphest] [Claimed] T840: Show correct external IP addresses (XFF support) in activity log

2014-10-23 Thread mmodell
mmodell claimed this task. mmodell added a comment. I'm on this TASK DETAIL https://phabricator.wikimedia.org/T840 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, Reedy, jeremyb, Qgil, Aklapper

[Maniphest] [Updated] T840: Show correct external IP addresses (XFF support) in activity log

2014-10-23 Thread mmodell
mmodell added a project: Patch-For-Review. mmodell added a comment. https://gerrit.wikimedia.org/r/168509 TASK DETAIL https://phabricator.wikimedia.org/T840 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc

[Maniphest] [Commented On] T763: Phabricator far too spammy to continue posting to wikibugs-l

2014-10-23 Thread mmodell
mmodell added a comment. ok I changed the rules a little: Instead of adding the CC, new tasks simply send a single email to the list, this will cut down on spam significantly. **When all of these conditions are met:** Projects do not include `security`, `operations`, `Human-Resources

[Maniphest] [Changed Project Column] T573: Get phawikibugs to run on tools.wmflabs

2014-10-22 Thread mmodell
mmodell moved this task to Doing on the phawikibugs workboard. TASK DETAIL https://phabricator.wikimedia.org/T573 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: valhallasw, mmodell Cc: wikibugs-l, Aklapper, chasemp, mmodell

[Maniphest] [Commented On] T324: Have wikiphabot follow the same channel announce rules as wikibugs

2014-10-22 Thread mmodell
mmodell added a comment. I think it would make more sense to configure this directly in phabricator: We could add a custom field to projects called irc channel which would be used to associate a project with a channel. Then any updates to tickets in a given project would get posted

[Maniphest] [Changed CC] T763: Phabricator far too spammy to continue posting to wikibugs-l

2014-10-22 Thread mmodell
mmodell added a subscriber: mmodell. TASK DETAIL https://phabricator.wikimedia.org/T763 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, Chad, Qgil, chasemp, Aklapper, mmodell, jeremyb

[Maniphest] [Closed] T716: security extension doesn't need to strip out projects of newly created tickets (only add security)

2014-10-22 Thread mmodell
mmodell closed this task as Resolved. mmodell added a comment. https://gerrit.wikimedia.org/r/#/c/168141/ fixes it for realz this time. TASK DETAIL https://phabricator.wikimedia.org/T716 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Maniphest] [Updated] T716: security extension doesn't need to strip out projects of newly created tickets (only add security)

2014-10-21 Thread mmodell
mmodell added a comment. @chasemp: If we merge the patch from T475 ( https://gerrit.wikimedia.org/r/#/c/163753/ ) then this task doesn't make as much sense. The patch for T475 sets the policy to members of projects the task is part of and the security plugin needs to ensure that a task isn't

[Maniphest] [Updated] T716: security extension doesn't need to strip out projects of newly created tickets (only add security)

2014-10-21 Thread mmodell
mmodell added a project: Patch-For-Review. mmodell added a comment. https://gerrit.wikimedia.org/r/#/c/167899/ TASK DETAIL https://phabricator.wikimedia.org/T716 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc

[Maniphest] [Closed] T716: security extension doesn't need to strip out projects of newly created tickets (only add security)

2014-10-21 Thread mmodell
mmodell closed this task as Resolved. mmodell added a comment. gerrit patch merged. This should be resolved. TASK DETAIL https://phabricator.wikimedia.org/T716 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc

[Maniphest] [Reopened] T716: security extension doesn't need to strip out projects of newly created tickets (only add security)

2014-10-21 Thread mmodell
mmodell reopened this task as Open. TASK DETAIL https://phabricator.wikimedia.org/T716 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, chasemp, Qgil, mmodell

[Maniphest] [Commented On] T716: security extension doesn't need to strip out projects of newly created tickets (only add security)

2014-10-21 Thread mmodell
mmodell added a comment. Trying again: https://gerrit.wikimedia.org/r/#/c/168028/ TASK DETAIL https://phabricator.wikimedia.org/T716 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, chasemp, Qgil

[Maniphest] [Changed CC] T687: Turn Bugzilla's plain Bug 12345 has been marked as a duplicate comment string into an URL?

2014-10-20 Thread mmodell
mmodell added a subscriber: mmodell. mmodell added a comment. @chasemp: this should do it: [bB]ug [0-9]+ TASK DETAIL https://phabricator.wikimedia.org/T687 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc

[Maniphest] [Triaged] T716: security extension doesn't need to strip out projects of newly created tickets (only add security)

2014-10-20 Thread mmodell
mmodell triaged this task as High priority. TASK DETAIL https://phabricator.wikimedia.org/T716 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, chasemp, Qgil

[Maniphest] [Claimed] T700: Users CCed in Bugzilla are not being added as subscribers in bugzillapreview

2014-10-20 Thread mmodell
mmodell claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T700 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, Qgil, Byfserag, Aklapper

[Maniphest] [Commented On] T583: Get rid of Triagers for now

2014-10-16 Thread mmodell
mmodell added a comment. @hashar I believe that the maniphest policies are global and not per-project. We did some custom coding for the security project feature, however, having per project fine-grained policies would be quite a bit of effort to develop. TASK DETAIL https

[Maniphest] [Up For Grabs] T631: Create New Project is linked even though I can't

2014-10-13 Thread mmodell
mmodell placed this task up for grabs. mmodell added a subscriber: mmodell. TASK DETAIL https://phabricator.wikimedia.org/T631 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, Nemo_bis, Qgil, mmodell

[Maniphest] [Lowered Priority] T643: conduit api method for creating comments

2014-10-13 Thread mmodell
mmodell lowered the priority of this task from High to Normal. TASK DETAIL https://phabricator.wikimedia.org/T643 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, chasemp, Qgil, jeremyb, Aklapper

[Maniphest] [Changed CC] T648: Set up PhabricatorBotObjectNameHandler for specific channels

2014-10-12 Thread mmodell
mmodell added a subscriber: mmodell. TASK DETAIL https://phabricator.wikimedia.org/T648 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, valhallasw, mmodell

[Maniphest] [Created] T643: conduit api method for creating comments

2014-10-11 Thread mmodell
mmodell created this task. mmodell claimed this task. mmodell added a subscriber: chasemp. mmodell added a project: Phabricator. mmodell changed Security from none to none. TASK DESCRIPTION the maniphest.update method doesn't return a phid for created comments. We need a way to store

[Maniphest] [Commented On] T643: conduit api method for creating comments

2014-10-11 Thread mmodell
mmodell added a comment. https://gerrit.wikimedia.org/r/#/c/166259/ TASK DETAIL https://phabricator.wikimedia.org/T643 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, chasemp, Qgil, jeremyb, Aklapper

[Maniphest] [Updated] T643: conduit api method for creating comments

2014-10-11 Thread mmodell
mmodell added a project: Bugzilla-Migration. TASK DETAIL https://phabricator.wikimedia.org/T643 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, chasemp, Qgil, jeremyb, Aklapper

[Maniphest] [Commented On] T643: conduit api method for creating comments

2014-10-11 Thread mmodell
mmodell added a comment. @chasemp: now it's a tested prototype. returns the phid of the transaction as well as the phid of the comment. TASK DETAIL https://phabricator.wikimedia.org/T643 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Maniphest] [Commented On] T607: Check easily who has signed Legalpad documents by their Wikimedia username

2014-10-10 Thread mmodell
mmodell added a comment. Here's what the mediawiki user field looks like in advanced search on my local test phabricator: {F219} TASK DETAIL https://phabricator.wikimedia.org/T607 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Maniphest] [Declined] T637: Application list is not capable of wrapping

2014-10-10 Thread mmodell
mmodell closed this task as Declined. mmodell claimed this task. mmodell added a comment. This is how they designed it. Take it up with the upstream project if it's bothering you badly.. TASK DETAIL https://phabricator.wikimedia.org/T637 REPLY HANDLER ACTIONS Reply to comment or attach

[Maniphest] [Declined] T631: Create New Project is linked even though I can't

2014-10-10 Thread mmodell
mmodell closed this task as Declined. mmodell claimed this task. mmodell added a comment. Unlikely to be fixed by us. Take this up with upstream. TASK DETAIL https://phabricator.wikimedia.org/T631 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Maniphest] [Closed] T620: Timezone defaults to America/Los Angeles

2014-10-10 Thread mmodell
mmodell closed this task as Resolved. mmodell added a subscriber: mmodell. mmodell added a comment. apparently it's already resolved by fiat. Phabricator isn't any fun without 'closed out of spite' TASK DETAIL https://phabricator.wikimedia.org/T620 REPLY HANDLER ACTIONS Reply to comment

[Maniphest] [Changed CC] T612: Landing a patch with arc currently will sometimes strip author information

2014-10-10 Thread mmodell
mmodell added a subscriber: mmodell. mmodell added a comment. Upstream seems to be suggesting that it's mostly resolved and they don't even know how to reproduce the problem. @milimetric do you have an example of when this happens? TASK DETAIL https://phabricator.wikimedia.org/T612 REPLY

[Maniphest] [Commented On] T607: Check easily who has signed Legalpad documents by their Wikimedia username

2014-10-09 Thread mmodell
mmodell added a comment. I did this before. It's an ugly hack and I'd rather not maintain it but it isn't hard to do: https://gerrit.wikimedia.org/r/#/c/147723/ TASK DETAIL https://phabricator.wikimedia.org/T607 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Maniphest] [Commented On] T607: Check easily who has signed Legalpad documents by their Wikimedia username

2014-10-09 Thread mmodell
mmodell added a comment. One thing I can do, at least it doesn't look very difficult at first glance, is to enable 'advanced search' on the wiki username field. That would not involve any hacks or long term maintenance issues, at least in the sense that it would be isolated to an extension

[Maniphest] [Commented On] T607: Check easily who has signed Legalpad documents by their Wikimedia username

2014-10-09 Thread mmodell
mmodell added a comment. @chasemp @qgil When @jalexander says he's explained it a few times in previous tasks and meetings, he's referring to T258 and it's been pretty clear that they want specifically to have the wiki username in the list, just like this task is requesting. @chasemp: I'm

[Maniphest] [Changed CC] T574: bad wiki Username (WMF) URL in Confirm MediaWiki Account Link and Linked Accounts and Authentication

2014-10-09 Thread mmodell
mmodell added a subscriber: csteipp. mmodell added a comment. This is a lot more complex than it looks. Because the wikimedia oauth plugin needs to work with other mediawiki installs, and those can have different url schemes, we can't hard-code it to assume the conventions used

[Maniphest] [Lowered Priority] T574: bad wiki Username (WMF) URL in Confirm MediaWiki Account Link and Linked Accounts and Authentication

2014-10-09 Thread mmodell
mmodell lowered the priority of this task from Normal to Low. TASK DETAIL https://phabricator.wikimedia.org/T574 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, Spage, Qgil, He7d3r, csteipp, jeremyb

[Maniphest] [Commented On] T571: Make wikibugs parse phab emails send messages

2014-10-08 Thread mmodell
mmodell added a comment. @greg indeed I meant T324, thank you. TASK DETAIL https://phabricator.wikimedia.org/T571 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, Aklapper, chasemp, mmodell, Qgil

[Maniphest] [Updated] T571: Make wikibugs parse phab emails send messages

2014-10-07 Thread mmodell
mmodell added a project: Phabricator. mmodell added a comment. I think the phabot (T571) might be a better way to go since it's already got the right information in much more machine-friendly format, all we have to do is deal with the channel rules (and yet another irc bot in each relevant

[Maniphest] [Created] T576: Access Denied: Application Maniphest You do not have permission to edit task status.

2014-10-07 Thread mmodell
mmodell created this task. mmodell claimed this task. mmodell added a subscriber: mmodell. mmodell added a project: Phabricator. mmodell changed Security from none to none. TASK DESCRIPTION Apparently you have to be in the triage project to simply submit a task? TASK DETAIL https

[Maniphest] [Changed Status] T576: Access Denied: Application Maniphest You do not have permission to edit task status.

2014-10-07 Thread mmodell
mmodell changed the task status from Open to Needs Info. TASK DETAIL https://phabricator.wikimedia.org/T576 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, mmodell, Qgil, Aklapper

[Maniphest] [Commented On] T576: Non 'Triagers' members get: You do not have permission to edit task status. on attempted new task creation

2014-10-07 Thread mmodell
mmodell added a comment. If we want to hide something for the sake of form simplicity then we should look into simply hiding it rather than adjusting permissions based on project. I could surely come up with a fairly simple way to streamline the default form while leaving the permissions

[Maniphest] [Claimed] T547: MediaWiki login for Phabricator produces broken links for Wikimedia profiles with URL encoded characters

2014-10-06 Thread mmodell
mmodell claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T547 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, Qgil, mmodell, liangent, Aklapper

[Maniphest] [Commented On] T547: MediaWiki login for Phabricator produces broken links for Wikimedia profiles with URL encoded characters

2014-10-06 Thread mmodell
mmodell added a comment. @aklapper: it actually required more calls to urldecode not less ;) @everyone: review please... TASK DETAIL https://phabricator.wikimedia.org/T547 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Maniphest] [Updated] T547: MediaWiki login for Phabricator produces broken links for Wikimedia profiles with URL encoded characters

2014-10-06 Thread mmodell
mmodell added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T547 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: mmodell Cc: wikibugs-l, Qgil, mmodell, liangent, Aklapper