[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 --- Comment #17 from Andre Klapper aklap...@wikimedia.org --- Specific questions and addressees are often more successful than contentless pings. In this case repeating comment 15: Shouldn't we keep this bug until the method documented at https://www.mediawiki.org/wiki/Extension:WikiEditor/Toolbar_customization?diff=639169 also works with LQT? Or maybe that method should be deprecated? As far as I know, it is only used by the GuidedTour extension: https://github.com/wikimedia/mediawiki-extensions-GuidedTour/blob/127888bf108379dcea5d7ee60272f431f889aa7e/modules/ext.guidedTour.lib.js#L765 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 --- Comment #18 from Matthew Flaschen mflasc...@wikimedia.org --- (In reply to Helder from comment #15) Shouldn't we keep this bug until the method documented at https://www.mediawiki.org/wiki/Extension:WikiEditor/ Toolbar_customization?diff=639169 also works with LQT? Or maybe that method should be deprecated? As far as I know, it is only used by the GuidedTour extension: https://github.com/wikimedia/mediawiki-extensions-GuidedTour/blob/ 127888bf108379dcea5d7ee60272f431f889aa7e/modules/ext.guidedTour.lib.js#L765 The bug is that LQT does not support user toolbar customization, or at least not in the same way as WikiEditor. That hook (wikiEditor-toolbar-doneInitialSections) is a way of knowing when the initial WikiEditor toolbar buttons are done loading. GuidedTour needs this because the toolbar load causes (or at least did back then) a reflow. I don't support deprecating it until there's an adequate replacement, or it's established that the current version of WikiEditor never causes reflows when the toolbar loads. I haven't tested it, but it looks like there is now a way to know when LQT is ready for customization, or at least when the textarea is ready (ext.lqt.textareaCreated). Thus, the only reason to keep this open would be if it doesn't work or you believe that it should use the same hook as WikiEditor. I don't know enough about the architecture of either WikiEditor or LQT to know if they should use the same hook. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 --- Comment #16 from Helder he7d3r+b...@gmail.com --- Ping -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 Alex Monk kren...@wikimedia.org changed: What|Removed |Added Assignee|kren...@wikimedia.org |wikibugs-l@lists.wikimedia. ||org -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 --- Comment #13 from Andre Klapper aklap...@wikimedia.org --- (In reply to comment #12) Change 77052 merged by jenkins-bot: Add JS hook for user scripts to add buttons to all LQT textareas as they are created https://gerrit.wikimedia.org/r/77052 Patch got merged - can this bug report be closed as RESOLVED FIXED or is more work required? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 --- Comment #14 from Helder mybugs.m...@gmail.com --- (In reply to comment #13) Patch got merged - can this bug report be closed as RESOLVED FIXED or is more work required? I just would like if someone could confirm that this is the way it is supposed to be used: https://www.mediawiki.org/w/index.php?diff=790337 More specifically: does it need any extra check to find out if we are in a lqt-edit-mode? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 --- Comment #15 from Helder mybugs.m...@gmail.com --- Shouldn't we keep this bug until the method documented at https://www.mediawiki.org/wiki/Extension:WikiEditor/Toolbar_customization?diff=639169 also works with LQT? Or maybe that method should be deprecated? As far as I know, it is only used by the GuidedTour extension: https://github.com/wikimedia/mediawiki-extensions-GuidedTour/blob/127888bf108379dcea5d7ee60272f431f889aa7e/modules/ext.guidedTour.lib.js#L765 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 Helder mybugs.m...@gmail.com changed: What|Removed |Added URL|http://translatewiki.net/wi |https://translatewiki.net/w |ki/Support |/i.php?title=User:Purodha/e ||dit.jsoldid=1700660 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 --- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 77052 merged by jenkins-bot: Add JS hook for user scripts to add buttons to all LQT textareas as they are created https://gerrit.wikimedia.org/r/77052 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 Helder mybugs.m...@gmail.com changed: What|Removed |Added CC||mflasc...@wikimedia.org, ||o...@wikimedia.org --- Comment #10 from Helder mybugs.m...@gmail.com --- I just remembered this thread (from January 2013): http://www.gossamer-threads.com/lists/wiki/wikitech/331135 (http://lists.wikimedia.org/pipermail/wikitech-l/2013-January/066060.html) Matthew Flaschen added the line context.$textarea.trigger( 'wikiEditor-toolbar-doneInitialSections' ); to WikiEditor's code on https://gerrit.wikimedia.org/r/#/c/46490/ While googling about this event, I also found a more recent (and now abandoned) patch by Ori.livneh: https://gerrit.wikimedia.org/r/#/c/73144/ I wonder if some of these hooks would be also executed by LQT so we wouldn't need to add a new one to its code? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 --- Comment #11 from Helder mybugs.m...@gmail.com --- (In reply to comment #10) I wonder if some of these hooks would be also executed by LQT so we wouldn't need to add a new one to its code? I mean, taking into account that LQT duplicates a lot of code from WikiEditor... (bug 28761) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 --- Comment #7 from Helder mybugs.m...@gmail.com --- Using mw.hook would be good enough to me. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 Helder mybugs.m...@gmail.com changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=23580 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 77052 had a related patch set uploaded by Alex Monk: Add JS hook for user scripts to add buttons to all LQT textareas as they are created https://gerrit.wikimedia.org/r/77052 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 Alex Monk kren...@gmail.com changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |kren...@gmail.com |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 Helder mybugs.m...@gmail.com changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #4 from Helder mybugs.m...@gmail.com --- Krinkle, do you think this is something which can be fixed by adding some mw.hook calls to LQT code and then using callbacks in the appropriate user scripts? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 --- Comment #5 from Helder mybugs.m...@gmail.com --- (In reply to comment #4) the appropriate user scripts? e.g. https://www.mediawiki.org/wiki/Extension:WikiEditor/Toolbar_customization#Basic_setup -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 Alex Monk (Krenair) kren...@gmail.com changed: What|Removed |Added CC||kren...@gmail.com --- Comment #6 from Alex Monk (Krenair) kren...@gmail.com --- We could add mw.hook( 'ext.lqt.textareaCreated' ).fire( $( container ).find( '#wpTextbox1' ) ); to injectEditForm's finishSetup (in lqt.js). Then http://pt.wikibooks.org/w/index.php?oldid=182841uselang=en would almost work - you just have to change it to run when that hook is called instead of $( document ).ready. This wouldn't fix the original reporter's script, but would mean it could possibly be re-filed in the WikiEditor component (convert mwCustomEditButtons info into toolbar actions). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 Helder mybugs.m...@gmail.com changed: What|Removed |Added Keywords||javascript CC||mybugs.m...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 --- Comment #3 from Helder mybugs.m...@gmail.com --- (In reply to comment #1) This *may* be a problem with your scripts. If you give me a link to the scripts, I'll take a look. FYI: I suppose this was the script: https://translatewiki.net/w/i.php?oldid=1700660 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 Helder heldergeov...@gmail.com changed: What|Removed |Added CC||heldergeov...@gmail.com --- Comment #2 from Helder heldergeov...@gmail.com 2010-08-18 10:17:36 BRT --- I also have this problem at pt.wikibooks using this script: http://pt.wikibooks.org/w/index.php?oldid=182839uselang=en http://pt.wikibooks.org/w/index.php?oldid=182841uselang=en -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 21692] personal edit toolbar lost
https://bugzilla.wikimedia.org/show_bug.cgi?id=21692 --- Comment #1 from Andrew Garrett agarr...@wikimedia.org 2009-11-30 16:29:06 UTC --- This *may* be a problem with your scripts. If you give me a link to the scripts, I'll take a look. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
