[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 Alex Monk kren...@wikimedia.org changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #21 from Alex Monk kren...@wikimedia.org --- I just fixed it with https://en.wikipedia.org/w/index.php?title=MediaWiki:Common.cssdiff=624714120oldid=624708988 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 Spinningspark spinningspark.w...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED CC||spinningspark.w...@gmail.co ||m Resolution|FIXED |--- --- Comment #20 from Spinningspark spinningspark.w...@gmail.com --- This is still occuring. Pages with no edit notices pop up with 1 notice when VE is launched. It is not even useful in providing a link to where I *can* add an edit notice. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013
--- Comment #15 from Krinkle krinklem...@gmail.com ---
(In reply to Erik Moeller from comment #10)
Regression; this is happening again on en.wp.
The system is an en.wikipedia hack, and can't be fixed from within VisualEditor
without it knowing more than it should about English Wikipedia.
It comes down to their Editnotice system explicitly creating an edit notice to
tell sysops there are no edit notices on this page, click here to create one,
which they present as... an edit notice.
Thus MediaWiki, and by extend VisualEditor, show it as an edit notice.
Last year I put a system in place that allows them to hide these using a css
class.
(In reply to Minh Nguyễn from comment #12)
I've proposed a client-side workaround at [[MediaWiki talk:Common.css#Edit
notices and VisualEditor]].
That css was adopted by en.wikipedia as of
https://en.wikipedia.org/w/index.php?title=MediaWiki%3ACommon.cssdiff=562641575oldid=560030040
and that fixed it for them, last year with this:
/**
* Hide the redlink generated by {{Editnotice}},
* this overrides the .sysop-show { display: none; } above that applies
* to the same link as well.
*/
.ve-init-mw-viewPageTarget-toolbar-editNotices-notice .editnotice-redlink {
display: none !important;
}
Commit https://gerrit.wikimedia.org/r/#/c/90378/ accidentally removed this
class, thus the above CSS rule no longer applies.
The CSS proposed by Minh on [[MediaWiki talk:Common.css#Edit
notices and VisualEditor]] is a bit too generic in my opinion, I would
recommend against that.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 --- Comment #16 from Krinkle krinklem...@gmail.com --- Looks like we do have a replacement class that isn't too generic: .ve-ui-mwNoticesPopupTool-item ... Though it is an internal class, not one I'd recommend we promote as an API for wikis to use. Let's use that as a temporary replacement, and add another one soon for the long term. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 --- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118369 had a related patch set uploaded by Krinkle: mw.Target: Add class mw-ve-editNotice to edit notices https://gerrit.wikimedia.org/r/118369 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 --- Comment #18 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118369 merged by jenkins-bot: mw.Target: Add class mw-ve-editNotice to edit notices https://gerrit.wikimedia.org/r/118369 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #19 from James Forrester jforres...@wikimedia.org --- Fixed on-wiki. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 --- Comment #13 from James Forrester jforres...@wikimedia.org --- *** Bug 61335 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 James Forrester jforres...@wikimedia.org changed: What|Removed |Added CC||jay...@gmail.com --- Comment #14 from James Forrester jforres...@wikimedia.org --- *** Bug 55951 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 Elitre elitr...@gmail.com changed: What|Removed |Added CC||elitr...@gmail.com --- Comment #11 from Elitre elitr...@gmail.com --- Bug 55951 is possibly a duplicate? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 Elitre elitr...@gmail.com changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=61335 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 --- Comment #12 from Minh Nguyễn m...@1ec5.org --- I've proposed a client-side workaround at [[MediaWiki talk:Common.css#Edit notices and VisualEditor]]. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 Erik Moeller e...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #10 from Erik Moeller e...@wikimedia.org --- Regression; this is happening again on en.wp. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Target Milestone|VE-deploy-2013-01-16|VE-deploy-2013-01-02 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Target Milestone|--- |VE-deploy-2013-01-16 --- Comment #9 from James Forrester jforres...@wikimedia.org --- Tagging with deploy-train cycle. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC||yyairr...@gmail.com --- Comment #8 from Krinkle krinklem...@gmail.com --- *** Bug 43460 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 Krinkle krinklem...@gmail.com changed: What|Removed |Added Summary|VisualEditor: Wrong number |VisualEditor: Deal with |of notices displayed|en.wikipedia.org's edit |(interface says there are |notice system |two when there is only one) | --- Comment #3 from Krinkle krinklem...@gmail.com --- It counts 2 because there are 2. One from VisualEditor (the default alpha-warning) and one from en.wikipedia.org. English Wikipedia has this self-invented wikitext-organised edit notice system. Long story short, it means there is never not a notice. It always shows something. In this case the edit notice that it loads is the following html: div id=editnotice-area class=editnotice-area style=clear: both; width: 100%;div class=editnotice-namespace style=width: 100%; /divdiv class=editnotice-link editnotice-redlink sysop-show accountcreator-show style=clear: both; float: right; margin: 0px 0.8em; padding: 0; line-height: 1em; display: none; smalla href=/w/index.php?title=Template:Editnotices/Page/You_Can%27t_Make_a_Heart_Love_Somebodyamp;action=editamp;redlink=1 class=new title=Template:Editnotices/Page/You Can't Make a Heart Love Somebody (page does not exist)Page notice/a/small /divdiv style=clear: both;/div /div English Wikipedia uses Template:Editnotices to maintain their notices (embedded from a one-liner in the MediaWiki namespace) since they don't want to restrict it to sysops. Aside from that they want to advertise this template and make it easy to find. So when there is no edit notice, the template outputs a link to create one. This is not created by MediaWiki nor by VisualEditor. However it isn't a mini-notice with a red link for most users. It is only visible to sysops and account creators (via the CSS class sysop-show and accountcreator-show), so for regular users it is just empty. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 --- Comment #4 from James Forrester jforres...@wikimedia.org --- So, as a way around this, could we have a hacky exception? Or should we push upstream and suggest that core editnotices are adjusted so that every wiki has enwiki's system? (Presumably this would need a new Editnotice: namespace if they want general availability.) -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 Krenair kren...@gmail.com changed: What|Removed |Added CC||kren...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 Krinkle krinklem...@gmail.com changed: What|Removed |Added Priority|Unprioritized |Normal Status|NEW |ASSIGNED CC||roan.katt...@gmail.com, ||tpars...@wikimedia.org Component|General |Initialisation and ||integration Assignee|jforres...@wikimedia.org|krinklem...@gmail.com --- Comment #5 from Krinkle krinklem...@gmail.com --- The only thing we need in core for en.wikipedia to drop this (assuming they still actively want to have these red links) is to show a red link to where the edit notice can be edited/created. Once that is in core, the enwiki's template doesn't have to generate it and thus the actual edit notice will be empty. As a workaround, I'll work on implementing a small jQuery plugin to calculate the visible text in an element. Then we can simply iterate over the edit notices in VE and ignore the ones with no visible text. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 --- Comment #6 from Krinkle krinklem...@gmail.com --- Change-Id: I65447da8b88a9bae9c24ff155544ff66b3fe9100 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 43013] VisualEditor: Deal with en.wikipedia.org's edit notice system
https://bugzilla.wikimedia.org/show_bug.cgi?id=43013 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #7 from Roan Kattouw roan.katt...@gmail.com --- (In reply to comment #6) Change-Id: I65447da8b88a9bae9c24ff155544ff66b3fe9100 Merged by Trevor -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
