[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 --- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 106429 merged by jenkins-bot: Move .data off DOM nodes https://gerrit.wikimedia.org/r/106429 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED CC||gwi...@wikimedia.org Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 Arlo Breault abrea...@wikimedia.org changed: What|Removed |Added Assignee|gwi...@wikimedia.org|abrea...@wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 106429 had a related patch set uploaded by Arlolra: WIP: Move .data off DOM nodes https://gerrit.wikimedia.org/r/106429 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 --- Comment #10 from Gabriel Wicke gwi...@wikimedia.org --- We discussed this more on IRC and figured that we could avoid giving DU internal state by attaching extra info to the document object in the longer term and to each node in the shorter term. That would leave us with DU.data(node) I guess. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 --- Comment #9 from Gabriel Wicke gwi...@wikimedia.org --- I'm not a fan of giving DU internal state, so IMO it might make more sense to use either DU.data(node, env) or env.getNodeData(node) I'd suggest both should return a reference to the actual object, which can be modified as needed. To completely replace the data entry, env.setNodeData(node, newData) could be used. Using separate getter/setters lets us add default values too. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 C. Scott Ananian canan...@wikimedia.org changed: What|Removed |Added CC||canan...@wikimedia.org --- Comment #7 from C. Scott Ananian canan...@wikimedia.org --- I suggest we first do a refactor to use uniformly use: DU.data(node) for getters, and maybe DU.data(node, new_data) for setters? Then we can easily experiment with/bikeshed different implementations of DU.data() under the hood -- first probably using a new 'parsoid-data' or 'dataobject' attribute, then later benchmarking against using an external map keyed on id, or an es6 weak map, or an es6 private field, etc. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 --- Comment #8 from Inez Korczyński i...@wikia-inc.com --- (In reply to comment #7) I suggest we first do a refactor to use uniformly use: DU.data(node) for getters, and maybe DU.data(node, new_data) for setters? Then we can easily experiment with/bikeshed different implementations of DU.data() under the hood -- first probably using a new 'parsoid-data' or 'dataobject' attribute, then later benchmarking against using an external map keyed on id, or an es6 weak map, or an es6 private field, etc. This plan sounds good to me. I could work on that. Gabriel: Could you confirm that you are ok with that solution? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added CC||abrea...@wikimedia.org --- Comment #6 from Gabriel Wicke gwi...@wikimedia.org --- /cc Arlo as he is working on external metadata and stable ids. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 --- Comment #3 from Gabriel Wicke gwi...@wikimedia.org --- This is indeed correct for object elements according to http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#the-object-element -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 --- Comment #4 from Inez Korczyński i...@wikia-inc.com --- (In reply to comment #3) This is indeed correct for object elements according to http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe- element.html#the-object-element Gabriel: Do you have a suggestion what the proper fix should look like? Use in Parsoid property different than data? (That would be a massive search and replace.) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 --- Comment #5 from Gabriel Wicke gwi...@wikimedia.org --- I see two options here: 1) Rename data to some other non-conflicting 'expando' property. Example: .dataobject to rhyme with .dataset This is used by jquery et al to store a string key for $.data. 2) Move all data out of the elements themselves and store them in an external data structure keyed on the id of the element. Jquery does this too, but uses an 'expando' property as in 1) instead of the id. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
--- Comment #2 from Inez Korczyński i...@wikia-inc.com ---
(In reply to comment #1)
This seems to be a bug in domino. It should not confuse the data attribute
with
the .data node object member.
I don't think it's a domino (or domino only) problem, try in a browser:
element = document.createElement('object');
element.setAttribute('data','123');
console.log(element.data);
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57394] Parsoid fails for OBJECT element
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394 --- Comment #1 from Gabriel Wicke gwi...@wikimedia.org --- This seems to be a bug in domino. It should not confuse the data attribute with the .data node object member. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
