[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 165980 had a related patch set uploaded by Florianschmidtwelzow: Revert Show talk button only when JS enabled or talk page not empty https://gerrit.wikimedia.org/r/165980 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 165980 merged by jenkins-bot: Revert Show talk button only when JS enabled or talk page not empty https://gerrit.wikimedia.org/r/165980 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Florian florian.schmidt.wel...@t-online.de changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #6 from Florian florian.schmidt.wel...@t-online.de --- Hmm, i don't know, if this colidates with bug 67819. But it's more important, that a user can see any talk page, if there is one. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 165694 had a related patch set uploaded by Florianschmidtwelzow: Revert partially: Show talk button only when JS enabled or talk page not empty https://gerrit.wikimedia.org/r/165694 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 165694 merged by jenkins-bot: Revert partially: Show talk button only when JS enabled or talk page not empty https://gerrit.wikimedia.org/r/165694 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Jon jrob...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Florian florian.schmidt.wel...@t-online.de changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=67819 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Jon jrob...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #9 from Jon jrob...@wikimedia.org --- Doesn't actually seem to have fixed it on alpha. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #10 from Florian florian.schmidt.wel...@t-online.de --- (In reply to Jon from comment #9) on alpha. Because i left the alpha code (see commit message) as an alpha feature, not good? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #11 from Jon jrob...@wikimedia.org --- Should remove it. Not sure why it needs to be hidden in alpha. As stated before, that page property value is not always set - especially with Flow pages :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Florian florian.schmidt.wel...@t-online.de changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |florian.schmidt.welzow@t-on |org |line.de --- Comment #12 from Florian florian.schmidt.wel...@t-online.de --- Ok, will do it tomorrow :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #5 from Jon jrob...@wikimedia.org --- Florian personally I'd remove the hidden class in alpha. It seems unnecessary and is wrong anyway ( some articles will have talk pages but no topic page prop value ) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #4 from Jon jrob...@wikimedia.org --- I guess we need to rethink this code. The fix should be in MobileFrontend I'm just not sure how best to do that. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #2 from Jon jrob...@wikimedia.org --- Weird. It will be something to do with how wfRunHooks( 'SkinMinervaDefaultModules', array( $this, $modules ) ); is run (which Flow uses). Not sure what is happening here. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Florian florian.schmidt.wel...@t-online.de changed: What|Removed |Added CC||florian.schmidt.welzow@t-on ||line.de --- Comment #3 from Florian florian.schmidt.wel...@t-online.de --- This seems to be because of how Alpha and stable recognize, if a talk button is useful or not. If the user has no JS enabled, the talk button should be hidden, if there is no talk page (the user can't create a page without JS in mobile) For this there are these implementations: Stable: Check if the talk element has a new class: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/skins/SkinMinerva.php#L725 (with flow, there will be never a new class?!) Alpha: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/skins/SkinMinervaAlpha.php#L74 Decide with the number of topics (which will be displayed in the talk icon). So, Flow never returns the number of topics, if i see this right, so the talk button will be hidden every time. talk.js isn't loaded on pages with flow talk pages, too (?!), so the hidden class will never be removed, like it will be on normal talk pages :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha
https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #1 from Bingle bingle-ad...@wikimedia.org --- Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/q3UhD8Ur -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
