[Bug 13163] Activate SubPageList3 extension on English Wikiversity
https://bugzilla.wikimedia.org/show_bug.cgi?id=13163 Tim Starling tstarl...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #17 from Tim Starling tstarl...@wikimedia.org 2011-06-28 06:52:04 UTC --- Done. It's enabled on all Wikiversities, not just English. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13163] Activate SubPageList3 extension on English Wikiversity
https://bugzilla.wikimedia.org/show_bug.cgi?id=13163 Jeroen De Dauw jeroen_ded...@yahoo.com changed: What|Removed |Added CC||jeroen_ded...@yahoo.com --- Comment #18 from Jeroen De Dauw jeroen_ded...@yahoo.com 2011-06-28 11:40:30 UTC --- I actually forked the extension and rewrite most of it at the beginning of January. See https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Extension:SubPageList This extension fixes a number of bugs in SubPageList3, cleans up the code, addresses some layout issues and is actually maintained. I (obviously) suggest using this one instead. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13163] Activate SubPageList3 extension on English Wikiversity
https://bugzilla.wikimedia.org/show_bug.cgi?id=13163 --- Comment #19 from Reedy s...@reedyboy.net 2011-06-28 15:22:22 UTC --- (In reply to comment #18) I actually forked the extension and rewrite most of it at the beginning of January. See https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Extension:SubPageList This extension fixes a number of bugs in SubPageList3, cleans up the code, addresses some layout issues and is actually maintained. I (obviously) suggest using this one instead. Validator has to be reviewed aswell to be able to do that -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13163] Activate SubPageList3 extension on English Wikiversity
https://bugzilla.wikimedia.org/show_bug.cgi?id=13163 --- Comment #20 from Jeroen De Dauw jeroen_ded...@yahoo.com 2011-06-28 15:38:28 UTC --- Ah, I suspected this was the issue. Fair enough - as long as you know there is a newer version. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13163] Activate SubPageList3 extension on English Wikiversity
https://bugzilla.wikimedia.org/show_bug.cgi?id=13163 --- Comment #21 from Reedy s...@reedyboy.net 2011-06-28 16:12:04 UTC --- (In reply to comment #20) Ah, I suspected this was the issue. Fair enough - as long as you know there is a newer version. Not really, AFAIK it wasn't even considered to be installed as the request was for Subpages3, and no one commented before... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13163] Activate SubPageList3 extension on English Wikiversity
https://bugzilla.wikimedia.org/show_bug.cgi?id=13163 Reedy s...@reedyboy.net changed: What|Removed |Added Keywords|need-review |reviewed -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13163] Activate SubPageList3 extension on English Wikiversity
https://bugzilla.wikimedia.org/show_bug.cgi?id=13163 Reedy s...@reedyboy.net changed: What|Removed |Added CC||s...@reedyboy.net --- Comment #16 from Reedy s...@reedyboy.net 2011-04-07 00:02:22 UTC --- r85590, r85593, r85594 does all the style cleanup r85596 does the parser issue Tim, if this is clean now, can it be pushed out? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13163] Activate SubPageList3 extension on English Wikiversity
https://bugzilla.wikimedia.org/show_bug.cgi?id=13163
Tim Starling tstarl...@wikimedia.org changed:
What|Removed |Added
CC||tstarl...@wikimedia.org
--- Comment #15 from Tim Starling tstarl...@wikimedia.org 2011-03-25 01:40:17
UTC ---
There are some style issues which anyone could fix up, like using English for
variable names:
$parlv = substr_count($this-ptitle-getPrefixedText(), '/');
whitespace, lack of line breaks where there should be line breaks:
switch( strtolower( $options['showpath'] ) ) {
case 'no': $this-showpath = 'no'; break;
...
if( $this-mode != 'bar' ) $pn = $this-token . $pn;
Also, it uses non-portable, unnecessary SQL identifier quoting:
$options['ORDER BY'] = '`page_title`' . $order;
...
$conditions[] = '`page_title` ' . $dbr-buildLike( $parent . '/',
$dbr-anyString() );
It uses Parser::parse() when it should be using Parser::recursiveTagParse().
This is an efficiency issue, since parse() does link existence checks
immediately, whereas recursiveTagParse() defers them until the next batch. It's
also a correctness issue, since recursiveTagParse() guards certain syntax
elements against reinterpretation, whereas parse() does not.
Otherwise it should be OK to enable.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13163] Activate SubPageList3 extension on English Wikiversity
https://bugzilla.wikimedia.org/show_bug.cgi?id=13163 Ashar Voultoiz has...@free.fr changed: What|Removed |Added Component|Site requests |Extension setup -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13163] Activate SubPageList3 extension on English Wikiversity
https://bugzilla.wikimedia.org/show_bug.cgi?id=13163 Siebrand s.mazel...@xs4all.nl changed: What|Removed |Added AssignedTo|br...@pobox.com |wikibug...@lists.wikimedia. ||org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
