[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus, keyboard accessibility
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus, keyboard accessibility
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 --- Comment #24 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 78071 merged by jenkins-bot: Accessibility: Don't arbitrarily override role https://gerrit.wikimedia.org/r/78071 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus, keyboard accessibility
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|PATCH_TO_REVIEW Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus, keyboard accessibility
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 --- Comment #23 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 78071 had a related patch set uploaded by TheDJ: Accessibility: Don't arbitrarily override role https://gerrit.wikimedia.org/r/78071 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus, keyboard accessibility
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 --- Comment #21 from Dan Wolff 326...@gmail.com --- (In reply to comment #20) I tested it again in Firefox 24 (Linux) and Chromium 28 (Linux) and it does work (using the deployed version at http://users.v-lo.krakow.pl/~matmarex/testwiki/). I'd say that that commit resolves this bug. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus, keyboard accessibility
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 Derk-Jan Hartman hartman.w...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 --- Comment #18 from Dan Wolff 326...@gmail.com --- @Bartosz #17: I tried creating an account on http://users.v-lo.krakow.pl/~matmarex/testwiki/. The arrow *is* focusable, and doesn't lose focus when clicking, but when it is focused, clicking Enter does nothing. So I'd say that so far this is *not* solved. I expect it to toggle when clicking Enter. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Blocks||35785 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 --- Comment #19 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 72719 had a related patch set uploaded by Matmarex: jquery.makeCollapsible: Togglers keyboard accessibility https://gerrit.wikimedia.org/r/72719 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 --- Comment #20 from Bartosz Dziewoński matma@gmail.com --- Hmph. I though browsers handle this magically, but it turns out only Opera is smart enough. I deployed the pending patch above (comment 19) as well – can you test again now? :) (Sorry about the back-and-forth.) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus, keyboard accessibility
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Summary|Enhanced recent changes |Enhanced recent changes |JavaScript: clicking arrow |JavaScript: clicking arrow |should keep it in focus |should keep it in focus, ||keyboard accessibility -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 --- Comment #16 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 72371 merged by jenkins-bot: jquery.makeCollapsible: Togglers accessibility https://gerrit.wikimedia.org/r/72371 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 --- Comment #17 from Bartosz Dziewoński matma@gmail.com --- Okay, that's merged. Can you check it out locally and see if it fixes the issue? (Or feel free to register an account and test on my test wiki at http://users.v-lo.krakow.pl/~matmarex/testwiki/ , where I have just deployed it. Please ignore the spambots. All edits must have a non-empty summary or they will be rejected by the spam filter.) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 --- Comment #13 from Dan Wolff 326...@gmail.com --- I can confirm that focus is kept in Opera 12.15 (Linux) using shift+arrows, enter. However, it does *not* work in Firefox 24 (Linux), not even when the setting to use cursor keys to navigate pages is active. In fact I can't focus it all in Firefox. I can't get it to work in Chromium 28 (Linux) either. Looking at the source, there's no link, nor tabindex. My guess is that Opera makes items which have a click handler focusable as well. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Keywords|design, patch, | |patch-reviewed | CC||hartman.w...@gmail.com Assignee|wikibugs-l@lists.wikimedia. |matma@gmail.com |org | Whiteboard|matmarex-verify | --- Comment #14 from Bartosz Dziewoński matma@gmail.com --- Hmm, yeah, Opera tends to be smarter than other browsers in places you don't expect. Let's try adding a tabindex and see what happens. [Updating keywords.] -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 --- Comment #15 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 72371 had a related patch set uploaded by Matmarex: jquery.makeCollapsible: Togglers accessibility https://gerrit.wikimedia.org/r/72371 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added CC||matma@gmail.com --- Comment #12 from Bartosz Dziewoński matma@gmail.com --- So it's 2013 now. The script that does this has been rewritten again approximately two times since the last comment, and in my testing using MW 1.22 alpha (deployed on Wikipedias) using Opera 12.15 the focus is kept when using keyboard navigation (Shift+arrows, Enter). Could someone verify? If this is the case, then it looks like this can be closed. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Whiteboard||matmarex-verify -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616
--- Comment #11 from Dan Wolff 326...@gmail.com 2012-03-11 19:31:47 UTC ---
Krinkle and I have spoken briefly about this bug and it seems like the reason
for preventing an a from initiating the toggle is to allow other links within
toggle elements (use case: a complete table row is used for toggling, except
that we want to have links in there too).
A fix that would solve this bug as well as allowing those links would be
replacing line 180 above with:
if ( $(e.target).is('a') !$that.is(e.target) ) {
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 Dan Wolff 326...@gmail.com changed: What|Removed |Added Version|1.15.x |1.19-svn --- Comment #10 from Dan Wolff 326...@gmail.com 2012-02-13 23:27:42 UTC --- Relevant code: http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/jquery/jquery.makeCollapsible.js?revision=94389view=markup#l180 Krinkle, is it necessary to prevent an a element from initiating the toggle? We want to be able to click the a to toggle (or press enter while it is focused), so that can't be prevented. I can think of a few solutions: * Don't prevent a elements (is this prevention needed anywhere?) * Add a parameter allowLinkAsTarget * Add a class to $that element to indicate that links (i.e. .mw-collapsible-toggle.mw-collapsible-allow-link) * Add a new function which doesn't prevent a elements Also, as a note: We'll need to change the HTML to only have *one* a for both images, since we don't want to focus the a when the page loads (the toggling function is performed once). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 --- Comment #9 from Dan Wolff 326...@gmail.com 2011-11-09 14:37:23 UTC --- I sure am interested in updating the fix, but I am preoccupied at the moment. If I haven't provided an update within a month, my priorities have changed and you shouldn't count on me doing it. Note: Such a fix should also remove the newly introduced (and related) bug: 1. Tab to an arrow 2. Press enter 3. Notice that the URL has changed (a # is added) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords||design, reviewed CC||suma...@panix.com --- Comment #8 from Sumana Harihareswara suma...@panix.com 2011-11-09 03:18:45 UTC --- +reviewed since it seems that we have reviewed the code submitted, although if I'm wrong someone should remove that and add the need-review keyword. Thank you for the patch, Dan; do you have the time and interest to update your fix? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 --- Comment #4 from Dan Wolff 326...@gmail.com 2011-03-05 19:29:41 UTC --- (In reply to comment #3) The enhanced changes have changed a fair bit since 1.17, notably the use of CSS and jQuery utility functions instead of images directly in the DOM. I think this is no longer an issue, someone else should confirm as well though (ideally the bug reporter) since I'm not entirely sure what the bug reporter meant and don't have a 1.15 around to experience the bug there. It seems like you are confused about the version numbers. The problem however still *does* exist at Wikimedia sites, e.g.: * http://en.wikipedia.org/wiki/Special:RecentChanges (using 1.17wmf1 (r82948)) * http://test.wikipedia.org/wiki/Special:RecentChanges (using 1.17wmf1 (r83154)) Perhaps the version number should be updated? Also, as of the deployed version, img tags are put directly into the HTML source; I don't recognize the use of CSS and jQuery utility functions instead of images directly in the DOM. Has this changed in 1.18? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 --- Comment #5 from DieBuche diebu...@gmail.com 2011-03-05 23:10:42 UTC --- Steps to reproduce: TAB through links in the page till you get to an arrow Hit Enter Focus is gone -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 --- Comment #6 from Krinkle krinklem...@gmail.com 2011-03-05 23:12:05 UTC --- It has changed in trunk / 1.18, but the bug is stil there. Instead of replacing the image itself, in 1.18 it has both and depending on whether the collapsible element is collapsed or expanded, one is display:none and the other display:block. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 DieBuche diebu...@gmail.com changed: What|Removed |Added CC||diebu...@gmail.com Summary|Recent changes JavaScript: |Enhanced recent changes |clicking arrow should keep |JavaScript: clicking arrow |it in focus |should keep it in focus -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 17616] Enhanced recent changes JavaScript: clicking arrow should keep it in focus
https://bugzilla.wikimedia.org/show_bug.cgi?id=17616 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #3 from Krinkle krinklem...@gmail.com 2011-03-03 13:23:04 UTC --- The enhanced changes have changed a fair bit since 1.17, notably the use of CSS and jQuery utility functions instead of images directly in the DOM. I think this is no longer an issue, someone else should confirm as well though (ideally the bug reporter) since I'm not entirely sure what the bug reporter meant and don't have a 1.15 around to experience the bug there. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
