[Bug 20112] Tests in /phase3/t/inc no longer work. Fix provided.
https://bugzilla.wikimedia.org/show_bug.cgi?id=20112 Ævar Arnfjörð Bjarmason ava...@gmail.com changed: What|Removed |Added CC||ava...@gmail.com Status|NEW |RESOLVED Resolution||FIXED --- Comment #7 from Ævar Arnfjörð Bjarmason ava...@gmail.com 2009-11-08 11:07:51 UTC --- Applied this patch with some fixes. RESOLVED FIXED in trunk. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20112] Tests in /phase3/t/inc no longer work. Fix provided.
https://bugzilla.wikimedia.org/show_bug.cgi?id=20112 --- Comment #4 from Dan Nessett dness...@yahoo.com 2009-08-10 20:12:52 UTC --- (In reply to comment #1) (In reply to comment #0) Moved up require of LocalSettings.php, because its definitions are now required by Autoloader.php. No, that's the opposite, AutoLoader.php is supposed be included before LocalSettings.php (as in includes/WebRequest.php). It appears that includes/WebRequest.php tests for the existence of $IP and if it is missing defines it (lines 61-63). I'm not sure what is going on here. For some reason Webstart wants to define $IP independently of its definition in LocalSettings.php. Maybe there is a good reason for this, but it's kind of clumsy (not to mention a potential source of bugs, since it means $IP is defined in two different place). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20112] Tests in /phase3/t/inc no longer work. Fix provided.
https://bugzilla.wikimedia.org/show_bug.cgi?id=20112 --- Comment #5 from Dan Nessett dness...@yahoo.com 2009-08-10 20:15:04 UTC --- (In reply to comment #4) Made the same mistake you did (in my case due to inattentive copying of text). That should be includes/WebStart.php. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20112] Tests in /phase3/t/inc no longer work. Fix provided.
https://bugzilla.wikimedia.org/show_bug.cgi?id=20112
--- Comment #6 from Dan Nessett dness...@yahoo.com 2009-08-11 00:02:36 UTC
---
Poking around for another purpose, I have found another file that defines $IP -
maintanence/Command.inc. It seems to me this is only looking for trouble. If
there is some reason why require_once('LocalSettings.php') will cause problems
in this file and WebStart.php, then LocalSettings.php should be broken into two
parts: 1) LocalSettingsCore.php and LocalSettingsNonCore.php (I am sure someone
can come up with better names than these). LocalSettingsCore.php should contain
definitions that any core MW php file can tolerate, such as the definition of
$IP. LocalSettingsNoneCore.php should contain those definitions that may cause
problems with one or more core MW files. Any or all core MW files can then
require LocalSettingsCore.php. I will post this proposal to wikitech.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20112] Tests in /phase3/t/inc no longer work. Fix provided.
https://bugzilla.wikimedia.org/show_bug.cgi?id=20112 --- Comment #2 from Alexandre Emsenhuber [IAlex] alex.emsenhu...@bluewin.ch 2009-08-09 20:54:42 UTC --- sorry, WebStart.php not WebRequest.php. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20112] Tests in /phase3/t/inc no longer work. Fix provided.
https://bugzilla.wikimedia.org/show_bug.cgi?id=20112 Brion Vibber br...@wikimedia.org changed: What|Removed |Added AssignedTo|wikibugs- |br...@wikimedia.org |l...@lists.wikimedia.org | Keywords||need-review, patch -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
