[Bug 23819] Special:RenameUser should allow suppression of automatically-created redirects

2011-03-01 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=23819

Amalthea amalthea.wikime...@googlemail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 CC||s...@reedyboy.net
 Resolution||FIXED

--- Comment #8 from Amalthea amalthea.wikime...@googlemail.com 2011-02-26 
21:01:11 UTC ---
Eh, I see now, having a checkbox default to 'true' isn't as straightforward.
r82804 consequently changes the default value of 'movepages' to 'false'.
Replacing
  $move_checked = $wgRequest-getCheck( 'movepages' );
by
  $move_checked = $wgRequest-getBool( 'movepages', !$wgRequest-wasPosted());
should be a good solution: defaults to true, and still allows to set either
state via url parameter.

--- Comment #9 from Reedy s...@reedyboy.net 2011-03-01 19:03:47 UTC ---
r83034

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 23819] Special:RenameUser should allow suppression of automatically-created redirects

2011-02-25 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=23819

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #7 from Reedy s...@reedyboy.net 2011-02-25 17:29:43 UTC ---
r82804

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 23819] Special:RenameUser should allow suppression of automatically-created redirects

2011-02-08 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=23819

xenocidic xenow...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #6 from xenocidic xenow...@gmail.com 2011-02-08 23:02:45 UTC ---
Ok, I have a real one now. We want to be able to pass a suppressRedirect=1 to
have the new box automatically ticked during usurp requests. Amalthea explained
to me this this is not possible because of lines 49 to to 60 of r81598.

---Amalthea wrote the following---
// If nothing given for these flags, assume they are checked
// unless this is a POST submission.
$move_checked = true;
$suppress_checked = false;
if ( $wgRequest-wasPosted() ) {
  if ( !$wgRequest-getCheck( 'movepages' ) ) {
$move_checked = false;
  }
  if ( $wgRequest-getCheck( 'suppressredirect' ) ) {
$suppress_checked = true;
  }
}

It disregards any values for the options movepages and suppressredirect if
they are passed in via url parameters. Why I don't know, they don't seem
sensitive enough for that to me. The check was introduced by Greg in revision
20843 when he made the movepages checkbox remember its status after a form
submit. When suppressredirect was added, the code for movepages was apparently
simply copypasted (as you can see the comment is still wrong), and inherited
that logic. In my opinion, that wasPosted check can be removed entirely here.
===ends===

Thanks for your swift attention to this.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 23819] Special:RenameUser should allow suppression of automatically-created redirects

2011-02-07 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=23819

xenocidic xenow...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #4 from xenocidic xenow...@gmail.com 2011-02-07 20:09:31 UTC ---
I've just tried testing this functionality at the prototype/release-en wiki and
was given the following error:

Invalid input

Backtrace:

#0
/srv/org/wikimedia/prototype/wikis/rc/extensions/CentralAuth/CentralAuthUser.php(861):
CentralAuthUser::validateList(Array)
#1
/srv/org/wikimedia/prototype/wikis/rc/extensions/CentralAuth/CentralAuthHooks.php(351):
CentralAuthUser-adminUnattach(Array)
#2 [internal function]: CentralAuthHooks::onRenameUserPreRename('45', 'About to
be ren...', 'Renamed user')
#3 /srv/org/wikimedia/prototype/wikis/rc/includes/Hooks.php(158):
call_user_func_array(Array, Array)
#4
/srv/org/wikimedia/prototype/wikis/rc/extensions/Renameuser/Renameuser_body.php(430):
wfRunHooks('RenameUserPreRe...', Array)
#5
/srv/org/wikimedia/prototype/wikis/rc/extensions/Renameuser/Renameuser_body.php(275):
RenameuserSQL-rename()
#6 /srv/org/wikimedia/prototype/wikis/rc/includes/SpecialPage.php(579):
SpecialRenameuser-execute(NULL)
#7 /srv/org/wikimedia/prototype/wikis/rc/includes/Wiki.php(250):
SpecialPage::executePath(Object(Title))
#8 /srv/org/wikimedia/prototype/wikis/rc/includes/Wiki.php(63):
MediaWiki-handleSpecialCases(Object(Title), Object(OutputPage),
Object(WebRequest))
#9 /srv/org/wikimedia/prototype/wikis/rc/index.php(114):
MediaWiki-performRequestForTitle(Object(Title), NULL, Object(OutputPage),
Object(User), Object(WebRequest))
#10 {main}


Not sure if this is a problem with the code itself, or something to do with the
configuration of the wiki. Figured I'd better leave a note here in case. 

I note that a user was renamed on Feb 3 seemingly without issue. Meanwhile
today, I wasn't able to get the rename to get through even unchecking the
different options.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 23819] Special:RenameUser should allow suppression of automatically-created redirects

2011-02-07 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=23819

Reedy s...@reedyboy.net changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #5 from Reedy s...@reedyboy.net 2011-02-07 20:10:44 UTC ---
CentralAuth isn't properly enabled on the wiki, so we get stupid errors like
this...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 23819] Special:RenameUser should allow suppression of automatically-created redirects

2010-10-08 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=23819

X! soxre...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||soxre...@gmail.com
 Resolution||FIXED

--- Comment #3 from X! soxre...@gmail.com 2010-10-08 13:01:55 UTC ---
r74510

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 23819] Special:RenameUser should allow suppression of automatically-created redirects

2010-09-23 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=23819

--- Comment #2 from xenocidic xenow...@gmail.com 2010-09-23 13:03:17 UTC ---
Still hoping to see this feature created. 

As it stands now, I manually move the pages ahead of the rename; it would be
nice to get it all wrapped up into one.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 23819] Special:RenameUser should allow suppression of automatically-created redirects

2010-06-30 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=23819

--- Comment #1 from Lewis Cawte lewisca...@hotmail.co.uk 2010-06-30 18:16:04 
BST ---
Hm, I might have a look at this.. It sounds like a good idea.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 23819] Special:RenameUser should allow suppression of automatically-created redirects

2010-06-07 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=23819

Raimond Spekking raimond.spekk...@gmail.com changed:

   What|Removed |Added

 CC||raimond.spekk...@gmail.com
  Component|Special pages   |Renameuser
Version|unspecified |any
 AssignedTo|wikibug...@lists.wikimedia. |jschulz_4...@msn.com
   |org |
Product|MediaWiki   |MediaWiki extensions

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l