[Bug 27468] Force underlined links don't work in 1.17 monobook

2011-02-20 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27468

--- Comment #4 from Derk-Jan Hartman hart...@videolan.org 2011-02-20 16:34:25 
UTC ---
Created attachment 8182
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=8182
Path to order userprefs correctly

OK, patch attached that will fix this. However, first some comments.

1: The order of loading these items is actually affixed in buildCssLinks() of
OutputPage.php
It was
other (static stuff, and all private modules, including user preferences css)
dynamiclinks (here is where the old style skins and other unported material
will be)
site
user

2: The type of the ResourceLoaderUserOptionsModule is private, not user and
buildcsslinks puts private modules with the 'other' modules.

I considered changing this simply to user, in the hope that that would fix it,
but I don't know what kind of consequences that has for caching etc. Also since
this order is actually rather specific, I went with the approach in my path.

I created an improved order in buildCssLinks that manually makes sure that the
css from the preferences is between the site css and the user css (as it has
always been). I'm also using a for loop, though we could of course continue to
use array_merge, in my experience though, it ordered 1 2 3 as 132 for some
strange reason, so i went with the foreach approach instead.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27468] Force underlined links don't work in 1.17 monobook

2011-02-20 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27468

Roan Kattouw roan.katt...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #5 from Roan Kattouw roan.katt...@gmail.com 2011-02-20 17:25:33 
UTC ---
Fixed in r82518.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27468] Force underlined links don't work in 1.17 monobook

2011-02-18 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27468

Derk-Jan Hartman hart...@videolan.org changed:

   What|Removed |Added

 CC||roan.katt...@gmail.com

--- Comment #3 from Derk-Jan Hartman hart...@videolan.org 2011-02-18 10:36:44 
UTC ---
Right ... @Roan, remember how I at one point stated that we did not need ALL
skins converted to ResourceLoader in 1.17 ? I was mistaken, we need it for this
issue.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27468] Force underlined links don't work in 1.17 monobook

2011-02-17 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27468

Phlip mediaw...@mrphlip.com changed:

   What|Removed |Added

 CC||mediaw...@mrphlip.com

--- Comment #2 from Phlip mediaw...@mrphlip.com 2011-02-17 09:34:13 UTC ---
The problem appears to be the a{} block in skins/monobook/main.css?301-1 on
line 65 (at least, that's where it is on the file currently on en.wikipedia).
The text-decoration:none; line there is overriding the
a{text-decoration:underline;} in the HTML (as they're the same specificity and
the stylesheet is imported after that decoration in the HTML).

Browsing SVN, the generation of that a{text-decoration:underline;} bit in the
HTML seems to have changed in trunk (moved from Skin.php to
ResourceLoaderUserOptionsModule.php) but it appears to still work in the same
way. And that block in skins/monobook/main.css isn't changed. So I suspect it
would still be broken in trunk, though I don't have a working trunk site to
test it on.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 27468] Force underlined links don't work in 1.17 monobook

2011-02-16 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=27468

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

 CC||m...@everybody.org

--- Comment #1 from Mark A. Hershberger m...@everybody.org 2011-02-17 
00:02:05 UTC ---
Why do you say probably?  Have you tested it anywhere?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l