https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
Bug 27528 depends on bug 27395, which changed state.
Bug 27395 Summary: Write unit tests for JavaScriptMinifier, CSSMin and CSSJanus
https://bugzilla.wikimedia.org/show_bug.cgi?id=27395
What|Old Value |New Valu
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
--- Comment #18 from P.Copp 2011-03-26 15:33:27 UTC
---
(In reply to comment #17)
> FYI, \f and \v aren't valid escapes in PHP < 5.2.5.
>
> We run PHP 5.2.4 in production. So, it's fixed in our code to \xb and \xc.
>
> http://www.mediawiki.
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
Neil Kandalgaonkar changed:
What|Removed |Added
CC||ne...@wikimedia.org
--- Comment #
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
--- Comment #16 from Roan Kattouw 2011-03-14 18:05:24
UTC ---
(In reply to comment #15)
> Thanks a lot. I really appreciate this being included in MediaWiki.
>
You should apply for commit access :)
> Just a small fix concerning the addition
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
--- Comment #15 from P.Copp 2011-03-14 15:56:12 UTC
---
Created attachment 8290
--> https://bugzilla.wikimedia.org/attachment.cgi?id=8290
Follow-up fix: don't insert newlines before increment operators
(In reply to comment #12)
> Patch comm
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
--- Comment #14 from Roan Kattouw 2011-03-14 13:38:29
UTC ---
(In reply to comment #13)
> Where are the tests?
# /trunk/phase3/tests/phpunit/includes/libs/JavaScriptMinifierTest.php (added)
in r83885
--
Configure bugmail: https://bugzilla.
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
Niklas Laxström changed:
What|Removed |Added
CC||niklas.laxst...@gmail.com
--- Commen
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
Roan Kattouw changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
--- Comment #11 from Roan Kattouw 2011-03-14 10:08:58
UTC ---
(In reply to comment #7)
> For now I removed $wgResourceLoaderMinifyJSVerticalSpace. As the new minifier
> knows when semicolon insertion will be triggered, it can safely put everyt
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
Max Semenik changed:
What|Removed |Added
Depends on||27395
--
Configure bugmail: https://bug
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
--- Comment #10 from Michael M. 2011-02-25 09:42:11 UTC
---
I had a quick look at some of the broken scripts and all had a /\/foo\// in
them. Especially in [[User:MBisanz/monobookrfa.js]] there isn't much other code
that could break. I didn't
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
--- Comment #9 from P.Copp 2011-02-24 15:16:40 UTC
---
Created attachment 8208
--> https://bugzilla.wikimedia.org/attachment.cgi?id=8208
List of enwiki user scripts which are currently broken
--
Configure bugmail: https://bugzilla.wikimedi
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
P.Copp changed:
What|Removed |Added
Attachment #8185|0 |1
is obsolete|
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
P.Copp changed:
What|Removed |Added
Severity|critical|normal
--
Configure bugmail: https://bugzill
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
--- Comment #7 from P.Copp 2011-02-21 18:15:02 UTC
---
Created attachment 8185
--> https://bugzilla.wikimedia.org/attachment.cgi?id=8185
New minifier which takes the division/regexp conflict into account
(In reply to comment #6)
> This has
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
Mark A. Hershberger changed:
What|Removed |Added
CC||m...@everybody.org
B
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
--- Comment #6 from Roan Kattouw 2011-02-19 12:32:32
UTC ---
(In reply to comment #5)
> Reopening per my comment above. As pointed out, it's not possible to minify js
> with simple regexes without breaking user code in some cases.
>
> FTR her
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
P.Copp changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
Roan Kattouw changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
P.Copp changed:
What|Removed |Added
CC||paul.copper...@gmail.com
--- Comment #3 from
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
PDD changed:
What|Removed |Added
Priority|Normal |High
--
Configure bugmail: https://bugzilla.wik
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
Salvatore Ingala changed:
What|Removed |Added
CC||spide...@katamail.com
--- Comment #
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
Derk-Jan Hartman changed:
What|Removed |Added
Blocks||27339
--
Configure bugmail: https:
https://bugzilla.wikimedia.org/show_bug.cgi?id=27528
Derk-Jan Hartman changed:
What|Removed |Added
CC||hart...@videolan.org,
24 matches
Mail list logo
