[Bug 28633] AbuseFilter should respect revdel flags

2013-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

--- Comment #25 from Andre Klapper aklap...@wikimedia.org ---
billinghurst / John Mark / Trijnstel:
Could you answer comment 24, please?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

--- Comment #26 from billinghurst billinghu...@gmail.com ---
I thought that was rhetorical.  I am comfortable to see changes at work, and it
is one that I have only tripped over once, so not one in which I am an expert.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Greg Grossmeier g...@wikimedia.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #27 from Greg Grossmeier g...@wikimedia.org ---
Thanks billinghurst, closing out this bug for now. Feel free to reopen or file
a new bug as appropriate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-04-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Rob Lanphier ro...@wikimedia.org changed:

   What|Removed |Added

   Assignee|tstarl...@wikimedia.org |wikibugs-l@lists.wikimedia.
   ||org

--- Comment #24 from Rob Lanphier ro...@wikimedia.org ---
Would it be ok for us to close this one as fixed, since Tim's fix handles the
most immediate issue?  At a minimum, I'm unassigning this from Tim, but we
understand there's potentially a feature request or two buried in here.  Might
be best to file those as separate issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-04-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Daniel Friesen mediawiki-b...@nadir-seen-fire.com changed:

   What|Removed |Added

 CC||mediawiki-bugs@nadir-seen-f
   ||ire.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-03-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

--- Comment #20 from billinghurst billinghu...@gmail.com ---
That would probably suffice as long as there was an easy means to collect all
the hits in the abusefilter, so the OS can review and then select those that
should be culled.  Doing one by one (for either) is a tad trying.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-03-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

--- Comment #21 from Trijnstel trijns...@hotmail.com ---
(In reply to comment #19)
 (In reply to comment #17)
  The user attempted to save the page at 13:02:56, and received a warning. 
  Then
  s/he clicked save again, and saved successfully at 13:03:20. 
  
  Because the first edit attempt was rejected with a warning, it was not
  associated with a revision, so deleting the revision which was subsequently
  created had no effect. I'm not sure what the best solution here is, maybe
  just a bulk suppression UI.
 
 This is a mess of an issue. :-(
 
 Perhaps we could automatically add a note on action=revisiondelete saying
 that
 there are AbuseFilter entries for a page of this title not associated with
 any
 particular revision, and asking the user to check to make sure they don't
 need
 to suppress these too? Somewhat succinctly (albeit not hugely accurately),
 there are possible matching AbuseFilter entries for this page title?

I agree, that's a possibility. But, abusefilter logs can only be hidden by
oversighters and as nlwiki doesn't have local OS no one can hide the entries
apart from the stewards (and most of the local users do not even know you *can*
hide those). That's why it would be nice if they would be automatically be
hidden (even a revdel system for the logs perhaps?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-03-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

--- Comment #22 from James Forrester jforres...@wikimedia.org ---
(In reply to comment #21)
 (In reply to comment #19)
  Perhaps we could automatically add a note on action=revisiondelete saying
  that there are AbuseFilter entries for a page of this title not 
  associated with any particular revision, and asking the user to check to
  make sure they don't need to suppress these too? Somewhat succinctly 
  (albeit 
  not hugely accurately), there are possible matching AbuseFilter entries
  for this page title?
 
 I agree, that's a possibility. But, abusefilter logs can only be hidden by
 oversighters and as nlwiki doesn't have local OS no one can hide the entries
 apart from the stewards (and most of the local users do not even know you
 *can* hide those). That's why it would be nice if they would be automatically
 be hidden (even a revdel system for the logs perhaps?)

The problem is that the RevDel system is about deleting revisions and log
entries; AF log entries that block a save don't get associated with a revision,
so AF can't automatically hide these. The automatic-hiding-of-AF-hits can only
work because the AF hit is recorded against a revision that is being
suppressed. My suggestion would at least highlight that further work could be
needed.

Presumably if NLwiki has no oversighters it also can't suppress the edits using
RevDelete, so they are just leaving them available to any passing sysop? That's
rather troubling. Theoretically NLwiki could extend the hide this AF hit to
local sysops (assuming that's OK with legal and the community itself?), but if
they are dealing with a lot of these issues they should probably consider
getting some local OSers like other big wikis with this issue. If neither of
these options appeal, at the least if the notice is present it could be locally
adjust to advise asking for a steward to help.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-03-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

--- Comment #23 from Trijnstel trijns...@hotmail.com ---
(In reply to comment #22)
 (In reply to comment #21)
  (In reply to comment #19)
   Perhaps we could automatically add a note on action=revisiondelete saying
   that there are AbuseFilter entries for a page of this title not 
   associated with any particular revision, and asking the user to check to
   make sure they don't need to suppress these too? Somewhat succinctly 
   (albeit 
   not hugely accurately), there are possible matching AbuseFilter entries
   for this page title?
  
  I agree, that's a possibility. But, abusefilter logs can only be hidden by
  oversighters and as nlwiki doesn't have local OS no one can hide the entries
  apart from the stewards (and most of the local users do not even know you
  *can* hide those). That's why it would be nice if they would be 
  automatically
  be hidden (even a revdel system for the logs perhaps?)
 
 The problem is that the RevDel system is about deleting revisions and log
 entries; AF log entries that block a save don't get associated with a
 revision,
 so AF can't automatically hide these. The automatic-hiding-of-AF-hits can
 only
 work because the AF hit is recorded against a revision that is being
 suppressed. My suggestion would at least highlight that further work could be
 needed.
 
 Presumably if NLwiki has no oversighters it also can't suppress the edits
 using
 RevDelete, so they are just leaving them available to any passing sysop?
 That's
 rather troubling. Theoretically NLwiki could extend the hide this AF hit to
 local sysops (assuming that's OK with legal and the community itself?), but
 if
 they are dealing with a lot of these issues they should probably consider
 getting some local OSers like other big wikis with this issue. If neither of
 these options appeal, at the least if the notice is present it could be
 locally
 adjust to advise asking for a steward to help.

Sure, stewards help where they can. And personally I don't see the need for
local oversighters, nor does the community. But isn't it possible then to give
admins the rights to revdel abuse filter log entries? (instead of only be able
to suppress these) In that case admins could revdel them and with real privacy
issues stewards could suppress them as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-03-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

 CC||jforres...@wikimedia.org

--- Comment #19 from James Forrester jforres...@wikimedia.org ---
(In reply to comment #17)
 The user attempted to save the page at 13:02:56, and received a warning. Then
 s/he clicked save again, and saved successfully at 13:03:20. 
 
 Because the first edit attempt was rejected with a warning, it was not
 associated with a revision, so deleting the revision which was subsequently
 created had no effect. I'm not sure what the best solution here is, maybe
 just a bulk suppression UI.

This is a mess of an issue. :-(

Perhaps we could automatically add a note on action=revisiondelete saying that
there are AbuseFilter entries for a page of this title not associated with any
particular revision, and asking the user to check to make sure they don't need
to suppress these too? Somewhat succinctly (albeit not hugely accurately),
there are possible matching AbuseFilter entries for this page title?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-03-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Greg Grossmeier g...@wikimedia.org changed:

   What|Removed |Added

   Assignee|agarr...@wikimedia.org  |tstarl...@wikimedia.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-03-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Greg Grossmeier g...@wikimedia.org changed:

   What|Removed |Added

 CC||g...@wikimedia.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-03-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

--- Comment #17 from Tim Starling tstarl...@wikimedia.org ---
(In reply to comment #16)
 Confirmed.  One edit was revdel'd and then later suppressed at nlwiki.  It
 had
 tripped  and that resulted in 8 (2x4) logged filter additions that needed to
 be
 suppressed. And they had to be suppressed individually, no checkbox to select
 to group apply.
 
 https://nl.wikipedia.org/w/index.
 php?title=Speciaal%3ALogboekentype=suppressuser=page=year=month=-
 1tagfilter=hide_patrol_log=1

So there are two bugs here.

The user attempted to save the page at 13:02:56, and received a warning. Then
s/he clicked save again, and saved successfully at 13:03:20. 

Because the first edit attempt was rejected with a warning, it was not
associated with a revision, so deleting the revision which was subsequently
created had no effect. I'm not sure what the best solution here is, maybe just
a bulk suppression UI.

The second edit attempt succeeded, but afl_rev_id was still not set, because of
interaction with the autosummary feature.

if ( ( $vars-getVar('article_prefixedtext')-toString() !==
$article-getTitle()-getPrefixedText() ) ||
( $vars-getVar('summary')-toString() !== $summary )
) {
return true;
}

If the summary is different after the edit is saved compared to when the filter
was run, afl_rev_id is not updated. The edit in question did have an
autosummary, and I've confirmed locally that enabling autosummaries allows the
bug to be reproduced.

Just removing the summary condition should fix that part of it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-03-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

--- Comment #18 from Tim Starling tstarl...@wikimedia.org ---
(In reply to comment #17)
 Just removing the summary condition should fix that part of it.

I94321905f38eafde8add00eff73745af255c1f15

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-03-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Trijnstel trijns...@hotmail.com changed:

   What|Removed |Added

 CC||trijns...@hotmail.com
 Blocks||41492

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-03-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Trijnstel trijns...@hotmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #15 from Trijnstel trijns...@hotmail.com ---
still not fixed as the log entries are still visible when someone revdel or
suppress and edit -- it seems to be deployed in gerrit (see above)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-03-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Marius Hoch h...@online.de changed:

   What|Removed |Added

 CC||h...@online.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2013-03-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

billinghurst billinghu...@gmail.com changed:

   What|Removed |Added

 CC||billinghu...@gmail.com

--- Comment #16 from billinghurst billinghu...@gmail.com ---
Confirmed.  One edit was revdel'd and then later suppressed at nlwiki.  It had
tripped  and that resulted in 8 (2x4) logged filter additions that needed to be
suppressed. And they had to be suppressed individually, no checkbox to select
to group apply.

https://nl.wikipedia.org/w/index.php?title=Speciaal%3ALogboekentype=suppressuser=page=year=month=-1tagfilter=hide_patrol_log=1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2012-11-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Andrew Garrett agarr...@wikimedia.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2012-06-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Thehelpfulone thehelpfulonew...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #14 from Thehelpfulone thehelpfulonew...@gmail.com 2012-06-02 
18:05:13 UTC ---
Reopening, this still has not been fixed yet,
https://gerrit.wikimedia.org/r/#/c/3435/ is where it is in gerrit.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2012-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Andrew Garrett agarr...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #13 from Andrew Garrett agarr...@wikimedia.org 2012-02-10 
23:41:29 UTC ---
Fix committed in r111217. Comments welcomed.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2012-01-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

--- Comment #10 from Thehelpfulone thehelpfulonew...@gmail.com 2012-01-12 
18:33:23 UTC ---
So I asked an oversighter who knows about this bug to justify why it should be
a higher priority, speaking from their experience:

As it stands, when an oversighter suppresses something, we have to go hunting
to find out if a log exists, then find it, then suppress it separately. It
doubles both the time required, and the likelihood that private information
will be missed accidentally

I believe this is a strong argument for fixing this bug more quickly. Hope you
agree. - THO

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2012-01-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Normal  |Highest

--- Comment #11 from Mark A. Hershberger m...@everybody.org 2012-01-12 
18:38:26 UTC ---
Re-raising to HIGHEST after reading Thehelpfulone's explanation and the
possibility of private information leaking out.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2012-01-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Highest |High

--- Comment #12 from Mark A. Hershberger m...@everybody.org 2012-01-12 
19:29:46 UTC ---
Not on fire, so Higher

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2012-01-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Keywords|bugsmash|platformeng
   Priority|Lowest  |Highest

--- Comment #7 from Mark A. Hershberger m...@everybody.org 2012-01-03 
17:40:27 UTC ---
Bumping priority. Thehelpfulone tells me via email:

 this bug is, in my
 opinon, very crucial to fix as it means that if a page has been oversighted
 but it was flagged by an abuse filter, then the logs of this abuse filter
 will show the content of the oversighted page. Therefore, this currently
 means that oversighters need to oversight 2 things - the page itself *and* the
 abuse filter log. This can unfortunately create a lot of extra work for
 them, so if this bug could be fixed, I'm sure they would appreciate it,
 especially as most of these oversighted pages contain sensitive personal
 information.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2012-01-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Rob Lanphier ro...@wikimedia.org changed:

   What|Removed |Added

   Priority|Highest |Normal
 CC||ro...@wikimedia.org

--- Comment #8 from Rob Lanphier ro...@wikimedia.org 2012-01-03 22:41:48 UTC 
---
Bumping back to normal priority.  Mark, let's talk about the correct priority
for this?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2012-01-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

--- Comment #9 from Mark A. Hershberger m...@everybody.org 2012-01-04 
00:42:43 UTC ---
(In reply to comment #8)
 Bumping back to normal priority.  Mark, let's talk about the correct priority
 for this?

Yeah, highest was probably over-the-top.  But normal is higher than lowest,
so I'm happy.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2011-05-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Normal  |Lowest

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2011-05-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

--- Comment #6 from Andrew Garrett agarr...@wikimedia.org 2011-05-22 08:07:59 
UTC ---
(In reply to comment #5)
 This could be more easily implemented once bug 18374 is solved.

Well, not quite. They would both be made easier by a particular change to the
filter's functionality.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2011-05-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

--- Comment #4 from Andrew Garrett agarr...@wikimedia.org 2011-05-21 14:44:14 
UTC ---
For now this is probably in the patches welcome category.

What would be necessary would be to hook the revision deleted event, and,
when that occurs, find the filter log entries with the same title, user and
timestamp, and set their afl_deleted flags to the appropriate value.

It would not be advisable to do this dynamically, as the original reporter
suggests.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2011-05-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

--- Comment #5 from John Mark Vandenberg jay...@gmail.com 2011-05-22 02:38:09 
UTC ---
This could be more easily implemented once bug 18374 is solved.
Also, I was wrong about AbuseFilter 'visibility' being unnecessary once this
bug is solved, as it would still be needed for AF log entries about edits which
were never saved.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2011-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Thehelpfulone thehelpfulonew...@gmail.com changed:

   What|Removed |Added

 AssignedTo|wikibugs-l@lists.wikimedia. |agarr...@wikimedia.org
   |org |

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2011-05-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Thehelpfulone thehelpfulonew...@gmail.com changed:

   What|Removed |Added

 CC||thehelpfulonew...@gmail.com
   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=18043

--- Comment #3 from Thehelpfulone thehelpfulonew...@gmail.com 2011-05-19 
20:57:03 UTC ---
I just noticed this bug, was going to post a new one - but:


Basically, I would like to be able to have a feature for admins to be able to
effectively revdelete abuse filter logs, just as Oversights can suppress them
thanks to the bug being fixed.

There's some filters that are more likely to have the need for suppression, and
whilst they will eventually need supression by an oversighter, and admin could
easily help out temporarily to hide it.

I don't know how easy/difficult this would be to implement.

Thanks,

Thehelpfulone

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2011-04-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Keywords||bugsmash

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2011-04-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
URL||triage
 CC||m...@everybody.org

--- Comment #1 from Mark A. Hershberger m...@everybody.org 2011-04-21 
20:31:33 UTC ---
Is this related to why I can't see the contents of the page you
mention in Bug #28632 even though you have undeleted it?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 28633] AbuseFilter should respect revdel flags

2011-04-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=28633

--- Comment #2 from John Mark Vandenberg jay...@gmail.com 2011-04-21 21:08:57 
UTC ---
(In reply to comment #1)
 Is this related to why I can't see the contents of the page you
 mention in Bug #28632 even though you have undeleted it?

No.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l