[Bug 56196] Flow: Square brackets are present in URLs, leading to possible misinterpretation
https://bugzilla.wikimedia.org/show_bug.cgi?id=56196 MZMcBride b...@mzmcbride.com changed: What|Removed |Added CC||b...@mzmcbride.com --- Comment #13 from MZMcBride b...@mzmcbride.com --- Another example: https://www.mediawiki.org/w/index.php?title=Talk:Flowtopic[postId]=050f90d90ce1662828ca90b11c28d444workflow=050f6a5c16971e9b25a890b11c27a364 Please do not use [ and ] in the URL. This breaks wikimarkup (try making an external link with the URL above in it) and is just generally ugly and bad. The use of [ and ] in URLs is definitely a valid bug. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56196] Flow: Square brackets are present in URLs, leading to possible misinterpretation
https://bugzilla.wikimedia.org/show_bug.cgi?id=56196 --- Comment #12 from sp...@wikimedia.org --- (In reply to comment #9) Another group of unescaped brackets, found in all comment links in history pages, eg. http://ee-flow.wmflabs.org/w/index.php?title=User_talk: Quiddityworkflow=0506915cf3d0b62ef835fa163e68c4acaction=topic-history If I View Source of that page, or select added a comment and View Selection Source, I see %5B and %5D in the HTML, not square brackets. (In reply to comment #10) Also in diffs, eg Again, if you View Source the URLs of the history page and 20 days ago links contain %5B and %5D, not brackets. Note that when you mouse over these, and when you copy and paste them, your browser shows you '[' and ']' in place of the %5B and %5D -- try it with the URL in comment #8 -- so it's hard to tell what's going on. View Source. (In reply to comment #11) That seems like a bug. The hyperlink ends at the square brackets. I don't know if Flow should be escaping URLs before submitting to Parsoid or if Parsoid is doing something wrong. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56196] Flow: Square brackets are present in URLs, leading to possible misinterpretation
https://bugzilla.wikimedia.org/show_bug.cgi?id=56196 Oliver Keyes oke...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |High -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56196] Flow: Square brackets are present in URLs, leading to possible misinterpretation
https://bugzilla.wikimedia.org/show_bug.cgi?id=56196 Quiddity pandiculat...@gmail.com changed: What|Removed |Added CC||bs...@wikimedia.org, ||mpinc...@wikimedia.org --- Comment #11 from Quiddity pandiculat...@gmail.com --- Another fresh example. This is causing problems. https://www.mediawiki.org/w/index.php?title=Talk:Sandboxworkflow=050defb4e07513ccf17190b11c2d680e#flow-post-050df155089fcfb51c0e782bcb016050 (Also, the mingle card needs to be re-opened, but I cannot change the Accepted status: https://wikimedia.mingle.thoughtworks.com/projects/flow/cards/363 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56196] Flow: Square brackets are present in URLs, leading to possible misinterpretation
https://bugzilla.wikimedia.org/show_bug.cgi?id=56196 --- Comment #10 from Quiddity pandiculat...@gmail.com --- Also in diffs, eg https://www.mediawiki.org/w/index.php?title=Talk:Sandboxtopic[newRevision]=050c87914c196f3747a890b11c28d448topic[oldRevision]=050c878e4ad055356901842b2b77d2bdworkflow=050c553390ab9384b03a842b2b77e406action=compare-revisions (I'm not sure if these additional examples help, or if they'll all be automagically fixed via a single change somewhere? Let me know :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56196] Flow: Square brackets are present in URLs, leading to possible misinterpretation
https://bugzilla.wikimedia.org/show_bug.cgi?id=56196 --- Comment #9 from Quiddity pandiculat...@gmail.com --- Another group of unescaped brackets, found in all comment links in history pages, eg. http://ee-flow.wmflabs.org/w/index.php?title=User_talk:Quiddityworkflow=0506915cf3d0b62ef835fa163e68c4acaction=topic-history leads to http://ee-flow.wmflabs.org/w/index.php?title=User_talk:Quidditytopic[postId]=05093fcf969b34dffb6efa163e68c4acworkflow=0506915cf3d0b62ef835fa163e68c4acaction=view -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56196] Flow: Square brackets are present in URLs, leading to possible misinterpretation
https://bugzilla.wikimedia.org/show_bug.cgi?id=56196 sp...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from sp...@wikimedia.org --- Andrew and S can't reproduce, so closed in Mingle, and here. ErikB says square brackets are the way that MediaWiki can pass array arguments in URLs, that's a good reason to use them. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56196] Flow: Square brackets are present in URLs, leading to possible misinterpretation
https://bugzilla.wikimedia.org/show_bug.cgi?id=56196 Oliver Keyes oke...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #6 from Oliver Keyes oke...@wikimedia.org --- Reopening; S, you reproduced an example of this kind of URL in bug #56300 ;p -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56196] Flow: Square brackets are present in URLs, leading to possible misinterpretation
https://bugzilla.wikimedia.org/show_bug.cgi?id=56196 --- Comment #7 from Quiddity pandiculat...@gmail.com --- Also middle-clicking on Older topics (to open in a new tab) gives this: http://ee-flow.wmflabs.org/w/index.php?title=Special:Flow/Sandboxtopic_list[offset-id]=050805974f590e132562fa163e68c4actopic_list[offset-dir]=fwdtopic_list[limit]=5workflow=0503c3d2e3d2ad56ca39fa163e68c4acaction=view -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56196] Flow: Square brackets are present in URLs, leading to possible misinterpretation
https://bugzilla.wikimedia.org/show_bug.cgi?id=56196 --- Comment #8 from Erik Bernhardson ebernhard...@wikimedia.org --- And for reference, the 'fixed' version of quidditys example url is: http://ee-flow.wmflabs.org/w/index.php?title=Special:Flow/Sandboxtopic_list%5Boffset-id%5D=050805974f590e132562fa163e68c4actopic_list%5Boffset-dir%5D=fwdtopic_list%5Blimit%5D=5workflow=0503c3d2e3d2ad56ca39fa163e68c4acaction=view This is basically urlencode( 'topic_list[offset-dir]' ) which returns 'topic_list%5Boffset-dir%5D' -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56196] Flow: Square brackets are present in URLs, leading to possible misinterpretation
https://bugzilla.wikimedia.org/show_bug.cgi?id=56196 Oliver Keyes oke...@wikimedia.org changed: What|Removed |Added Summary|Square brackets in URLs are |Flow: Square brackets are |bad |present in URLs, leading to ||possible misinterpretation -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56196] Flow: Square brackets are present in URLs, leading to possible misinterpretation
https://bugzilla.wikimedia.org/show_bug.cgi?id=56196 Andrew Garrett agarr...@wikimedia.org changed: What|Removed |Added CC||agarr...@wikimedia.org --- Comment #2 from Andrew Garrett agarr...@wikimedia.org --- Unable to reproduce. I looked at a few URLs displayed in the interface, and they're all escaped correctly. Where did you get this link? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56196] Flow: Square brackets are present in URLs, leading to possible misinterpretation
https://bugzilla.wikimedia.org/show_bug.cgi?id=56196 --- Comment #3 from Quiddity pandiculat...@gmail.com --- Example link taken from the workshop notes: http://ee-flow.wmflabs.org/w/index.php?title=Talk:Flow_workshopworkflow=0506fc4aad826e5b09a3fa163e68c4acaction=view#flow-post-0506fd0ed2010e132562fa163e68c4ac So might be old and fixed now. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56196] Flow: Square brackets are present in URLs, leading to possible misinterpretation
https://bugzilla.wikimedia.org/show_bug.cgi?id=56196 --- Comment #4 from Andrew Garrett agarr...@wikimedia.org --- S, care to elaborate? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
