https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
Helder he7...@gmail.com changed:
What|Removed |Added
Status|RESOLVED|VERIFIED
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #23 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 141284 merged by jenkins-bot:
Use new OutputPageScriptsForBottomQueue hook
https://gerrit.wikimedia.org/r/141284
--
You are receiving this mail because:
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:
What|Removed |Added
Status|PATCH_TO_REVIEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #22 from MZMcBride b...@mzmcbride.com ---
(In reply to Gerrit Notification Bot from comment #18)
Change 141284 had a related patch set uploaded by Legoktm:
Use new OutputPageScriptsForBottomQueue hook
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #20 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 141282 merged by jenkins-bot:
Add OutputPageScriptsForBottomQueue hook
https://gerrit.wikimedia.org/r/141282
--
You are receiving this mail because:
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #21 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 127461 abandoned by Legoktm:
Create ResourceLoaderUncachedRegistrationModule
https://gerrit.wikimedia.org/r/127461
--
You are receiving this mail because:
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 141282 had a related patch set uploaded by Legoktm:
Add OutputPageScriptsForBottomQueue hook
https://gerrit.wikimedia.org/r/141282
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #18 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 141284 had a related patch set uploaded by Legoktm:
Use new OutputPageScriptsForBottomQueue hook
https://gerrit.wikimedia.org/r/141284
--
You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #19 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
(In reply to Krinkle from comment #16)
3) I'd recommend simply going for the same approach as for local 'user'.
Make the script and link directly. Have a
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #16 from Krinkle krinklem...@gmail.com ---
Okay, there's tons of messages back and forth and implementation has changed
many times.
A fresh brain dump:
1) The startup module can't be relied upon for user specific modules. We
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #15 from Ori Livneh o...@wikimedia.org ---
From https://gerrit.wikimedia.org/r/127457 again:
---
Timo, the reason for position = top is to be found in
OutputPage::getHeadScripts. To ensure the module version is always up-to-date,
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 127457 abandoned by Legoktm:
Add OutputPageScriptsForBottomQueue hook
https://gerrit.wikimedia.org/r/127457
--
You are receiving this mail because:
You are the
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #13 from MZMcBride b...@mzmcbride.com ---
From https://gerrit.wikimedia.org/r/127457:
---
As discussed on IRC, setting group = user and position = top in the resource
definition will have the same effect without requiring a hook.
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 127461 had a related patch set uploaded by Legoktm:
Set group=user and position= top for ext.globalCssJs.user
https://gerrit.wikimedia.org/r/127461
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|NEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 127457 had a related patch set uploaded by Legoktm:
Add OutputPageScriptsForBottomQueue hook
https://gerrit.wikimedia.org/r/127457
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #11 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
I looked into turning it into a dependency, but I don't think that would be
possible since the 'user' module is registered before GlobalCssJs would have a
chance to
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
--- Comment #9 from Ori Livneh o...@wikimedia.org ---
The URLs for loading the user and user.group modules is constructed in PHP, in
lines 2906 - 2929 of OutputPage.php (@829886b10a). (The modules are not
versioned via the startup module and
https://bugzilla.wikimedia.org/show_bug.cgi?id=62602
Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:
What|Removed |Added
CC|
19 matches
Mail list logo
