[Bug 70599] Add new metric Time to review for Open reviews from last uploaded patch

2014-09-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70599

Quim Gil q...@wikimedia.org changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Quim Gil q...@wikimedia.org ---
I have checked exhaustively the current top 10 at Ranking of repositories and
the numbers make sense now. Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70599] Add new metric Time to review for Open reviews from last uploaded patch

2014-09-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70599

Quim Gil q...@wikimedia.org changed:

   What|Removed |Added

   Assignee|wikibugs-l@lists.wikimedia. |a...@bitergia.com
   |org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70599] Add new metric Time to review for Open reviews from last uploaded patch

2014-09-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70599

--- Comment #4 from Alvaro a...@bitergia.com ---
(In reply to Quim Gil from comment #2)
 (In reply to Alvaro from comment #1)
  Metric implemented and added to korma panel:
  
  http://korma.wmflabs.org/browser/gerrit_review_queue.html
 
 Good, thank you! You can remove the line for Most recent updates in Age
 of open changesets, since it is not really relevant.
 

Removed.

 
  The list of repositories is now ordered using this new metric.
 
 Maybe this is something temporary, but TorBlock appears as #1 when
 (according to the data shown) it shouldn't.

Let me check ... TorBlock data:

http://korma.wmflabs.org/browser/data/json/gerrit.wikimedia.org_mediawiki_extensions_TorBlock-scr-rep-static.json

has the review_time_pending_upload_days_median: 495.291249 used for
ordering. And it is the higher one. I need to cross check it with evolution in
time. We will updated this ticket once we have a detailed answer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70599] Add new metric Time to review for Open reviews from last uploaded patch

2014-09-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70599

--- Comment #5 from Alvaro a...@bitergia.com ---
(In reply to Quim Gil from comment #3)
 How complex would it be to compute Date of submission of open changesets
 by the date of the last upload, instead of the initial upload? If it's not
 too complicated, the data based on last upload would be more useful, because
 we could clearly see the old stuff that is there, just rotting.

In this graph we are showing the distribution of current open changesets using
the submission time. We can play with it to use the upload time, yes. Let's
open a new ticket to follow it.

https://bugzilla.wikimedia.org/show_bug.cgi?id=70650

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70599] Add new metric Time to review for Open reviews from last uploaded patch

2014-09-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70599

--- Comment #6 from Quim Gil q...@wikimedia.org ---
(In reply to Alvaro from comment #4)
 Let me check ... TorBlock data:
 
 http://korma.wmflabs.org/browser/data/json/gerrit.wikimedia.
 org_mediawiki_extensions_TorBlock-scr-rep-static.json
 
 has the review_time_pending_upload_days_median: 495.291249 used
 for ordering. And it is the higher one.

This is not what Gerrit says:

https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/TorBlock,n,z

Only one patch waiting for review, with a las version uploaded on 21 August
2014 (only 20 days ago)

https://gerrit.wikimedia.org/r/#/c/62026/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70599] Add new metric Time to review for Open reviews from last uploaded patch

2014-09-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70599

--- Comment #7 from Alvaro a...@bitergia.com ---
(In reply to Quim Gil from comment #6)
 (In reply to Alvaro from comment #4)
  Let me check ... TorBlock data:
  
  http://korma.wmflabs.org/browser/data/json/gerrit.wikimedia.
  org_mediawiki_extensions_TorBlock-scr-rep-static.json
  
  has the review_time_pending_upload_days_median: 495.291249 used
  for ordering. And it is the higher one.
 
 This is not what Gerrit says:
 
 https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/
 TorBlock,n,z
 
 Only one patch waiting for review, with a las version uploaded on 21 August
 2014 (only 20 days ago)
 
 https://gerrit.wikimedia.org/r/#/c/62026/

Yes, we have fixed a problem in time series for upload (aggregated information
used for ordering was right). We are rechecking the logic to detect that a
review is waiting for Submitter. 

Right now rechecking the data about TorBlock.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70599] Add new metric Time to review for Open reviews from last uploaded patch

2014-09-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70599

--- Comment #8 from Alvaro a...@bitergia.com ---
(In reply to Alvaro from comment #7)
 (In reply to Quim Gil from comment #6)
  (In reply to Alvaro from comment #4)
   Let me check ... TorBlock data:
   
   http://korma.wmflabs.org/browser/data/json/gerrit.wikimedia.
   org_mediawiki_extensions_TorBlock-scr-rep-static.json
   
   has the review_time_pending_upload_days_median: 495.291249 used
   for ordering. And it is the higher one.
  
  This is not what Gerrit says:
  
  https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/
  TorBlock,n,z
  
  Only one patch waiting for review, with a las version uploaded on 21 August
  2014 (only 20 days ago)
  
  https://gerrit.wikimedia.org/r/#/c/62026/
 
 Yes, we have fixed a problem in time series for upload (aggregated
 information used for ordering was right). We are rechecking the logic to
 detect that a review is waiting for Submitter. 
 
 Right now rechecking the data about TorBlock.

Yes, in the SQL we were not using the min upload time. It is fixed and
regenerating the metrics now. It is hard to include all the logic in SQL that
we are reaching. I hope that with this fix the resulting metric is right. Once
the new metrics are available I will recheck them with several repositories to
be sure about them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70599] Add new metric Time to review for Open reviews from last uploaded patch

2014-09-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70599

--- Comment #9 from Alvaro a...@bitergia.com ---
Quim, we have updated the JSON data for:

http://korma.wmflabs.org/browser/gerrit_review_queue.html

Now the upload time is in general lower than before, and the data is more
accurate.

You can consult TorBlock data at:

http://korma.wmflabs.org/browser/repository.html?repository=gerrit.wikimedia.org_mediawiki_extensions_TorBlock

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70599] Add new metric Time to review for Open reviews from last uploaded patch

2014-09-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70599

Alvaro a...@bitergia.com changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

--- Comment #1 from Alvaro a...@bitergia.com ---
Metric implemented and added to korma panel:

http://korma.wmflabs.org/browser/gerrit_review_queue.html

The list of repositories is now ordered using this new metric.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70599] Add new metric Time to review for Open reviews from last uploaded patch

2014-09-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70599

--- Comment #2 from Quim Gil q...@wikimedia.org ---
(In reply to Alvaro from comment #1)
 Metric implemented and added to korma panel:
 
 http://korma.wmflabs.org/browser/gerrit_review_queue.html

Good, thank you! You can remove the line for Most recent updates in Age of
open changesets, since it is not really relevant.


 The list of repositories is now ordered using this new metric.

Maybe this is something temporary, but TorBlock appears as #1 when (according
to the data shown) it shouldn't.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70599] Add new metric Time to review for Open reviews from last uploaded patch

2014-09-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70599

--- Comment #3 from Quim Gil q...@wikimedia.org ---
How complex would it be to compute Date of submission of open changesets by
the date of the last upload, instead of the initial upload? If it's not too
complicated, the data based on last upload would be more useful, because we
could clearly see the old stuff that is there, just rotting.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l