[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|REOPENED

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 165980 had a related patch set uploaded by Florianschmidtwelzow: Revert Show talk button only when JS enabled or talk page not empty

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 165980 merged by jenkins-bot: Revert Show talk button only when JS enabled or talk page not empty https://gerrit.wikimedia.org/r/165980 -- You are receiving

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Florian florian.schmidt.wel...@t-online.de changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #6 from Florian florian.schmidt.wel...@t-online.de --- Hmm, i don't know, if this colidates with bug 67819. But it's more important, that a user can see any talk page, if there is one. -- You are receiving this mail because: You

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 165694 had a related patch set uploaded by Florianschmidtwelzow: Revert partially: Show talk button only when JS enabled or talk page not empty

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 165694 merged by jenkins-bot: Revert partially: Show talk button only when JS enabled or talk page not empty https://gerrit.wikimedia.org/r/165694 -- You are

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Jon jrob...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Florian florian.schmidt.wel...@t-online.de changed: What|Removed |Added See Also|

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Jon jrob...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #10 from Florian florian.schmidt.wel...@t-online.de --- (In reply to Jon from comment #9) on alpha. Because i left the alpha code (see commit message) as an alpha feature, not good? -- You are receiving this mail because: You

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #11 from Jon jrob...@wikimedia.org --- Should remove it. Not sure why it needs to be hidden in alpha. As stated before, that page property value is not always set - especially with Flow pages :) -- You are receiving this mail

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Florian florian.schmidt.wel...@t-online.de changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia.

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #5 from Jon jrob...@wikimedia.org --- Florian personally I'd remove the hidden class in alpha. It seems unnecessary and is wrong anyway ( some articles will have talk pages but no topic page prop value ) -- You are receiving this

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #4 from Jon jrob...@wikimedia.org --- I guess we need to rethink this code. The fix should be in MobileFrontend I'm just not sure how best to do that. -- You are receiving this mail because: You are the assignee for the bug. You

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #2 from Jon jrob...@wikimedia.org --- Weird. It will be something to do with how wfRunHooks( 'SkinMinervaDefaultModules', array( $this, $modules ) ); is run (which Flow uses). Not sure what is happening here. -- You are receiving

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 Florian florian.schmidt.wel...@t-online.de changed: What|Removed |Added CC|

[Bug 71570] Talk icon doesn't show up for pages with Flow boards in alpha

https://bugzilla.wikimedia.org/show_bug.cgi?id=71570 --- Comment #1 from Bingle bingle-ad...@wikimedia.org --- Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/q3UhD8Ur -- You are receiving this mail because: You are the assignee for the bug. You are on