[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 Bryan Davis changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|---

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 --- Comment #11 from Gerrit Notification Bot --- Change 172090 merged by jenkins-bot: hhvm: Detect json-c parser https://gerrit.wikimedia.org/r/172090 -- You are receiving this mail because: You are on the CC list for the bug. __

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 --- Comment #10 from Gerrit Notification Bot --- Change 172090 had a related patch set uploaded by BryanDavis: hhvm: Detect json-c parser https://gerrit.wikimedia.org/r/172090 -- You are receiving this mail because: You are on the CC list fo

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 Gerrit Notification Bot changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 --- Comment #9 from Bryan Davis --- (In reply to Bryan Davis from comment #8) > Ori pointed out that the CMake rules will use a shared libjson-c library if > present and the WMF HHVM build is using that: > > $ ldd /usr/bin/hhvm |grep json >

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 Tim Landscheidt changed: What|Removed |Added Blocks||73175 -- You are receiving this mai

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 --- Comment #8 from Bryan Davis --- Ori pointed out that the CMake rules will use a shared libjson-c library if present and the WMF HHVM build is using that: $ ldd /usr/bin/hhvm |grep json libjson-c.so.2 => /lib/x86_64-linux-gnu/libjso

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 Bryan Davis changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 --- Comment #7 from Bryan Davis --- (In reply to Tim Landscheidt from comment #6) > Interestingly, while this has silenced the Jenkins tests, the change has > introduced failures in the same spots with Travis CI's HHVM: The commit > before pass

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 Tim Landscheidt changed: What|Removed |Added CC||o...@wikimedia.org --- Comment #6 fr

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 Bryan Davis changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|---

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 --- Comment #4 from Gerrit Notification Bot --- Change 170251 merged by jenkins-bot: hhvm: fix FormatJsonTest::testParseTryFixing for lenient json parser https://gerrit.wikimedia.org/r/170251 -- You are receiving this mail because: You are t

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 --- Comment #3 from Gerrit Notification Bot --- Change 170251 had a related patch set uploaded by BryanDavis: hhvm: fix FormatJsonTest::testParseTryFixing for lenient json parser https://gerrit.wikimedia.org/r/170251 -- You are receiving thi

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 --- Comment #2 from Bryan Davis --- Block that ignores trailing commas: $ /usr/bin/php5 -r 'var_dump( json_decode(

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 --- Comment #1 from Bryan Davis --- HHVM has a lenient json parser which allows trailing commas. The failing tests seem to be ones where the test expects json_decode() to fail with JSON_ERROR_SYNTAX and then need to have extra commas stripped.

[Bug 72778] Unit tests in FormatJsonTest fail

https://bugzilla.wikimedia.org/show_bug.cgi?id=72778 Andre Klapper changed: What|Removed |Added Keywords||hhvm Priority|Unprioritized