[Bug 7851] Proper ajax patrolling functionatlity in core

2012-11-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=7851

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

 CC||federicol...@tiscali.it

--- Comment #13 from Nemo federicol...@tiscali.it 2012-11-08 21:53:53 UTC ---
(In reply to comment #12)
 Done in Gerrit change #26440
 
 Waiting for review...

Wonderful! This is something MediaWiki needs so badly, quite unbelievable that
we still don't have it.
Does you patch include both diff and new page patrol? Is the patrol AJAXy
feature displayed in any other place?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 7851] Proper ajax patrolling functionatlity in core

2012-11-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=7851

--- Comment #14 from Marius Hoch h...@online.de 2012-11-08 22:11:14 UTC ---
It indeed includes both new page and diff patrol.

It basically works on top of all old patrol links as it's invoked every time
those are created (happens in includes/Article.php and
includes/diff/DifferenceEngine.php).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 7851] Proper ajax patrolling functionatlity in core

2012-10-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=7851

Hoo man h...@online.de changed:

   What|Removed |Added

   Keywords||patch-in-gerrit
 Status|NEW |ASSIGNED
 CC||h...@online.de
 AssignedTo|wikibugs-l@lists.wikimedia. |h...@online.de
   |org |

--- Comment #12 from Hoo man h...@online.de 2012-10-03 01:47:13 UTC ---
Done in gerrit change 26440

Waiting for review...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 7851] Proper ajax patrolling functionatlity in core

2012-09-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=7851

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||roan.katt...@gmail.com
  Component|History/Diffs   |Patrolling
 AssignedTo|krinklem...@gmail.com   |wikibugs-l@lists.wikimedia.
   ||org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 7851] Proper ajax patrolling functionatlity in core

2011-09-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=7851

mybugs.m...@gmail.com changed:

   What|Removed |Added

 CC||mybugs.m...@gmail.com

--- Comment #11 from mybugs.m...@gmail.com 2011-09-29 21:40:04 UTC ---
(In reply to comment #10)
 So far I haven't found any existing ajax patrol script that does this The
 Right Way, so I'll write it myself.

Any progress on this?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 7851] Proper ajax patrolling functionatlity in core

2011-09-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=7851

mybugs.m...@gmail.com changed:

   What|Removed |Added

   Keywords||javascript

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 7851] Proper ajax patrolling functionatlity in core

2011-03-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=7851

--- Comment #10 from Krinkle krinklem...@gmail.com 2011-03-09 00:48:27 UTC ---
(In reply to comment #9)
 When this script is ready and tested as a gadget I'll most likely add it to
 core as a preference (to acompany preview.js / livepreview).
 
 Why as a preference? As long as it degrades gracefully for text browsers and
 weird people who don't like js, I can't imagine anyone wouldn't want this. We
 don't have a preference for the ajax watch feature (afaik).

Sure, sounds good. But only when it uses the API and has proper
(internationalized) error reporting. Else it would be a regression.

So far I haven't found any existing ajax patrol script that does this The
Right Way, so I'll write it myself.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 7851] Proper ajax patrolling functionatlity in core

2011-02-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=7851

Bawolff bawolff...@gmail.com changed:

   What|Removed |Added

 CC||bawolff...@gmail.com

--- Comment #9 from Bawolff bawolff...@gmail.com 2011-02-25 17:37:10 UTC ---
When this script is ready and tested as a gadget I'll most likely add it to
core as a preference (to acompany preview.js / livepreview).

Why as a preference? As long as it degrades gracefully for text browsers and
weird people who don't like js, I can't imagine anyone wouldn't want this. We
don't have a preference for the ajax watch feature (afaik).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 7851] Proper ajax patrolling functionatlity in core

2011-02-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=7851

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com
Summary|Option not to receive   |Proper ajax patrolling
   |confirmation of marking an  |functionatlity in core
   |article patrolled (or   |
   |Ajax?)  |

--- Comment #8 from Krinkle krinklem...@gmail.com 2011-02-24 12:30:06 UTC ---
(In reply to comment #7)
 I've ported a gadget on the English Wikipedia for new page patrol to a more
 general script that works on any wiki (not just en.wikipedia) and works for
 edit-patrol aswell:
 http://meta.wikimedia.org/wiki/User:Krinkle/Scripts/AjaxPatrolLinks
 Can be put in userscript, gadget or sitewide Commons.js of a wiki.
 Should work on non-WMF wikis aswell.
 
 Could be used as a base if and when this comes to core. It's just a few lines
 of javascript really.
 Could be made even shorter with jQuery (will do that soon).
Done that a few weeks ago.


This script (and many others like it) float around on 100s of wikis. The thing
they have in common is that they turn the index.php call into an ajax request
and if it has code 200 they indicate in the link that it's succeeded.

In the coming weeks I'll work in a script to do this through the api instead.

We can't do an index.php ajax call in the core imho, to save resources (since
calling index.php will return the entire HTML page with all the messages,
preferences etc. on it – all redundant stuff not used and wasting processing
time).

It will also be faster for the client (since index.php takes longer to load and
returns more data) and allows for better error reporting as well (depending on
the status code is not reliable since a 'patrol error page' is (and should be)
also code 200.
Some of the ajax patrol scripts out there look through the returned HTML to see
if it cointains certain words to indicate succesful/error state but this is
both language dependant and prone to breakage whenever those messages are
changed (either by the software or by the local wiki).

When this script is ready and tested as a gadget I'll most likely add it to
core as a preference (to acompany preview.js / livepreview).

--
Krinkle

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l