[Bug 24915] Move CSS signatures from body to html
https://bugzilla.wikimedia.org/show_bug.cgi?id=24915 Daniel Friesen changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #6 from Daniel Friesen 2011-10-26 13:57:54 UTC --- Initial notes: - body.page-* is not unnecessarily specific, it's good practice to restrict signatures to the element signatures are placed on. - Admittedly charsets are not relevant, MediaWiki sanitizes any non-alphanumeric+-_ character in css classes. Specific to this idea of fixed-width centering vector: - Here's a base for fixed-width centering vector https://www.mediawiki.org/wiki/User:Dantman/vector-fixed.css - Have you actually bothered to test out the technique you're describing on vector? The css you specified doesn't work it needs more to actually make vector fixed-width. And when you actually manage to make vector fixed-width you realize that it's messed up: The backgrounds need to expand to the full width of the page, but can't because of the hack added, the lack of a right border on #content looks messed up, but you can't add one the same way vector adds the left one without a second content area inside the content area or using css3 multiple backgrounds that only work in some modern browsers. - What you really want sounds like an enhancement to vector to provide wrapper elements with a class that can be used to make the actual content+ui of vector fixed-width. I don't see a good enough reason to force users to migrate css breaking compatibility or maintain duplicate signatures. Please file the vector enhancements as a separate bug. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24915] Move CSS signatures from body to html
https://bugzilla.wikimedia.org/show_bug.cgi?id=24915
--- Comment #5 from Aryeh Gregor 2010-12-07
18:20:58 UTC ---
(In reply to comment #4)
> Styling html and body is the only way to do things that can be done in
> Monobook
> with #globalWrapper (and Vector does not have a #globalWrapper), such as
> making
> a page narrower:
>
> html {
> background: white; /* needed to prevent body from filling the canvas */
> }
> body {
> background: #f3f3f3;
> margin: 0 auto;
> width: 80%;
> }
True.
> Whether rules apply to or does not make a difference in most
> cases.
It makes a big difference if some rules are applied to both elements, though,
which will be the case if both have the classes during a transition period. So
I don't see any way to switch the classes without a level of disruption that
doesn't seem warranted by the benefits.
> But now I see another problem: Page names can contain non-ASCII
> characters and non-ASCII characters must not occur before the charset has been
> declared. This would mean that the charset must be declared in the HTTP header
> (right now this is not strictly necessary because no non-ASCII characters
> occur
> before the element).
I think MediaWiki is careful to do this anyway, so this might not be a big
deal.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24915] Move CSS signatures from body to html
https://bugzilla.wikimedia.org/show_bug.cgi?id=24915
--- Comment #4 from entli...@gmx-topmail.de 2010-12-07 05:05:14 UTC ---
(In reply to comment #3)
> Typically everything other than is display: none anyway. Do you have
> some specific real-world use-case where you want to style something outside
> the
> ?
Styling html and body is the only way to do things that can be done in Monobook
with #globalWrapper (and Vector does not have a #globalWrapper), such as making
a page narrower:
html {
background: white; /* needed to prevent body from filling the canvas */
}
body {
background: #f3f3f3;
margin: 0 auto;
width: 80%;
}
> If not, I don't see the point in paying the transition cost. Not only
> will people use body.page-Main_page selectors that will no longer work,
> they'll
> also probably do things like .page-Main_page { ... } expecting the rules to
> apply to rather than .
Whether rules apply to or does not make a difference in most
cases. But now I see another problem: Page names can contain non-ASCII
characters and non-ASCII characters must not occur before the charset has been
declared. This would mean that the charset must be declared in the HTTP header
(right now this is not strictly necessary because no non-ASCII characters occur
before the element).
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24915] Move CSS signatures from body to html
https://bugzilla.wikimedia.org/show_bug.cgi?id=24915
Aryeh Gregor changed:
What|Removed |Added
CC||simetrical+wikib...@gmail.c
||om
--- Comment #3 from Aryeh Gregor 2010-12-05
21:07:26 UTC ---
Typically everything other than is display: none anyway. Do you have
some specific real-world use-case where you want to style something outside the
? If not, I don't see the point in paying the transition cost. Not only
will people use body.page-Main_page selectors that will no longer work, they'll
also probably do things like .page-Main_page { ... } expecting the rules to
apply to rather than . If there's no clear real-world
non-theoretical reason for it, I'd say WONTFIX.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24915] Move CSS signatures from body to html
https://bugzilla.wikimedia.org/show_bug.cgi?id=24915 Danny B. changed: What|Removed |Added CC||dann...@email.cz Blocks||12788 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24915] Move CSS signatures from body to html
https://bugzilla.wikimedia.org/show_bug.cgi?id=24915
--- Comment #2 from entli...@gmx-topmail.de 2010-08-25 02:10:25 UTC ---
The main use case of these classes currently is serving as the start of a
descendant selector in order to change things depending on the namespace or
page name or skin (e.g. [[MediaWiki:Monobook.css]], [[MediaWiki:Print.css]]
etc.). For this use case, it doesn't matter if the descendant is a body or a
html or a div or whatever.
A secondary use case is increasing specifity. That is IMHO somewhat
questionable as it mixes unrelated things, but that would still be possible, it
just needs to be written differently (e.g. body.mediawiki becomes
html.mediawiki or .mediawiki body).
Clashes are certainly possible, but when do they occur? Header IDs can clash
with interface IDs just if the header text happens to be the same as an
interface ID, but classes are different; I'm not aware of any place where user
input is translated to a class name. Users could of course hand-craft things to
clash with interface classes, but what's the point in that? Given the (IMHO
unnecessarily specific) rule
body.page-Main_Page h1.firstHeading { display: none !important; }
that could just as well be
.page-Main_page .firstHeading { display: none !important }
they would have to hand-craft two class names just to get something not
displayed. It's much easier to just add style="display: none;" to it.
Adding tag names for the purpose of avoiding clashes also doesn't scale very
well. It incidentally works for body (but also html) because user can't add
body and html tags, but fails with many other tags. On the other hand, omitting
unnecessary tag names is sometimes recommended for performance reasons, see
http://code.google.com/speed/page-speed/docs/rendering.html#UseEfficientCSSSelectors
and https://developer.mozilla.org/en/writing_efficient_css.
The advantage of moving the classes to the root element is that users could,
for example, put stuff with descendant selectors that start with .mediawiki
into the user style sheets of their browsers (e.g. chrome/userContent.css in
the Mozilla profile directory) in order to customize all MediaWiki
installations at once, including the root element. I don't know how many people
are actually doing that, but it's a useful thing to do and already possible,
with the restriction that the root element cannot be styled this way.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24915] Move CSS signatures from body to html
https://bugzilla.wikimedia.org/show_bug.cgi?id=24915 p858snake changed: What|Removed |Added CC||p858sn...@gmail.com Component|General/Unknown |Page rendering -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 24915] Move CSS signatures from body to html
https://bugzilla.wikimedia.org/show_bug.cgi?id=24915 Derk-Jan Hartman changed: What|Removed |Added CC||hart...@videolan.org --- Comment #1 from Derk-Jan Hartman 2010-08-25 00:06:55 UTC --- Well unnecessarily specific is a big word. Don't forget that id's can easily class with other elements, though for classes, it's applies a bit more (unless we are talking about specificity styling, to avoid having to use !important) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
