[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Andre Klapper changed: What|Removed |Added Priority|High|Normal Severity|major

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #57 from Liangent --- (In reply to comment #56) > https://bugzilla.wikimedia.org/show_bug.cgi?id=49440 links to > https://bugzilla.wikimedia.org/attachment.cgi?id=12517 in the first item in > the > "Attachments" table which redirect

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #56 from Andre Klapper --- https://bugzilla.wikimedia.org/show_bug.cgi?id=49440 links to https://bugzilla.wikimedia.org/attachment.cgi?id=12517 in the first item in the "Attachments" table which redirects to http://bug-attachment.wi

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Nemo changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #54 from Helder --- Well, I remember seeing this at least once in the last week. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Bartosz Dziewoński changed: What|Removed |Added Status|REOPENED|UNCONFIRMED Ever confirmed|1

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Nemo changed: What|Removed |Added Status|VERIFIED|REOPENED Resolution|FIXED

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #51 from MZMcBride --- A huge thanks to Daniel, Chris, Brion, and Andre for working on this. I just uploaded attachments to bug 59957 without the uncomfortable feeling that viewing them would be painful and annoying. \o/ -- You ar

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #50 from Daniel Zahn --- and that we have now. https://gerrit.wikimedia.org/r/#/c/106713/ so on 4.4 we'll just merge that and all is good on this bug -- You are receiving this mail because: You are the assignee for the bug. You ar

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #49 from Daniel Zahn --- now we just need a new version of this patch against attachment.cgi from BZ 4.4 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Nemo changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail becaus

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Daniel Zahn changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|---

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #47 from Daniel Zahn --- Created attachment 14280 --> https://bugzilla.wikimedia.org/attachment.cgi?id=14280&action=edit bugzilla logo to test png attachments -- You are receiving this mail because: You are the assignee for the

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #46 from Daniel Zahn --- deployed on kaulen , feel free to test -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #45 from Gerrit Notification Bot --- Change 90546 merged by Dzahn: Work around access restriction for image attachments https://gerrit.wikimedia.org/r/90546 -- You are receiving this mail because: You are the assignee for the bug

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Andre Klapper changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW --- Comment #44 from A

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Bartosz Dziewoński changed: What|Removed |Added CC||rainerril...@hotmail.com --- Comm

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #42 from Bartosz Dziewoński --- *(Also, if that bug is just about the fact that serving user-provided files with user-provided MIME types from the same domain as your normal site is a bad idea, then that's hardly news.) -- You are

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #41 from Bartosz Dziewoński --- Actually, why is bug 51839 still hidden when the immediate issue, whatever it was, was apparently fixed by the workaround being discussed here? (Also, if that bug is just about the fact that serving

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #40 from Andre Klapper --- (In reply to comment #39) > Please add me to bug 51839. I guess the reply needs to be "Please sign an NDA first". :-/ -- You are receiving this mail because: You are the assignee for the bug. You are on

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #39 from MZMcBride --- (In reply to comment #26) > Either fixing bug 51839, or a patch for Bugzilla code which includes > CSteipp's recommendations on https://gerrit.wikimedia.org/r/90546 (could be > tested with IE against links in

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #38 from Nemo --- (In reply to comment #37) > Created attachment 13980 [details] > Special version for bug-attachment.wikimedia.org > > So a slightly hacked version attached. Hurray! I've linked it from [[mw:Bugzilla]]. -- You a

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #37 from Liangent --- Created attachment 13980 --> https://bugzilla.wikimedia.org/attachment.cgi?id=13980&action=edit Special version for bug-attachment.wikimedia.org So a slightly hacked version attached. diff --git a/component

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #36 from Nemo --- There's also https://chrome.google.com/webstore/detail/modify-content-type/jnfofbopfpaoeojgieggflbpcblhfhka for Chrom(e|ium) but that's even too flexible. If someone tests it and finds a good rule for bugzilla, ple

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #35 from Nemo --- (In reply to comment #34) > I can find a few extensions of Firefox to rewrite Content-Disposition > headers. So everyone should install e.g. ? Is

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #34 from Liangent --- (In reply to comment #30) > Is there a workaround for this issue? I can find a few extensions of Firefox to rewrite Content-Disposition headers. -- You are receiving this mail because: You are the assignee f

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #33 from Andre Klapper --- My personal plan is to ignore this report until I've finished stuff that currently has higher priorities for me. I also want to see what upstream does with regard to the underlying issue that led to this s

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #32 from MZMcBride --- What's the plan for this bug? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #31 from Andre Klapper --- No. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #30 from MZMcBride --- Is there a workaround for this issue? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #29 from James Forrester --- (In reply to comment #28) > Only IE 7 and below are affected, if I'm not mistaken; IE 8 and later either > will obey the "don't try to sniff file types" header we send, or don't do the > stupid sniffing

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #28 from Brion Vibber --- Only IE 7 and below are affected, if I'm not mistaken; IE 8 and later either will obey the "don't try to sniff file types" header we send, or don't do the stupid sniffing in the first place. Note that ever

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #27 from MZMcBride --- Chris: in which versions of IE is this an issue? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Andre Klapper changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment #26 from Andre Klapper

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 MZMcBride changed: What|Removed |Added CC||cste...@wikimedia.org --- Comment #25 from

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Helder changed: What|Removed |Added CC||mybugs.m...@gmail.com Web browser|Fire

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #23 from MZMcBride --- What's needed to get this setting put back to the way it was for years? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #22 from Andre Klapper --- (In reply to comment #21) > We should probably send the header that disables IE's mime type sniffing. Since 4.2.4 we send "X-Content-Type-Options: nosniff" with every response. See http://bzr.mozilla.org/

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Andre Klapper changed: What|Removed |Added See Also||https://bugzilla.wikimedia.

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #21 from Brion Vibber --- We should probably send the header that disables IE's mime type sniffing. I really don't care if IE 6 or something remain vulnerable with PNGs, when there's perfectly modern versions available... :) --

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #20 from Andre Klapper --- More complicated due to IE's MIME sniffing, as csteipp pointed out in Gerrit (thanks!): http://msdn.microsoft.com/en-us/library/ms775147.aspx http://www.adambarth.com/papers/2009/barth-caballero-song.pdf

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Gerrit Notification Bot changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #19 from Gerrit Notification Bot --- Change 90546 had a related patch set uploaded by Aklapper: Work around access restriction for image attachments https://gerrit.wikimedia.org/r/90546 -- You are receiving this mail because: You

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #18 from Brion Vibber --- Awesome -- I didn't test it so glad it worked. :DDD -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. __

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #17 from Andre Klapper --- (In reply to comment #15) I was fiddling around in the same code area, but real developers are just faster than me reading my Perl programming book in parallel. Thanks Brian!! I applied your three lines

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #16 from Isarra --- (In reply to comment #5) > RedHat Bugzilla also uses Off, and to my surprise Mozilla Bugzilla uses On. To be perfectly frank, folks in bugzilla generally know how to handle these things anyway, which might expla

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #15 from Brion Vibber --- Maybe after this line: my $disposition = Bugzilla->params->{'allow_attachment_display'} ? 'inline' : 'attachment'; Add something like this? if ($contenttype =~ /^image\/(png|gif|jpeg)$/) { // If

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #14 from Andre Klapper --- (In reply to comment #13) > Any news on this from BZ Adkins? That's me. No news. As ther underlying issue is not a BZ-only problem, somebody should discuss the general way to go in bug 51839. Let me try t

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #13 from Brion Vibber --- Any news on this from BZ Adkins? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l ma

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Alex Monk changed: What|Removed |Added CC||kren...@gmail.com --- Comment #12 from Ale

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Nemo changed: What|Removed |Added CC||federicol...@tiscali.it --- Comment #11 from Ne

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #10 from MZMcBride --- Is there a workaround for this stupidity? It's making Bugzilla attachments painful to view. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 MZMcBride changed: What|Removed |Added CC||b...@mzmcbride.com --- Comment #9 from MZM

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #8 from Isarra --- (In reply to comment #7) > As an alternative, we could patch the attachment shower script to whitelist > image/png, image/jpg, and image/gif for inline viewing. This would resolve > the > vast majority of the inco

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #7 from Brion Vibber --- As an alternative, we could patch the attachment shower script to whitelist image/png, image/jpg, and image/gif for inline viewing. This would resolve the vast majority of the inconvenience. -- You are rec

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Andre Klapper changed: What|Removed |Added Priority|Unprioritized |High -- You are receiving this mail b

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Brion Vibber changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Andre Klapper changed: What|Removed |Added Resolution|FIXED |WONTFIX --- Comment #5 from Andre Klap

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Daniel Zahn changed: What|Removed |Added CC||dz...@wikimedia.org --- Comment #4 from

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 Brion Vibber changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #1 from Brion Vibber --- https://bugzilla.wikimedia.org/attachment.cgi?id=12517&action=edit shows "The attachment is not viewable in your browser due to security restrictions enabled by your Bugzilla administrator. In order to vi

[Bug 54181] PNG attachments to bugzilla download instead of viewing in browser

https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 --- Comment #2 from Brion Vibber --- https://bugzilla.wikimedia.org/editparams.cgi?section=attachment shows that allow_attachment_display is set to "off". Did someone turn it off perhaps by accident? -- You are receiving this mail because: Y