[Bug 5491] Colour-coding of items in page histories
https://bugzilla.wikimedia.org/show_bug.cgi?id=5491 Dan Garry dga...@wikimedia.org changed: What|Removed |Added Status|REOPENED|RESOLVED CC||dga...@wikimedia.org Resolution|--- |WONTFIX --- Comment #12 from Dan Garry dga...@wikimedia.org --- Changing to RESOLVED WONTFIX as this is issue is both stale and also sounds like all it would do is turn the history page into an assault on the senses. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5491] Colour-coding of items in page histories
https://bugzilla.wikimedia.org/show_bug.cgi?id=5491 John Du Hart j...@compwhizii.net changed: What|Removed |Added Attachment #5559|0 |1 is obsolete|| --- Comment #11 from John Du Hart j...@compwhizii.net 2011-09-01 03:15:32 UTC --- Comment on attachment 5559 -- https://bugzilla.wikimedia.org/attachment.cgi?id=5559 Second Revision of the Patch with no colors but borders used Thanks for submitting a patch to MediaWiki. Unfortunately I'm going to have to mark them as obsolete because they no longer merge into our current code. However I would like to touch on two things about the patch: 1. MediaWiki has a strict guideline on how code should be formatted. Mainly, single line if statements are highly discouraged as they aren't very readable. http://www.mediawiki.org/wiki/Manual:Coding_conventions 2. The following code is worrying User::newFromId($revUserId)-getGroups() Although it may not look like much it can possibly add a large amount of Queries to the page. You're loading up a user object which requires a separate database query for each revision. Ouch. If you were to re-implement this today you should look at creating a JOIN in the query to get user groups Thank you very much though for submitting this patch, any bit helps. =) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5491] Colour-coding of items in page histories
https://bugzilla.wikimedia.org/show_bug.cgi?id=5491 John Du Hart j...@compwhizii.net changed: What|Removed |Added Attachment #5560|0 |1 is obsolete|| -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5491] Colour-coding of items in page histories
https://bugzilla.wikimedia.org/show_bug.cgi?id=5491 John Du Hart j...@compwhizii.net changed: What|Removed |Added Keywords|need-review, patch | CC||j...@compwhizii.net -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5491] Colour-coding of items in page histories
https://bugzilla.wikimedia.org/show_bug.cgi?id=5491 --- Comment #10 from Liquid_2003 liquid.2...@gmail.com 2009-01-06 11:22:47 UTC --- (In reply to comment #9) The color solution and the border solution do not work as they should. A solution with dedicated icons runs into the problem that skin developers would have to do new icons for this. Could any skin developer please comment on this? If not, I guess it would be better to close this bug. There is a feature created by some wikipedians that I've added to my Monobook here : http://fr.wikipedia.org/wiki/Utilisateur:Liquid_2003/monobook.css A few days ago, there was icons too, from the Crystal Clear pack. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5491] Colour-coding of items in page histories
https://bugzilla.wikimedia.org/show_bug.cgi?id=5491 --- Comment #9 from Johan Uhle johan.u...@student.hpi.uni-potsdam.de 2009-01-05 15:51:13 UTC --- The color solution and the border solution do not work as they should. A solution with dedicated icons runs into the problem that skin developers would have to do new icons for this. Could any skin developer please comment on this? If not, I guess it would be better to close this bug. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5491] Colour-coding of items in page histories
https://bugzilla.wikimedia.org/show_bug.cgi?id=5491 Johan Uhle [EMAIL PROTECTED] changed: What|Removed |Added Attachment #5549 is|0 |1 obsolete|| --- Comment #8 from Johan Uhle [EMAIL PROTECTED] 2008-12-04 17:29:53 UTC --- Created an attachment (id=5560) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=5560) Picture of how it looks with borders -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5491] Colour-coding of items in page histories
https://bugzilla.wikimedia.org/show_bug.cgi?id=5491 Johan Uhle [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] ||potsdam.de --- Comment #1 from Johan Uhle [EMAIL PROTECTED] 2008-12-01 18:35:57 UTC --- Created an attachment (id=5548) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=5548) First Try On Adding This Feature -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5491] Colour-coding of items in page histories
https://bugzilla.wikimedia.org/show_bug.cgi?id=5491 --- Comment #2 from Johan Uhle [EMAIL PROTECTED] 2008-12-01 18:37:00 UTC --- Created an attachment (id=5549) -- (https://bugzilla.wikimedia.org/attachment.cgi?id=5549) Picture on how this looks -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5491] Colour-coding of items in page histories
https://bugzilla.wikimedia.org/show_bug.cgi?id=5491 Johan Uhle [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||WORKSFORME --- Comment #3 from Johan Uhle [EMAIL PROTECTED] 2008-12-01 18:37:34 UTC --- Hi There, this looks like a nice enhancement to me, improving overview in history view, so I made a patch for this. It changes the backgroundcolor of the line, according to the user who made the revision: Not logged in User - White Some logged in User - Yellow Currently logged in User - Green Sysop - Pink Of course, it uses CSS. Changes have been made to shared.css, so skins can override this. I tested it with various skins and it works fine. Image of the looks attached. Feedback appreciated. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5491] Colour-coding of items in page histories
https://bugzilla.wikimedia.org/show_bug.cgi?id=5491 Aaron Schulz [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Status|RESOLVED|REOPENED Resolution|WORKSFORME | --- Comment #4 from Aaron Schulz [EMAIL PROTECTED] 2008-12-01 18:39:56 UTC --- Re-opening. WFM is for closing bugs about errors that no one can re-produce/don't seem to exist. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 5491] Colour-coding of items in page histories
https://bugzilla.wikimedia.org/show_bug.cgi?id=5491 Johan Uhle [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] ||potsdam.de --- Comment #6 from Johan Uhle [EMAIL PROTECTED] 2008-12-01 21:30:22 UTC --- @#5 I orientated the default colors to the default colors in /skins/common/diff.css. I thought, If they have default colors their, why shouldn't I use them, too? Furthermore, can't the skin designers just override my colors with their own if they want to? I do totally agree with your critisicm about the bad color combination. I may think of a different color combinations, after we have clarified the default colors-issue. Futhermore, there is the question of how to document this color scheme to the user on the history page. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
