https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
Gabriel Wicke changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
--- Comment #12 from Gerrit Notification Bot ---
Change 106429 merged by jenkins-bot:
Move .data off DOM nodes
https://gerrit.wikimedia.org/r/106429
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
Gerrit Notification Bot changed:
What|Removed |Added
Status|NEW |PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
--- Comment #11 from Gerrit Notification Bot ---
Change 106429 had a related patch set uploaded by Arlolra:
WIP: Move .data off DOM nodes
https://gerrit.wikimedia.org/r/106429
--
You are receiving this mail because:
You are on the CC list fo
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
Arlo Breault changed:
What|Removed |Added
Assignee|gwi...@wikimedia.org|abrea...@wikimedia.org
--
You are rece
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
--- Comment #10 from Gabriel Wicke ---
We discussed this more on IRC and figured that we could avoid giving DU
internal state by attaching extra info to the document object in the longer
term and to each node in the shorter term. That would lea
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
--- Comment #9 from Gabriel Wicke ---
I'm not a fan of giving DU internal state, so IMO it might make more sense to
use either
DU.data(node, env)
or env.getNodeData(node)
I'd suggest both should return a reference to the actual object, which
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
--- Comment #8 from Inez Korczyński ---
(In reply to comment #7)
> I suggest we first do a refactor to use uniformly use:
> DU.data(node)
> for getters, and maybe
> DU.data(node, new_data)
> for setters?
>
> Then we can easily experiment w
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
C. Scott Ananian changed:
What|Removed |Added
CC||canan...@wikimedia.org
--- Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
Gabriel Wicke changed:
What|Removed |Added
CC||abrea...@wikimedia.org
--- Comment #6
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
--- Comment #5 from Gabriel Wicke ---
I see two options here:
1) Rename data to some other non-conflicting 'expando' property.
Example: .dataobject to rhyme with .dataset
This is used by jquery et al to store a string key for $.data.
2) Mo
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
--- Comment #4 from Inez Korczyński ---
(In reply to comment #3)
> This is indeed correct for object elements according to
> http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-
> element.html#the-object-element
Gabriel: Do
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
--- Comment #3 from Gabriel Wicke ---
This is indeed correct for object elements according to
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#the-object-element
--
You are receiving this mail because:
You a
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
--- Comment #2 from Inez Korczyński ---
(In reply to comment #1)
> This seems to be a bug in domino. It should not confuse the data attribute
> with
> the .data node object member.
I don't think it's a domino (or domino only) problem, try in a
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
--- Comment #1 from Gabriel Wicke ---
This seems to be a bug in domino. It should not confuse the data attribute with
the .data node object member.
--
You are receiving this mail because:
You are on the CC list for the bug.
__
https://bugzilla.wikimedia.org/show_bug.cgi?id=57394
Gabriel Wicke changed:
What|Removed |Added
Priority|Unprioritized |Normal
--
You are receiving this mail
16 matches
Mail list logo
