[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 --- Comment #27 from Krinkle --- (In reply to Bawolff (Brian Wolff) from comment #26) > (In reply to Bawolff (Brian Wolff) from comment #25) > > Re-opening. I just managed to submit a patch ( > > https://gerrit.wikimedia.org/r/#/c/147754/ ) with a rather stupid json > > error, and jenkins did not complain. > > Its been pointed out to me that the jslint job (which is non-voting on > TimedMediaHandler) is what verifies json files (Although > https://integration.wikimedia.org/ci/job/mwext-TimedMediaHandler-jslint/497/ > consoleText doesn't seem to say anything about an i18n file failing). I'd > like to suggest that the job be split. As missing a coding convention and a > fatal error are rather different types of issues. I agree it shouldn't be part of the jslint job. But I don't think we should change that for the time being. The jslint job in general is an older one that is being phased out by having projects adopt Grunt instead. Where they can add jshint, jscs, banana-checker, and (if they have non-i18n json files) json-lint to their pipeline. TMH repo should be updated by adding the appropriate jshint config and ignores so that their non-voting exemption may be lifted. Because right now, obvious syntax errors in javascript files aren't caught, either. Which is just as important as json syntax errors. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 --- Comment #26 from Bawolff (Brian Wolff) --- (In reply to Bawolff (Brian Wolff) from comment #25) > Re-opening. I just managed to submit a patch ( > https://gerrit.wikimedia.org/r/#/c/147754/ ) with a rather stupid json > error, and jenkins did not complain. Its been pointed out to me that the jslint job (which is non-voting on TimedMediaHandler) is what verifies json files (Although https://integration.wikimedia.org/ci/job/mwext-TimedMediaHandler-jslint/497/consoleText doesn't seem to say anything about an i18n file failing). I'd like to suggest that the job be split. As missing a coding convention and a fatal error are rather different types of issues. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 Bawolff (Brian Wolff) changed: What|Removed |Added Status|RESOLVED|REOPENED CC||bawolff...@gmail.com Resolution|FIXED |--- --- Comment #25 from Bawolff (Brian Wolff) --- Re-opening. I just managed to submit a patch ( https://gerrit.wikimedia.org/r/#/c/147754/ ) with a rather stupid json error, and jenkins did not complain. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 Bug 58279 depends on bug 62490, which changed state. Bug 62490 Summary: Deploy repo has two invalid json files https://bugzilla.wikimedia.org/show_bug.cgi?id=62490 What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 Antoine "hashar" Musso changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #24 from Antoine "hashar" Musso --- All 275 jobs updated. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 --- Comment #23 from Gerrit Notification Bot --- Change 113958 merged by jenkins-bot: Add json-lint.php command to -jslint jobs https://gerrit.wikimedia.org/r/113958 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 --- Comment #22 from Antoine "hashar" Musso --- I forgot to deploy https://gerrit.wikimedia.org/r/#/c/113958/ last monday. Updating jobs now. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 Nemo changed: What|Removed |Added Priority|Low |Normal Severity|normal |major --- Comment #21 from Nemo --- (In reply to Nemo from comment #19) > > Will be done next Monday: March 17th. > > Was it? Seems not. Setting severity from Siebrand's duplicate. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 --- Comment #20 from Antoine "hashar" Musso --- *** Bug 63293 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 Nemo changed: What|Removed |Added CC||federicol...@tiscali.it --- Comment #19 from Nemo --- (In reply to Antoine "hashar" Musso from comment #18) > Mailled wikitech-l about it > http://lists.wikimedia.org/pipermail/wikitech-l/2014-March/075092.html > > Will be done next Monday: March 17th. Was it? Another example: https://gerrit.wikimedia.org/r/#/c/121910/ All extensions should have JSON files checked for validity (locally I use a simple json_verify < $FILE.json ). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 Antoine "hashar" Musso changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment #18 from Antoine "hashar" Musso --- Mailled wikitech-l about it http://lists.wikimedia.org/pipermail/wikitech-l/2014-March/075092.html Will be done next Monday: March 17th. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 Antoine "hashar" Musso changed: What|Removed |Added Depends on||62490 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 Bug 58279 depends on bug 61659, which changed state. Bug 61659 Summary: VisualEditor: modules/syntaxhighlight/rules/mysql.json has unescaped double quotes in a double quoted string https://bugzilla.wikimedia.org/show_bug.cgi?id=61659 What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 --- Comment #17 from Gerrit Notification Bot --- Change 114464 merged by jenkins-bot: json syntax error with escaped single quotes https://gerrit.wikimedia.org/r/114464 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 --- Comment #16 from Gerrit Notification Bot --- Change 114464 had a related patch set uploaded by Hashar: json syntax error with escaped single quotes https://gerrit.wikimedia.org/r/114464 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 Antoine "hashar" Musso changed: What|Removed |Added Depends on||61659 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 Antoine "hashar" Musso changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment #15 from Antoine "hashar" Musso --- I have run the json linter on all extensions and three files are not understood by PHP json_decode() :-( hashar@gallium:~/extensions$ /srv/deployment/integration/slave-scripts/bin/json-lint.php . ./TemplateData/spec.templatedata.json: json decode error. ./VisualEditor/modules/ve-mw/i18n/qqq.json: json decode error. ./VisualEditor/modules/syntaxhighlight/rules/mysql.json: json decode error. hashar@gallium:~/extensions$ -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 --- Comment #14 from Gerrit Notification Bot --- Change 113958 had a related patch set uploaded by Hashar: Add json-lint.php command to -jslint jobs https://gerrit.wikimedia.org/r/113958 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 --- Comment #13 from Gerrit Notification Bot --- Change 107163 merged by jenkins-bot: json-lint.php: recursively lint json files with PHP https://gerrit.wikimedia.org/r/107163 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 Antoine "hashar" Musso changed: What|Removed |Added Priority|Unprioritized |Low -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 --- Comment #12 from Antoine "hashar" Musso --- (In reply to comment #11) > Have you verified that it warns for double quotes in *.json files as well? Yes I did (comment #4) which prompted me to repurpose this bug in writing a wrapper around PHP json_decode() which I did in Gerrit change #107163. I guess jshint would have the same issue with trailing comma in arrays (none in json) or keys having to be enclosed by quotes. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58279] Jenkins: Add a lint job for JSON
https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 Krinkle changed: What|Removed |Added Summary|Add a JSON linter to CI |Jenkins: Add a lint job for ||JSON -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
