[Bug 59126] Remove version check for mysql 4.1 from initEditCount.php and storage/fixBug20757.php

2014-01-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=59126 --- Comment #7 from db duplicate...@googlemail.com --- For the first point: Yes, and a 'OR FALSE' is a no-operation, so you can remove that (The condition before was also a no-operation, because it always evaluated to false). For the second

[Bug 59126] Remove version check for mysql 4.1 from initEditCount.php and storage/fixBug20757.php

2014-01-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=59126 --- Comment #5 from db duplicate...@googlemail.com --- Bad fix in my opinion. You have only removed one part of a AND condition, that means the condition itself was changed and not only dead code path removed. For initEditCount.php: You have

[Bug 59126] Remove version check for mysql 4.1 from initEditCount.php and storage/fixBug20757.php

2014-01-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=59126 --- Comment #6 from Tony Thomas 01tonytho...@gmail.com --- (In reply to comment #5) Bad fix in my opinion. You have only removed one part of a AND condition, that means the condition itself was changed and not only dead code path removed.

[Bug 59126] Remove version check for mysql 4.1 from initEditCount.php and storage/fixBug20757.php

2013-12-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=59126 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW

[Bug 59126] Remove version check for mysql 4.1 from initEditCount.php and storage/fixBug20757.php

2013-12-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=59126 --- Comment #1 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 104713 had a related patch set uploaded by 01tonythomas: Remove version check for mysql 4.1 from Maintenance scripts https://gerrit.wikimedia.org/r/104713 --

[Bug 59126] Remove version check for mysql 4.1 from initEditCount.php and storage/fixBug20757.php

2013-12-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=59126 p858snake p858sn...@gmail.com changed: What|Removed |Added CC||p858sn...@gmail.com

[Bug 59126] Remove version check for mysql 4.1 from initEditCount.php and storage/fixBug20757.php

2013-12-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=59126 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 104713 merged by jenkins-bot: Remove version check for mysql 4.1 from Maintenance scripts https://gerrit.wikimedia.org/r/104713 -- You are receiving this mail

[Bug 59126] Remove version check for mysql 4.1 from initEditCount.php and storage/fixBug20757.php

2013-12-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=59126 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED

[Bug 59126] Remove version check for mysql 4.1 from initEditCount.php and storage/fixBug20757.php

2013-12-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=59126 --- Comment #4 from Tony Thomas 01tonytho...@gmail.com --- (In reply to comment #2) We could probably just delete fixbug20757 most likely. Is that necessary ? If you want, lets file a separate bug for that. -- You are receiving this mail

[Bug 59126] Remove version check for mysql 4.1 from initEditCount.php and storage/fixBug20757.php

2013-12-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=59126 Sam Reed (reedy) s...@reedyboy.net changed: What|Removed |Added Keywords||easy

[Bug 59126] Remove version check for mysql 4.1 from initEditCount.php and storage/fixBug20757.php

2013-12-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=59126 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added CC|