[Bug 59808] Scribunto pulls in entire jQuery UI library for error reporting
https://bugzilla.wikimedia.org/show_bug.cgi?id=59808 Brad Jorsch bjor...@wikimedia.org changed: What|Removed |Added Priority|Normal |Low --- Comment #3 from Brad Jorsch bjor...@wikimedia.org --- What's the point of having jQuery if we're not supposed to use it? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59808] Scribunto pulls in entire jQuery UI library for error reporting
https://bugzilla.wikimedia.org/show_bug.cgi?id=59808 --- Comment #4 from Ryan Kaldari rkald...@wikimedia.org --- For desktop, jQuery UI is fine (at least until OO.js is more widely adopted). The only problem is that mobile doesn't want to load jQuery UI unless absolutely necessary, and Scribunto is used on both desktop and mobile. There are two possible short-term solutions: * Make jquery.ui and jquery.ui.dialog loadable on mobile by giving them the 'mobile' target in the module definition (and make sure they are only loaded when there is an error) * Remove the dialog code from Scribunto and just use a JS alert in the meantime. Alerts are pretty unfriendly (since they take over the browser, stop JS execution, etc.), but since it's such a limited use, it might be OK for a short-term fix. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59808] Scribunto pulls in entire jQuery UI library for error reporting
https://bugzilla.wikimedia.org/show_bug.cgi?id=59808 --- Comment #5 from Jon jrob...@wikimedia.org --- jQuery UI != jQuery Use jQuery by all means of a jQuery plugin for this - you do not need a huge library the size of jQuery UI. jQuery UI is totally unsuitable for mobile. Please do not load it to simply use I'd guess about 2% of the library.. As stated the correct thing to do would be to start using OO.js which is in core. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59808] Scribunto pulls in entire jQuery UI library for error reporting
https://bugzilla.wikimedia.org/show_bug.cgi?id=59808 --- Comment #6 from Jon jrob...@wikimedia.org --- In case I was clear please do not follow Ryan's suggestion of Make jquery.ui and jquery.ui.dialog loadable on mobile by giving them the 'mobile' target in the module definition (and make sure they are only loaded when there is an error) An alert would make more sense, using jQuery UI is overkill for this use case imo. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59808] Scribunto pulls in entire jQuery UI library for error reporting
https://bugzilla.wikimedia.org/show_bug.cgi?id=59808 --- Comment #7 from Brad Jorsch bjor...@wikimedia.org --- (In reply to comment #4) * Remove the dialog code from Scribunto and just use a JS alert in the meantime. Alerts are pretty unfriendly (since they take over the browser, stop JS execution, etc.), but since it's such a limited use, it might be OK for a short-term fix. I believe some browsers are starting to block alters entirely. (In reply to comment #5) As stated the correct thing to do would be to start using OO.js which is in core. Patches welcome. Or even links to examples. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59808] Scribunto pulls in entire jQuery UI library for error reporting
https://bugzilla.wikimedia.org/show_bug.cgi?id=59808 --- Comment #8 from Ryan Kaldari rkald...@wikimedia.org --- OOjs is in core, but if you want to make dialogs, you probably need OOjs UI as well, which is still only in VisualEditor. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59808] Scribunto pulls in entire jQuery UI library for error reporting
https://bugzilla.wikimedia.org/show_bug.cgi?id=59808
--- Comment #9 from Tim Starling tstarl...@wikimedia.org ---
One problem with alert() is that it's not HTML, so you couldn't click on the
source file links which appear in the Scribunto backtraces.
(In reply to comment #1)
Okay this doesn't look so bad now as it seems to only become a problem when a
ScribuntoError occurs (I'm not sure how often this occurs on wiki's - I've
only managed to replicate this locally).
You can replicate it on the pages in this category:
https://en.wikipedia.org/wiki/Category:Pages_with_script_errors
It looks like there are currently no such pages in the main namespace, so the
impact of this bug on readers of en.m.wikipedia.org is negligible.
There's a bug in Scribunto which causes jquery.ui.dialog and the hidden
category to be added even if no errors are emitted into the final HTML, say due
to the error being sent to the condition of a {{#iferror:}}. At one point,
there were tens of thousands of pages in [[Category:Pages with script errors]]
for no obvious reason, possibly due to that bug. So, it would have affected
mobile readers at that time. That could be reported separately if it's not
already.
However it seems bizarre to me that the
entire jQuery UI library would be loaded simply for error reporting...
I think error reporting is the most important feature in Scribunto, it's
central to the usability of Lua scripting. So I don't think it's bizarre that
it loads libraries. It's just somewhat inefficient.
I would be fine with a lightweight DIY thing, or with dynamic loading of
jquery.ui.dialog on click of the error message, with a spinner.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59808] Scribunto pulls in entire jQuery UI library for error reporting
https://bugzilla.wikimedia.org/show_bug.cgi?id=59808 Derk-Jan Hartman hartman.w...@gmail.com changed: What|Removed |Added CC||hartman.w...@gmail.com --- Comment #10 from Derk-Jan Hartman hartman.w...@gmail.com --- let's just dynamically load it, it's simple and not too many 'normal' users are using it anyways. When OOjs is more mature, we can just switch it over. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59808] Scribunto pulls in entire jQuery UI library for error reporting
https://bugzilla.wikimedia.org/show_bug.cgi?id=59808 This, that and the other at.li...@live.com.au changed: What|Removed |Added CC||at.li...@live.com.au --- Comment #2 from This, that and the other at.li...@live.com.au --- Realistically, Scribunto does not require the full jQuery UI. I feel that it should roll its own script error popup, since jQuery UI Dialogs were not really designed for this use. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59808] Scribunto pulls in entire jQuery UI library for error reporting
https://bugzilla.wikimedia.org/show_bug.cgi?id=59808 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Keywords||performance Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 59808] Scribunto pulls in entire jQuery UI library for error reporting
https://bugzilla.wikimedia.org/show_bug.cgi?id=59808 Jon jrob...@wikimedia.org changed: What|Removed |Added Summary|Uncaught Error: Unknown |Scribunto pulls in entire |dependency: ext.scribunto |jQuery UI library for error ||reporting --- Comment #1 from Jon jrob...@wikimedia.org --- Okay this doesn't look so bad now as it seems to only become a problem when a ScribuntoError occurs (I'm not sure how often this occurs on wiki's - I've only managed to replicate this locally). However it seems bizarre to me that the entire jQuery UI library would be loaded simply for error reporting... -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
