[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 --- Comment #10 from ryasm...@wikimedia.org --- Verified the fix in production:https://en.wikipedia.org/w/index.php?title=User:RYasmeen_%28WMF%29/sandboxveaction=edit -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 --- Comment #9 from ryasm...@wikimedia.org --- Verified the fix in test2 environment. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 115939 merged by jenkins-bot: Deal with 'none'/'border' and default size in media edit https://gerrit.wikimedia.org/r/115939 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED Target Milestone|--- |VE-deploy-2014-03-06 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 115939 had a related patch set uploaded by Mooeypoo: [wip] Deal with 'none'/'border' and default size in media edit https://gerrit.wikimedia.org/r/115939 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Assignee|mor...@gmail.com|jforrester+veteambztickets@ ||wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Assignee|jforrester+veteambztickets@ |mor...@gmail.com |wikimedia.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 WhatamIdoing wmf.whatamido...@yahoo.com changed: What|Removed |Added CC||wmf.whatamido...@yahoo.com --- Comment #5 from WhatamIdoing wmf.whatamido...@yahoo.com --- What about making any 0 immediately become the wiki's default size? Right now, there's no way to remove a size and return to unspecified default (see bug 50379). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 --- Comment #6 from Moriel Schottlender mor...@gmail.com --- I'm working on trying to get default size to work. There are several technical problems I am trying to sort through now, but once those are solved, we'll be able to have more options with default size, like a 'default' button and reverting to default on 0 value. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 --- Comment #2 from Moriel Schottlender mor...@gmail.com --- Cannot replicate in master. Changing the size in either width or height (by deleting or changing the first digit or typing from scratch) changes the corresponding input. Example: - Inserted an image with initial size 182x150 - Media settings - Advanced settings, deleted '1' to result in width: 82 - Result: Height adjusted to 68 (Expected) - Marked the first digit in Width (8) and changed to 9 - Result: Height adjusted to 76 This works for me in both Chrome and Firefox. Am I missing any details to replicate? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 --- Comment #3 from James Forrester jforres...@wikimedia.org --- If the size is 400 and you delete the first character (4), it becomes 00, which instantly becomes 0. Undoing this restores the 4… so it becomes 40 (and there's nothing left on the browser undo stack). Maybe if you change the value such that it doesn't make sense, rather than cleaning up 00 or 0 and then complaining, we should just blank the field? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal Status|NEW |ASSIGNED Severity|normal |minor -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 --- Comment #4 from Moriel Schottlender mor...@gmail.com --- The problem is that the size widget constantly adjusts both values numerically, so value 00 in the width is read as the number '0', which actively changes the value in the height input (to 0). Now, since a change occurred in height, that triggers an automatic change to width, which brings it down to the number 0. We can fix this by not triggering the adjustment on keypress but rather when you leave the input (so, onChange event) but that has several other issues it may raise. For instance, what happens if I changed a width without moving away from the input (technically no 'change' input event) and then clicked the Apply button? The corresponding dimension didn't get updated, and while the 'change' event will trigger when I click the button (because the input loses focus) it will be too late to notify the user of a changed dimension. I am not sure how this can be fixed without removing the functionality of updating both dimensions simultaneously. We should discuss this further. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61059] VisualEditor: Deleting the first digit of the size in Media Settings removes the entire value in the both fields
https://bugzilla.wikimedia.org/show_bug.cgi?id=61059 ryasm...@wikimedia.org changed: What|Removed |Added Summary|VisualEditor: Deleting the |VisualEditor: Deleting the |first digit of the size in |first digit of the size in |Media Settings removes the |Media Settings removes the |entire value in the both|entire value in the both |field |fields -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
