[Bug 61577] OutputPage::addModuleStyles should support module dependencies
https://bugzilla.wikimedia.org/show_bug.cgi?id=61577
--- Comment #5 from Matthew Flaschen ---
(In reply to Isarra from comment #3)
> Skins need to be able to specify module dependencies. Otherwise the only way
> to make more specific skin styles (such as for a specific page) load after
> the main styles is to name them such that they come later in alphabetical
> order.
This only addresses one your scenarios. However, for this issue (targeting a
specific page), you can use CSS specificity, in which case the order won't
matter (order only applies if they have the same specificity).
First, you need a class. MediaWiki provides these based on page titles (e.g.
page-Main_Page). That probably doesn't work for this use case, though.
Instead, you can use Skin->addToBodyAttributes and
$out->getTitle()->isMainPage() to set a class for the main page (or maybe MW
core should do this; MW.org already uses something similar at
https://www.mediawiki.org/wiki/MediaWiki:Gadget-site.js).
Then, you can do something like:
.mw-bluesky-mainpage {
// Custom main page styling
}
in LESS.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61577] OutputPage::addModuleStyles should support module dependencies
https://bugzilla.wikimedia.org/show_bug.cgi?id=61577 Jack Phoenix changed: What|Removed |Added CC||j...@countervandalism.net --- Comment #4 from Jack Phoenix --- (In reply to Isarra from comment #3) > This is unintuitive and stupid, as it results in poorly named modules > and an unclear hierarchy, and also comes with no assurance that the load > order will not break down the road. Forwards-compatibility -- or documentation for that matter -- has never been MediaWiki's strongest suit. You can live with it when you have only one site to fix after upgrading, but when you have tens or hundreds of sites to fix, it gets kinda old really fast. > You can see this, for instance, in the > bluesky skin, which has special mainpage formatting; the theme extension, > which applies theme css on top of the skin css; Theme used previously (MW 1.22 and older versions) the naming schema skins.skinname.themename, i.e. skins.monobook.dark for a Dark MonoBook theme. This worked fine, because in 1.22 MonoBook's main.css etc. was loaded by a module called "skins.monobook". Come 1.23, the skins.monobook module was renamed skins.monobook.styles and because the letter d (as in the word "dark") sorts alphabetically before the letter s (as in "styles"), the skin defaults ended up overriding the theme-defined rules, and the end result was a horribly butchered MonoBook on the sites, unhappy users and unhappy developers. Nobody saw this coming, given that the Theme extension worked consistently from MediaWiki 1.16 to 1.22. This particular issue was "fixed" by prefixing Theme's modules with themeloader., since t sorts alphabetically after s, but if history's anything to go by, it'll only be so long until it breaks again. > wikihow's custom styling of the mobilefrontend extension wikiHow essentially had the same issue with their MobileFrontend customizations (/extensions/wikihow/MobileFrontendWikihow) as ShoutWiki had with the Theme extension, and the solution was, obviously, similar: certain modules were prefixed with zzz. to ensure the correct loading order. Hardly the ideal solution, but for the time being, it works. It's not intuitive, obvious or otherwise ideal in any case. > These are all stacks of cards just waiting to topple. "to topple *again*", you mean. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61577] OutputPage::addModuleStyles should support module dependencies
https://bugzilla.wikimedia.org/show_bug.cgi?id=61577 Isarra changed: What|Removed |Added CC||zhoris...@gmail.com --- Comment #3 from Isarra --- Skins need to be able to specify module dependencies. Otherwise the only way to make more specific skin styles (such as for a specific page) load after the main styles is to name them such that they come later in alphabetical order. This is unintuitive and stupid, as it results in poorly named modules and an unclear hierarchy, and also comes with no assurance that the load order will not break down the road. You can see this, for instance, in the bluesky skin, which has special mainpage formatting; the theme extension, which applies theme css on top of the skin css; and also, from what I understand, wikihow's custom styling of the mobilefrontend extension. These are all stacks of cards just waiting to topple. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61577] OutputPage::addModuleStyles should support module dependencies
https://bugzilla.wikimedia.org/show_bug.cgi?id=61577 Bartosz Dziewoński changed: What|Removed |Added CC||roan.katt...@gmail.com, ||tpars...@wikimedia.org Component|Skin and page rendering |ResourceLoader -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61577] OutputPage::addModuleStyles should support module dependencies
https://bugzilla.wikimedia.org/show_bug.cgi?id=61577 Bartosz Dziewoński changed: What|Removed |Added Blocks||66508 Depends on|66508 | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61577] OutputPage::addModuleStyles should support module dependencies
https://bugzilla.wikimedia.org/show_bug.cgi?id=61577 Bartosz Dziewoński changed: What|Removed |Added Depends on||66508 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61577] OutputPage::addModuleStyles should support module dependencies
https://bugzilla.wikimedia.org/show_bug.cgi?id=61577 --- Comment #2 from Bartosz Dziewoński --- It seems to be that even a very rudimentary broken-by-design dependencies support in addModuleStyles() would be a better fix for bug 45229 than preserving the call order (or no fix at all). Situations like you describe in point 2) can be easily handled by duplicating the module under a new name until cached page HTML expires. This of course sucks a lot, but *we already do this all the time* to make incompatible changes in HTML. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61577] OutputPage::addModuleStyles should support module dependencies
https://bugzilla.wikimedia.org/show_bug.cgi?id=61577 Bartosz Dziewoński changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=45229 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61577] OutputPage::addModuleStyles should support module dependencies
https://bugzilla.wikimedia.org/show_bug.cgi?id=61577 Daniel Friesen changed: What|Removed |Added CC||mediawiki-bugs@nadir-seen-f ||ire.com --- Comment #1 from Daniel Friesen --- I've got two problems with these assertions. Firstly, on (2b) the skin stack is already under this situation. If we change basically anything like css selectors, module names, or add a new module to addModuleStyles we'll have to leave things duplicated on WMF for 30 days for the caches to expire. So supporting dependencies and replacing addModuleStyles with a key to tell addModules that a hardcoded should be used instead just leaves us in the same situation, it doesn't make anything worse. Secondly, on (2a) our current assertion seems to be that we always want to serve up to date CSS. But given all the trouble we have with changing selectors, renaming modules, etc... it seems that that perception is incorrect, and the reality is that we DON'T want up to date css, if a cached page with old HTML is being served then we actually want to serve it old CSS. That would mean we DO want &version= in the HTML and we want a ResourceLoader snapshot system that will allow WMF to snapshot the current state of RL modules before a scap and have that served to cached pages with old HTML after the new code is pushed out. That would mean server side dependencies wouldn't be a problem, nor would we need selector, css, or module duplication when we change things. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61577] OutputPage::addModuleStyles should support module dependencies
https://bugzilla.wikimedia.org/show_bug.cgi?id=61577 Matthew Flaschen changed: What|Removed |Added CC||mflasc...@wikimedia.org See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=29693 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61577] OutputPage::addModuleStyles should support module dependencies
https://bugzilla.wikimedia.org/show_bug.cgi?id=61577 Krinkle changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
