[Bug 61992] Vertical buttons instead of horizontal

2014-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61992

--- Comment #10 from Lokal_Profil  ---
(In reply to Matthew Flaschen from comment #9)
> (In reply to Lokal_Profil from comment #7)
> > Seems like it is a clash between the code for moving categories to the top
> > of the page in my common.js (same as that in the Commons gadget
> > https://commons.wikimedia.org/wiki/MediaWiki:Gadget-CategoryAboveAll.js)
> > which doesn't affect those skins anyhow.
> 
> The reason it doesn't affect those skins is that bodyContent doesn't exist
> there.  However, the script throws an error rather than correctly handling
> the absence.  See
> https://commons.wikimedia.org/wiki/MediaWiki_talk:Gadget-CategoryAboveAll.js

Thanks. So unrelated issue which prevented gettingStarted from showing. Updated
the commons gadget, unsure if the same also exists on other projects.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61992] Vertical buttons instead of horizontal

2014-03-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61992

--- Comment #9 from Matthew Flaschen  ---
(In reply to Lokal_Profil from comment #7)
> Seems like it is a clash between the code for moving categories to the top
> of the page in my common.js (same as that in the Commons gadget
> https://commons.wikimedia.org/wiki/MediaWiki:Gadget-CategoryAboveAll.js)
> which doesn't affect those skins anyhow.

The reason it doesn't affect those skins is that bodyContent doesn't exist
there.  However, the script throws an error rather than correctly handling the
absence.  See
https://commons.wikimedia.org/wiki/MediaWiki_talk:Gadget-CategoryAboveAll.js

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61992] Vertical buttons instead of horizontal

2014-03-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61992

--- Comment #8 from Steven Walling  ---
(In reply to Matthew Flaschen from comment #6)
> (In reply to Lokal_Profil from comment #1)
> > Just tested the above in different skins:
> > * Vector: I get the above result
> > * Monobok: I get the correct result (see attachment)
> > * Modern: I get nothing
> > * Cologne: I get nothing
> 
> What do you mean, "I get nothing".  I see:
> 
> Modern
> (https://sv.wikipedia.org/wiki/
> Myinodes_interpunctaria?gettingStartedReturn=true&useskin=modern) - Buttons
> side by side.
> 
> ColoneBlue
> (https://sv.wikipedia.org/wiki/
> Myinodes_interpunctaria?gettingStartedReturn=true&useskin=cologneblue) -
> Buttons vertically
> 
> Where the buttons are might vary, but it should work.

Yeah I think this is acceptable for now. 

Keep in mind that an overwhelming majority of editors who will be seeing this
interface will see it with Vector. This is because it shows you the modals
right after you register, and thus in order to switch skins they would need to
be dismissed or you would have to open Preferences in a new tab then refresh
the page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61992] Vertical buttons instead of horizontal

2014-03-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61992

--- Comment #7 from Lokal_Profil  ---
(In reply to Matthew Flaschen from comment #6)
> (In reply to Lokal_Profil from comment #1)
> > Just tested the above in different skins:
> > * Vector: I get the above result
> > * Monobok: I get the correct result (see attachment)
> > * Modern: I get nothing
> > * Cologne: I get nothing
> 
> What do you mean, "I get nothing".  I see:
> 
> Modern
> (https://sv.wikipedia.org/wiki/
> Myinodes_interpunctaria?gettingStartedReturn=true&useskin=modern) - Buttons
> side by side.
> 
> ColoneBlue
> (https://sv.wikipedia.org/wiki/
> Myinodes_interpunctaria?gettingStartedReturn=true&useskin=cologneblue) -
> Buttons vertically
> 
> Where the buttons are might vary, but it should work.

Looked closer at this (CologneBlue and Modern) and not sure what is going on.
Firefox (27.0.1): 
* I don't see any buttons for when logged in to my normal account(s)
* Buttons appear when logged out.
* Buttons appear when logged in to a fresh account
Chrome:
* Buttons appear independently of whether I'm logged in.

Seems like it is a clash between the code for moving categories to the top of
the page in my common.js (same as that in the Commons gadget
https://commons.wikimedia.org/wiki/MediaWiki:Gadget-CategoryAboveAll.js) which
doesn't affect those skins anyhow.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61992] Vertical buttons instead of horizontal

2014-02-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61992

--- Comment #6 from Matthew Flaschen  ---
(In reply to Lokal_Profil from comment #1)
> Just tested the above in different skins:
> * Vector: I get the above result
> * Monobok: I get the correct result (see attachment)
> * Modern: I get nothing
> * Cologne: I get nothing

What do you mean, "I get nothing".  I see:

Modern
(https://sv.wikipedia.org/wiki/Myinodes_interpunctaria?gettingStartedReturn=true&useskin=modern)
- Buttons side by side.

ColoneBlue
(https://sv.wikipedia.org/wiki/Myinodes_interpunctaria?gettingStartedReturn=true&useskin=cologneblue)
- Buttons vertically

Where the buttons are might vary, but it should work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61992] Vertical buttons instead of horizontal

2014-02-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61992

Matthew Flaschen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from Matthew Flaschen  ---
The window is already fixed so there will be no vertical scrollbar.  This will
roll out to all Wikipedias March 6.

As for putting the buttons on the same line in all languages, that is bug
61922, so I'll mark this a duplicate.

*** This bug has been marked as a duplicate of bug 61922 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61992] Vertical buttons instead of horizontal

2014-02-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61992

--- Comment #4 from Lokal_Profil  ---
A fix for the problem is changing #mw-gettingstarted-editable-main-edit-page
from "min-width: 210px" to "width: 210px". (Although not the best solution
imho)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61992] Vertical buttons instead of horizontal

2014-02-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61992

--- Comment #3 from Lokal_Profil  ---
Testing uselang=qqx [1] it looks like the source of the problem might be in the
text on the edit button doesn't wrap (unlike that of the fix button). As a
result if the text is to long the button becomes wider than the default,
something which the overlay box does not take into account when determining its
width. Which is why you get the error in Swedish but not English.

[1]
https://sv.wikipedia.org/wiki/Myinodes_interpunctaria?gettingStartedReturn=true&uselang=qqx

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61992] Vertical buttons instead of horizontal

2014-02-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61992

--- Comment #2 from Lokal_Profil  ---
Created attachment 14701
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=14701&action=edit
In Monobook

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61992] Vertical buttons instead of horizontal

2014-02-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61992

--- Comment #1 from Lokal_Profil  ---
Just tested the above in different skins:
* Vector: I get the above result
* Monobok: I get the correct result (see attachment)
* Modern: I get nothing
* Cologne: I get nothing

(All in Firefox)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l