[Bug 9501] List/indication of unpatrolled uploaded media files

2012-08-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

Nemo_bis federicol...@tiscali.it changed:

   What|Removed |Added

 CC||federicol...@tiscali.it

--- Comment #12 from Nemo_bis federicol...@tiscali.it 2012-08-25 11:40:29 UTC 
---
So what does need doing here, the addition of patrol stuff to
[[Special:NewFiles]]? The system is in place, isn't it?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 9501] List/indication of unpatrolled uploaded media files

2012-08-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #13 from Krinkle krinklem...@gmail.com 2012-08-25 15:18:22 UTC ---
Not really.

What is in place is this:
* A generic database implementation for patrolling recent changes entries (any
entry, be it RC_EDIT, RC_NEW page or RC_LOG). RC_LOG includes upload actions.
So this doesn't need anything for uploads, it is already generically in place.
rc_patrolled is toggleable for log actions in theory, and uploads are logged
and in recentchanges

* A front-end for patrolling edits
 - Configurable:
Through wgUseRCPatrol[1] // enabled in mw by default, disabled on most wmf
wikis, enabled on nl.wikipedia, commons.wikimedia and dozens others
 - List:
Special:RecentChanges with Hide patrolled edits
 - Patrol-interface:
On the diff pages with [mark as patrolled]

* A front-end for patrolling new pages
 - Configurable:
Through wgUseNPPatrol[2] // enabled in mw by default
 - List:
Special:NewPages with Hide patrolled edits
 - Patrol-interface:
On the bottom when viewing a page, with [mark as patrolled] (though
subject to bug 15936, which causes the link only to be there when visiting the
page from Special:NewPages)

What we need is a front-end for patrolling uploads.
* Configurable: Of course
* List: We already have two file-list special pages (though plans to merge
exist afaik), so it would only need to have a way to indicate the patrol mark
and a way to exclude patrolled files from the view.
* Patrol interface: I would like if it were given first class treatment like
for edits (not like with new pages where it is just dumped at the bottom
through the ugly hack of passing it through a query parameter, making it not
really related to the page you're looking at).

And contrary to edits/new pages, we need something special for uploads because
contrary to regular edits, uploads are log actions. Right now those are not
patrollable because Log sets rc_patrolled to false by default.

And then there is the issue of uploads (usually?) causing two events: New page
creation and a log event. Though the new page creation is usually not emitted
afaik.


[1] https://www.mediawiki.org/wiki/Manual:$wgUseRCPatrol
[1] https://www.mediawiki.org/wiki/Manual:$wgUseNPPatrol

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 9501] List/indication of unpatrolled uploaded media files

2012-08-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||roan.katt...@gmail.com
  Component|Uploading   |Patrolling

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 9501] List/indication of unpatrolled uploaded media files

2011-04-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

k00r0sh koorosh2delb...@yahoo.com changed:

   What|Removed |Added

 CC||koorosh2delb...@yahoo.com

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 9501] List/indication of unpatrolled uploaded media files

2010-11-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

Alexandre Emsenhuber [IAlex] ialex.w...@gmail.com changed:

   What|Removed |Added

   Keywords||need-review, patch
 CC||ialex.w...@gmail.com

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 9501] List/indication of unpatrolled uploaded media files

2010-11-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

--- Comment #11 from Bawolff bawolff...@gmail.com 2010-11-20 18:30:15 UTC ---
In response to added keywords.
Note, my patch was meant more as a starting point, I don't really think its
ready/should be committed to trunk at this stage yet.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 9501] List/indication of unpatrolled uploaded media files

2010-11-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

--- Comment #9 from Krinkle krinklem...@gmail.com 2010-11-07 22:48:45 UTC ---
Oh, and before I forget. 
I was thinking about a variable like $wgUseLogPatrol instead of
$wgUserUploadPatrol.
Which would either be a boolean or an array. If boolean it disables or enables
patrolling for each log type. Or as an array to only enable it for some

ie. $wgUseLogPatrol = array( 'upload' = true, 'move' = true);

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 9501] List/indication of unpatrolled uploaded media files

2010-11-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

Bawolff bawolff...@gmail.com changed:

   What|Removed |Added

 CC||bawolff...@gmail.com

--- Comment #10 from Bawolff bawolff...@gmail.com 2010-11-07 23:06:55 UTC ---
(In reply to comment #8)

 * On Special:RecentChanges the upload log entries should show a red 
 exclamation
 mark if it's unpatrolled, and the patrolled ones should be hidden when 
 clicking

I did that as part of the patch (also made the b marker for bot uploads work
too)


 * Just like NewPage patrolling is rarely done from RecentChanges (as it's
 unpractical and doesn't provide the filtering options needed) - there is
 Special:NewPages for that with options to toggle logged-in users,  patrolled
 edits and bots. The same is the case for files, patrolling files from
 RecentChanges will most likely not be done as it doesn't give the info needed
 (size, thumbnail, etc.). Special:NewFiles is suited for this perfectly. These
 four toggle options have to be added to Special:NewFiles aswell.

That might be an issue, as special:newimages uses the image table, not the RC
table. (Special:newimages also does rather weird stuff when filtering bots that
seems inefficient (It checks if the user who uploaded is currently a bot not
that they were a bot when the image was uploaded), but I'm not all that well
versed with db efficiency). There doesn't seem to be any indexes on the needed
fields in recentchanges, so filtering rc to be only uploads might be
inefficient (Again, I don't really understand the intricacies of db efficiency,
so take what i say here with salt). 

 * Although edits are mostly not new pages, the contrary is with uploads where
 the majority are 'new' and not 're-uploads'. Which means bug 15936 -like
 situations (where going to the oldid of the first revision of a file would
 -not- show the [mark] link) are unacceptable in my opinion, without it it's
 pretty useless. 


I don't think that'd be easy to do (At least not in the way I did it in the
patch above) since its patrolling the log actions, not edits, so the oldid
(revision id) has no relation to what we're patrolling.

The other issues you mention are also things that generally apply and need to
be worked on.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 9501] List/indication of unpatrolled uploaded media files

2010-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

--- Comment #6 from Bawolff bawolff...@gmail.com 2010-11-07 03:40:30 UTC ---
Created attachment 7794
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=7794
rough patch for patrolling uploads

Rough patch to make uploads patrollable.

I haven't tested this very well, some issues that come to mind
*It generates patrol log entries of the form User:foo patrolled revision 0 of
file:some_image.png (probably not too difficult to fix)
*It re-uses a bunch of the new page patrol stuff, so the interface seems to
suggest you're patrolling a page instead of a file.
*And the big one: It only works if you follow links from RC (this is the case
for new page patrol too). Krinkle pointed out that most people wouldn't do new
image patrolling from special:recentchanges.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 9501] List/indication of unpatrolled uploaded media files

2010-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

--- Comment #7 from Krinkle krinklem...@gmail.com 2010-11-07 03:44:31 UTC ---
(In reply to comment #6)
 *And the big one: It only works if you follow links from RC (this is the case
 for new page patrol too). 
That's bug 15936 for the record.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 9501] List/indication of unpatrolled uploaded media files

2010-06-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

--- Comment #3 from Krinkle krinklem...@gmail.com 2010-06-21 16:11:06 UTC ---
After a chat on IRC we came to the conclusion that actually this should be
working right now (partially).

There's basicly two option:

* Make the upload-action patrollable (this means that theoratically an upload
without a description page is patrollable, it also means that re-uploads are
patrollable and that it needs to be integrated into the patrol model as
something new (as Rob sugggests above)

Another option:

* Creation of File-description pages are currently only patrollable if it was
not the result of an upload (ie. accidental page creation, or for example a
local wikipedia filepage for a Commons-image, such as
http://en.wikipedia.org/w/index.php?title=Special:Logpage=File:Penile-Clitoral+Structure.JPGhide_review_log=0hide_patrol_log=0
)

The latter option seems kinda of a bug that it is not the case already since
this means a lot of page creations are not patrollable. On the other hand I
think it's not wise to implement both because that would cause double work.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 9501] List/indication of unpatrolled uploaded media files

2010-06-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

--- Comment #4 from Krinkle krinklem...@gmail.com 2010-06-21 16:11:55 UTC ---
After a chat on IRC we came to the conclusion that actually this should be
working right now (partially).

There's basicly two option:

* Make the upload-action patrollable (this means that theoratically an upload
without a description page is patrollable, it also means that re-uploads are
patrollable and that it needs to be integrated into the patrol model as
something new (as Rob sugggests above)

Another option:

* Creation of File-description pages are currently only patrollable if it was
not the result of an upload (ie. accidental page creation, or for example a
local wikipedia filepage for a Commons-image, such as
http://en.wikipedia.org/w/index.php?title=Special:Logpage=File:Penile-Clitoral+Structure.JPGhide_review_log=0hide_patrol_log=0
) this functionality could be extended to cover all file-description pages
instead of only the ones not created when uploading.

The latter option seems kinda of a bug that it is not the case already since
this means a lot of page creations are not patrollable. On the other hand I
think it's not wise to implement both because that would cause double work.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 9501] List/indication of unpatrolled uploaded media files

2010-06-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

--- Comment #5 from Krinkle krinklem...@gmail.com 2010-06-21 16:12:14 UTC ---
After a chat on IRC we came to the conclusion that actually this should be
working right now (partially).

There's basicly two option:

* Make the upload-action patrollable (this means that theoratically an upload
without a description page is patrollable, it also means that re-uploads are
patrollable and that it needs to be integrated into the patrol model as
something new (as Rob sugggests above)

Another option:

* Creation of File-description pages are currently only patrollable if it was
not the result of an upload (ie. accidental page creation, or for example a
local wikipedia filepage for a Commons-image, such as
http://en.wikipedia.org/w/index.php?title=Special:Logpage=File:Penile-Clitoral+Structure.JPGhide_review_log=0hide_patrol_log=0
) this functionality could be extended to cover all file-description pages
instead of only the ones not created when uploading.

The latter option seems kinda of a bug that it is not the case already since
this means a lot of page creations are not patrollable. On the other hand I
think it's not wise to implement both because that would cause double work.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 9501] List/indication of unpatrolled uploaded media files

2010-04-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

Abigor abi...@forgotten-beauty.com changed:

   What|Removed |Added

 CC||abi...@forgotten-beauty.com
Version|1.10-svn|1.17-svn

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 9501] List/indication of unpatrolled uploaded media files

2010-04-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=9501

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #2 from Krinkle krinklem...@gmail.com 2010-04-27 22:20:21 UTC ---
What's the progress on this ?

This would be of great help on Commons, currently have do have a manual way:

http://commons.wikimedia.org/wiki/Commons:Recent_uploads_patrol

But it's basicly a lot of double work, since while wandering around on Commons,
I come across uploads of people, being able to patrol those reduces the
backlogs.

However, the old manual way on the above page would mean I'd have to do an
entire day part.

Hopefully with patrol functionality on uploads this can be sorted out better
and can be much better organised. (ie. filtering out patrolled uploads)

I asume this change would mean that anyone with the autopatrol right (bots,
autopatrollers, sysops) are ofcourse autopatrolled in Uploads aswell.

--
Krinkle

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l