Bawolff <> changed:

           What    |Removed                     |Added
                 CC|                            |

--- Comment #10 from Bawolff <> 2010-11-07 23:06:55 UTC ---
(In reply to comment #8)

> * On Special:RecentChanges the upload log entries should show a red 
> exclamation
> mark if it's unpatrolled, and the patrolled ones should be hidden when 
> clicking

I did that as part of the patch (also made the b marker for bot uploads work

> * Just like NewPage patrolling is rarely done from RecentChanges (as it's
> unpractical and doesn't provide the filtering options needed) - there is
> Special:NewPages for that with options to toggle "logged-in users,  patrolled
> edits and bots". The same is the case for files, patrolling files from
> RecentChanges will most likely not be done as it doesn't give the info needed
> (size, thumbnail, etc.). Special:NewFiles is suited for this perfectly. These
> four toggle options have to be added to Special:NewFiles aswell.

That might be an issue, as special:newimages uses the image table, not the RC
table. (Special:newimages also does rather weird stuff when filtering bots that
seems inefficient (It checks if the user who uploaded is currently a "bot" not
that they were a bot when the image was uploaded), but I'm not all that well
versed with db efficiency). There doesn't seem to be any indexes on the needed
fields in recentchanges, so filtering rc to be only uploads might be
inefficient (Again, I don't really understand the intricacies of db efficiency,
so take what i say here with salt). 

> * Although edits are mostly not new pages, the contrary is with uploads where
> the majority are 'new' and not 're-uploads'. Which means bug 15936 -like
> situations (where going to the oldid of the first revision of a file would
> -not- show the [mark] link) are unacceptable in my opinion, without it it's
> pretty useless. 

I don't think that'd be easy to do (At least not in the way I did it in the
patch above) since its patrolling the log actions, not edits, so the oldid
(revision id) has no relation to what we're patrolling.

The other issues you mention are also things that generally apply and need to
be worked on.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

Wikibugs-l mailing list

Reply via email to