[Wikidata-bugs] [Maniphest] [Commented On] T255078: Fatal "Managed to lookup EntityId but got an unexpected type for namespace" from Wikibase EntityLinkTargetEntityIdLookup

2020-06-11 Thread Tacsipacsi
Tacsipacsi added a comment. In T255078#6213055 , @Addshore wrote: >> Makes the page history inaccessible (at least logged in; logged-out access seems to work). > > Interesting, when logged in for me it seems to work fine

[Wikidata-bugs] [Maniphest] [Updated] T255078: Fatal "Managed to lookup EntityId but got an unexpected type for namespace" from Wikibase EntityLinkTargetEntityIdLookup

2020-06-11 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.36; 2020-06-09); removed MW-1.35-notes (1.35.0-wmf.37; 2020-06-16). TASK DETAIL https://phabricator.wikimedia.org/T255078 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T255078: Fatal "Managed to lookup EntityId but got an unexpected type for namespace" from Wikibase EntityLinkTargetEntityIdLookup

2020-06-11 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2020-06-11T23:54:12Z] Synchronized php-1.35.0-wmf.36/extensions/Wikibase: [[gerrit:604845|Fix entity id lookup for interwiki special page links (T255078 )]] (duration: 00m 38s)

[Wikidata-bugs] [Maniphest] [Commented On] T255078: Fatal "Managed to lookup EntityId but got an unexpected type for namespace" from Wikibase EntityLinkTargetEntityIdLookup

2020-06-11 Thread Ladsgroup
Ladsgroup added a comment. In T255078#6217353 , @Addshore wrote: >> Krinkle removed projects: Regression >> Krinkle renamed this task from EntityLinkTargetEntityIdLookup RuntimeException when rendering links for wikidata items on

[Wikidata-bugs] [Maniphest] [Commented On] T255078: Fatal "Managed to lookup EntityId but got an unexpected type for namespace" from Wikibase EntityLinkTargetEntityIdLookup

2020-06-11 Thread gerritbot
gerritbot added a comment. Change 604845 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.36] Fix entity id lookup for interwiki special page links https://gerrit.wikimedia.org/r/604845 TASK DETAIL https://phabricator.wikimedia.org/T255078 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T154601: Grafana: "wikidata-datamodel-terms" doesn't update anymore

2020-06-11 Thread GoranSMilovanovic
GoranSMilovanovic added a comment. @Ladsgroup @Addshore Do you need any help around this thing? TASK DETAIL https://phabricator.wikimedia.org/T154601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: GoranSMilovanovic Cc: Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Edited] T254431: Deprecate SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook

2020-06-11 Thread Jdlrobson
Jdlrobson updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T254431 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ammarpad, Jdlrobson Cc: Aklapper, Jdlrobson, Ammarpad, darthmon_wmde, MJL, Dinadineke, DannyS712, Nandana,

[Wikidata-bugs] [Maniphest] [Retitled] T252841: Update the method Wikibase uses to inject edit language links into the language portlet

2020-06-11 Thread Krinkle
Krinkle renamed this task from "Update the method Wikibase uses to inject edit language links into the language portal" to "Update the method Wikibase uses to inject edit language links into the language portlet". TASK DETAIL https://phabricator.wikimedia.org/T252841 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T254431: Deprecate SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook

2020-06-11 Thread Jdlrobson
Jdlrobson added a comment. The remaining extensions will be notified by the deprecation notice (as they are not deployed using Wikimedia release cycles). This can now be deprecated. https://codesearch.wmflabs.org/extensions/?q=SkinTemplateBuildNavUrlsNav_urlsAfterPermalink=nope== TASK

[Wikidata-bugs] [Maniphest] [Triaged] T254431: Deprecate SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook

2020-06-11 Thread Jdlrobson
Jdlrobson triaged this task as "High" priority. Jdlrobson added a project: patch-welcome. Jdlrobson updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T254431 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ammarpad,

[Wikidata-bugs] [Maniphest] [Closed] T254949: BaseTemplateAfterPortlet is silent deprecated - use SkinAfterPortlet in Wikibase

2020-06-11 Thread Jdlrobson
Jdlrobson closed this task as "Resolved". Jdlrobson claimed this task. Jdlrobson added a comment. Fixed by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/603543/ https://codesearch.wmflabs.org/extensions/?q=BaseTemplateAfterPortlet=nope== TASK DETAIL

[Wikidata-bugs] [Maniphest] [Unblock] T254431: Deprecate SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook

2020-06-11 Thread Jdlrobson
Jdlrobson closed subtask T254433: Collection should not use SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T254431 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ammarpad, Jdlrobson

[Wikidata-bugs] [Maniphest] [Updated] T252841: Update the method Wikibase uses to inject edit language links into the language portal

2020-06-11 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.37; 2020-06-16); removed MW-1.35-notes (1.35.0-wmf.35; 2020-06-02). TASK DETAIL https://phabricator.wikimedia.org/T252841 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ammarpad,

[Wikidata-bugs] [Maniphest] [Commented On] T255078: Fatal "Managed to lookup EntityId but got an unexpected type for namespace" from Wikibase EntityLinkTargetEntityIdLookup

2020-06-11 Thread Addshore
Addshore added a comment. > Krinkle removed projects: Regression > Krinkle renamed this task from EntityLinkTargetEntityIdLookup RuntimeException when rendering links for wikidata items on commons using interwiki links to Fatal "Managed to lookup EntityId but got an unexpected type for

[Wikidata-bugs] [Maniphest] [Closed] T252841: Update the method Wikibase uses to inject edit language links into the language portal

2020-06-11 Thread Jdlrobson
Jdlrobson closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T252841 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ammarpad, Jdlrobson Cc: Ammarpad, Ladsgroup, Addshore, Aklapper, Jdlrobson, Blissjay007, Oblanco79,

[Wikidata-bugs] [Maniphest] [Commented On] T252841: Update the method Wikibase uses to inject edit language links into the language portal

2020-06-11 Thread gerritbot
gerritbot added a comment. Change 603543 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] WikibaseClient: Use SkinAfterPortlet hook to add languages action links https://gerrit.wikimedia.org/r/603543 TASK DETAIL https://phabricator.wikimedia.org/T252841 EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T253685: WikibaseRepo should use the SidebarBeforeOutput hook instead of BaseTemplateToolbox

2020-06-11 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T253685 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ammarpad, Maintenance_bot Cc: Addshore, Aklapper, D3r1ck01, Mainframe98, Jdlrobson, Demian,

[Wikidata-bugs] [Maniphest] [Updated] T255078: Fatal "Managed to lookup EntityId but got an unexpected type for namespace" from Wikibase EntityLinkTargetEntityIdLookup

2020-06-11 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.37; 2020-06-16); removed MW-1.35-notes (1.35.0-wmf.36; 2020-06-09). TASK DETAIL https://phabricator.wikimedia.org/T255078 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE,

[Wikidata-bugs] [Maniphest] [Updated] T253685: WikibaseRepo should use the SidebarBeforeOutput hook instead of BaseTemplateToolbox

2020-06-11 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16). TASK DETAIL https://phabricator.wikimedia.org/T253685 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ammarpad, ReleaseTaggerBot Cc: Addshore, Aklapper, D3r1ck01,

[Wikidata-bugs] [Maniphest] [Changed Status] T254431: Deprecate SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook

2020-06-11 Thread Jdlrobson
Jdlrobson changed the task status from "Stalled" to "Open". Jdlrobson updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T254431 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ammarpad, Jdlrobson Cc: Aklapper, Jdlrobson,

[Wikidata-bugs] [Maniphest] [Blocker] T254431: Deprecate SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook

2020-06-11 Thread Jdlrobson
Jdlrobson changed the status of subtask T254433: Collection should not use SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook from Stalled to Open. TASK DETAIL https://phabricator.wikimedia.org/T254431 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Unblock] T254431: Deprecate SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook

2020-06-11 Thread Jdlrobson
Jdlrobson closed subtask T253685: WikibaseRepo should use the SidebarBeforeOutput hook instead of BaseTemplateToolbox as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T254431 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ammarpad,

[Wikidata-bugs] [Maniphest] [Closed] T253685: WikibaseRepo should use the SidebarBeforeOutput hook instead of BaseTemplateToolbox

2020-06-11 Thread Jdlrobson
Jdlrobson closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T253685 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ammarpad, Jdlrobson Cc: Addshore, Aklapper, D3r1ck01, Mainframe98, Jdlrobson, Blissjay007, Oblanco79,

[Wikidata-bugs] [Maniphest] [Commented On] T255078: Fatal "Managed to lookup EntityId but got an unexpected type for namespace" from Wikibase EntityLinkTargetEntityIdLookup

2020-06-11 Thread gerritbot
gerritbot added a comment. Change 604624 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Fix entity id lookup for interwiki special page links https://gerrit.wikimedia.org/r/604624 TASK DETAIL https://phabricator.wikimedia.org/T255078 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T253685: WikibaseRepo should use the SidebarBeforeOutput hook instead of BaseTemplateToolbox

2020-06-11 Thread gerritbot
gerritbot added a comment. Change 604530 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Use SidebarBeforeOutput hook to add Wikibase Concept URI sidebar link. https://gerrit.wikimedia.org/r/604530 TASK DETAIL https://phabricator.wikimedia.org/T253685 EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T254949: BaseTemplateAfterPortlet is silent deprecated - use SkinAfterPortlet in Wikibase

2020-06-11 Thread Jdlrobson
Jdlrobson added a project: patch-welcome. TASK DETAIL https://phabricator.wikimedia.org/T254949 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Jdlrobson, darthmon_wmde, Dinadineke, DannyS712, Nandana, tabish.shaikh91, Lahi,

[Wikidata-bugs] [Maniphest] [Commented On] T252841: Update the method Wikibase uses to inject edit language links into the language portal

2020-06-11 Thread Jdlrobson
Jdlrobson added a comment. Verified the above patch on Monobook, Vector and the link shows on all Wikimedia deployed skins when there are or are not languages. Here's Vector: F31861964: Screen Shot 2020-06-11 at 1.10.17 PM.png F31861970:

[Wikidata-bugs] [Maniphest] [Retitled] T255078: Fatal "Managed to lookup EntityId but got an unexpected type for namespace" from Wikibase EntityLinkTargetEntityIdLookup

2020-06-11 Thread Krinkle
Krinkle renamed this task from "EntityLinkTargetEntityIdLookup RuntimeException when rendering links for wikidata items on commons using interwiki links" to "Fatal "Managed to lookup EntityId but got an unexpected type for namespace" from Wikibase EntityLinkTargetEntityIdLookup". Krinkle

[Wikidata-bugs] [Maniphest] [Reassigned] T255078: EntityLinkTargetEntityIdLookup RuntimeException when rendering links for wikidata items on commons using interwiki links

2020-06-11 Thread Addshore
Addshore reassigned this task from Addshore to Jakob_WMDE. Addshore edited projects, added Wikibase - Federated Properties (Sprint 1/6 (Hike 2)); removed Wikibase - Federated Properties. TASK DETAIL https://phabricator.wikimedia.org/T255078 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Edited] T255078: EntityLinkTargetEntityIdLookup RuntimeException when rendering links for wikidata items on commons using interwiki links

2020-06-11 Thread Addshore
Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T255078 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: thcipriani, WMDE-leszek, Pablo-WMDE, tstarling, Samuele2002, Agusbou2015, Liuxinyu970226, toan,

[Wikidata-bugs] [Maniphest] [Commented On] T255078: EntityLinkTargetEntityIdLookup RuntimeException when rendering links for wikidata items on commons using interwiki links

2020-06-11 Thread gerritbot
gerritbot added a comment. Change 604845 had a related patch set uploaded (by Addshore; owner: Jakob): [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.36] Fix entity id lookup for interwiki special page links https://gerrit.wikimedia.org/r/604845 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Edited] T255187: Special:NewItem appears to have placeholder text heading "⧼Create a new Item⧽"

2020-06-11 Thread Addshore
Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T255187 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Aklapper, Addshore, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Created] T255187: Special:NewItem appears to have placeholder text heading "⧼Create a new Item⧽"

2020-06-11 Thread Addshore
Addshore created this task. Addshore added projects: Wikidata, Regression, MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION F31861916: image.png in QQX this is

[Wikidata-bugs] [Maniphest] [Commented On] T253685: WikibaseRepo should use the SidebarBeforeOutput hook instead of BaseTemplateToolbox

2020-06-11 Thread Jdlrobson
Jdlrobson added a comment. After the change the concept UI (highlighted) remains in the menu for Vector and is **restored** for Monobook F31861904: Screen Shot 2020-06-11 at 12.15.19 PM.png F31861903: Screen Shot 2020-06-11 at 12.16.16 PM.png

[Wikidata-bugs] [Maniphest] [Updated] T251007: Remove entityViewInit's dependency on entityLoaded

2020-06-11 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16). TASK DETAIL https://phabricator.wikimedia.org/T251007 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE, ReleaseTaggerBot Cc: Nikki, WMDE-leszek,

[Wikidata-bugs] [Maniphest] [Retitled] T249839: Fix Flow InvalidDataException in CI builds

2020-06-11 Thread Krinkle
Krinkle renamed this task from "Fix Flow InvalidDataException in Wikibase CI builds" to "Fix Flow InvalidDataException in CI builds". TASK DETAIL https://phabricator.wikimedia.org/T249839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T249839: Fix Flow InvalidDataException in Wikibase CI builds

2020-06-11 Thread Krinkle
Krinkle added a comment. @kostajh Some questions/ideas to get on the way: - Is this Flow unit test behaving in as expected? E.g. it's asserting something good, but has an async failure that you expect, but aren't yet catching/asserting. - Or is it asserting something good, but has an

[Wikidata-bugs] [Maniphest] [Commented On] T172368: Make the Wikibase.git code base PSR-4 compatible

2020-06-11 Thread gerritbot
gerritbot added a comment. Change 604735 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Move \Wikibase\Rdf classes to \Wikibase\Repo\Rdf https://gerrit.wikimedia.org/r/604735 TASK DETAIL https://phabricator.wikimedia.org/T172368 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

2020-06-11 Thread gerritbot
gerritbot added a comment. Change 604784 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/Wikibase@master] Remove WikibaseRepo Maintenance Scripts Autoload https://gerrit.wikimedia.org/r/604784 TASK DETAIL https://phabricator.wikimedia.org/T255108

[Wikidata-bugs] [Maniphest] [Updated] T255108: Figure out what to do with autoload entries for repo maintenance scripts

2020-06-11 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T255108 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow, gerritbot Cc: Addshore, Ladsgroup, WMDE-leszek, Aklapper, gerritbot, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Updated] T255044: Many new metrics in Graphite for WDQS-Streaming-Updater-POC

2020-06-11 Thread Milimetric
Milimetric edited projects, added Wikidata-Query-Service, Discovery; removed Analytics. Restricted Application added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T255044 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Updated] T251007: Remove entityViewInit's dependency on entityLoaded

2020-06-11 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T251007 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE, Maintenance_bot Cc: Nikki, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper,

[Wikidata-bugs] [Maniphest] [Unblock] T250305: wmf-quibble-vendor-mysql-php72-docker failed on Special:EntityData

2020-06-11 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T251007: Remove entityViewInits dependency on entityLoaded as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T250305 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc:

[Wikidata-bugs] [Maniphest] [Closed] T251007: Remove entityViewInit's dependency on entityLoaded

2020-06-11 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T251007 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE, Lucas_Werkmeister_WMDE Cc: Nikki, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T251007: Remove entityViewInit's dependency on entityLoaded

2020-06-11 Thread gerritbot
gerritbot added a comment. Change 592416 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] entityViewInit: don't express entityLoaded module dep https://gerrit.wikimedia.org/r/592416 TASK DETAIL https://phabricator.wikimedia.org/T251007 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T255078: EntityLinkTargetEntityIdLookup RuntimeException when rendering links for wikidata items on commons using interwiki links

2020-06-11 Thread Addshore
Addshore added a comment. Yup, thanks! Indeed it makes no sense to have `[[Q123]] [[P123]] [[M123]]` work on commons, or even on wikidata (unless the namespace matches). We went down the wrong path there a bit. So out of those Q123 on wikidata is the only thing that ever makes sense to

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

2020-06-11 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Hmph, yeah. Looking at code search , a handful of tests probably also need their test subject classes to be autoloadable (though I suppose they could

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

2020-06-11 Thread Tarrow
Tarrow added a comment. and I imagine the same thing is needed for RebuildTermsSearchKey TASK DETAIL https://phabricator.wikimedia.org/T255108 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Addshore, Ladsgroup, WMDE-leszek, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T255078: EntityLinkTargetEntityIdLookup RuntimeException when rendering links for wikidata items on commons using interwiki links

2020-06-11 Thread Tacsipacsi
Tacsipacsi added a comment. In T255078#6215449 , @Addshore wrote: > On commons as link such as `[[M123]]` is a valid link to a media info entity, so it goes through this hook rendering stuff. Does this mean that one cannot link to

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

2020-06-11 Thread Tarrow
Tarrow added a comment. Having just ripped them out spinning up a mediawiki-docker-dev environment throws Cannot spawn child: Wikibase\Repo\Maintenance\PopulateTermFullEntityId [d0c07525d42cb2059d632688] [no req] Error from line 715 of

[Wikidata-bugs] [Maniphest] [Retitled] T254949: BaseTemplateAfterPortlet is silent deprecated - use SkinAfterPortlet in Wikibase

2020-06-11 Thread Jdlrobson
Jdlrobson renamed this task from "BaseTemplateAfterPortlet is silent deprecated - use SkinAfterPortlet" to "BaseTemplateAfterPortlet is silent deprecated - use SkinAfterPortlet in Wikibase". TASK DETAIL https://phabricator.wikimedia.org/T254949 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T254283: Remove legacy EntityInfo based prefetching

2020-06-11 Thread WDoranWMF
WDoranWMF added a project: Core Platform Team. TASK DETAIL https://phabricator.wikimedia.org/T254283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, WDoranWMF Cc: Jakob_WMDE, Addshore, Aklapper, Blissjay007, Oblanco79, Alter-paule,

[Wikidata-bugs] [Maniphest] [Closed] T255118: Font size in Extension:WikidataPageBanner is out of control at Russian Wikivoyage

2020-06-11 Thread Atsirlin
Atsirlin closed this task as "Resolved". Atsirlin claimed this task. Atsirlin added a comment. We were able to fix it, although it's still unclear what changed the default font-size in .wpb-banner-toc TASK DETAIL https://phabricator.wikimedia.org/T255118 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T172368: Make the Wikibase.git code base PSR-4 compatible

2020-06-11 Thread gerritbot
gerritbot added a comment. Change 604735 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Move \Wikibase\Rdf classes to \Wikibase\Repo\Rdf https://gerrit.wikimedia.org/r/604735 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T255078: EntityLinkTargetEntityIdLookup RuntimeException when rendering links for wikidata items on commons using interwiki links

2020-06-11 Thread Addshore
Addshore added a comment. Another point, this issue can only occur on special pages and on diff pages per https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php#L373-L377 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Updated] T255078: EntityLinkTargetEntityIdLookup RuntimeException when rendering links for wikidata items on commons using interwiki links

2020-06-11 Thread Addshore
Addshore added a comment. Had a quick call with @Jakob_WMDE to iron out the last few apparent issues, and we should have a patch together but the end of the day. T205268: Many services in GenericServices are not actually that generic. has it's

[Wikidata-bugs] [Maniphest] [Updated] T254688: SpecialWhatLinksHere::showIndirectLinks on wikidatawiki needs optimizing

2020-06-11 Thread Ladsgroup
Ladsgroup added a project: Core Platform Team. Ladsgroup added a comment. I think even if it's due to size of Wikidata, there's nothing in the Wikibase code we can do to fix/address it. I assume CPT should take a look. > rows: 88669406 Beautiful TASK DETAIL

[Wikidata-bugs] [Maniphest] [Triaged] T255054: PHP Warning: No RDF builder defined for data type wikibase-form nor for value type bad.

2020-06-11 Thread WMDE-leszek
WMDE-leszek triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T255054 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: Lydia_Pintscher, WMDE-leszek, Pablo-WMDE, Aklapper, thcipriani, darthmon_wmde,

[Wikidata-bugs] [Maniphest] [Commented On] T154601: Grafana: "wikidata-datamodel-terms" doesn't update anymore

2020-06-11 Thread Ladsgroup
Ladsgroup added a comment. In T154601#6202952 , @Addshore wrote: > In T154601#6202918 , @Lucas_Werkmeister_WMDE wrote: > >> That said, I tried to run the queries against stat1007.

[Wikidata-bugs] [Maniphest] [Updated] T128173: Represent editions as interwiki links on Wikisource

2020-06-11 Thread Ltrlg
Ltrlg added a comment. I would change steps 3..5 to something like 3. List all other editions of the work (P629 +P747 ) with a sitelink in the target language 4. If there is exactly one, use that one and

[Wikidata-bugs] [Maniphest] [Edited] T254881: Explore visual regression testing

2020-06-11 Thread darthmon_wmde
darthmon_wmde updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T254881 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthmon_wmde Cc: Sarai-WMDE, Aklapper, raja_wmde, darthmon_wmde, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Claimed] T172368: Make the Wikibase.git code base PSR-4 compatible

2020-06-11 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T172368 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ItamarWMDE, Lucas_Werkmeister_WMDE, Eileenmcnaughton, gerritbot, Ricordisamoa,

[Wikidata-bugs] [Maniphest] [Created] T255147: WikibaseLexeme properties are typed owl:DatatypeProperty rather than owl:ObjectProperty in RDF

2020-06-11 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Lexicographical data. TASK DESCRIPTION As an RDF/OWL expert, I want lexeme-related predicates to be typed correctly. (This is vague because I’m not an RDF/OWL expert) **Problem:** T161991

[Wikidata-bugs] [Maniphest] [Claimed] T255108: Figure out what to do with autoload entries for repo maintenance scripts

2020-06-11 Thread Tarrow
Tarrow claimed this task. Tarrow moved this task from Backlog to Doing on the Wikibase Extension Decoupling and Registration (Sprint 1) board. TASK DETAIL https://phabricator.wikimedia.org/T255108 WORKBOARD https://phabricator.wikimedia.org/project/board/4827/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T251007: Remove entityViewInit's dependency on entityLoaded

2020-06-11 Thread Pablo-WMDE
Pablo-WMDE added a comment. Opened https://gerrit.wikimedia.org/r/592416 for review. TASK DETAIL https://phabricator.wikimedia.org/T251007 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Nikki, WMDE-leszek, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

2020-06-11 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. > AFAIK the ain't scripts that use that base class should all load it directly anyway, which would still need to happen even if everything were using PSR4, as there is no autoloader at the start of maintenance script currently. Well,

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

2020-06-11 Thread Michael
Michael added a comment. In T249598#6074491 , @daniel wrote: > So, can we close this? The original core test still throws errors that seem related to Wikibase, but, OTOH, it is currently 1555 commits behind master. Could you verify

[Wikidata-bugs] [Maniphest] [Created] T255136: Use WikibaseDataModelTypes instead of local Wikibase data model TS definitions

2020-06-11 Thread Tonina_Zhelyazkova_WMDE
Tonina_Zhelyazkova_WMDE created this task. Tonina_Zhelyazkova_WMDE added projects: Wikidata, Wikidata Tainted References, Technical-Debt, wikidata-tech-focus. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Since June 2020 there is a centralized place for TypeScript

[Wikidata-bugs] [Maniphest] [Created] T255134: Use WikibaseDataModelTypes instead of local Wikibase data model TS definitions

2020-06-11 Thread Tonina_Zhelyazkova_WMDE
Tonina_Zhelyazkova_WMDE created this task. Tonina_Zhelyazkova_WMDE added projects: Wikidata, Technical-Debt, wikidata-tech-focus, Wikidata-Termbox. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Since June 2020 there is a centralized place for TypeScript interfaces and

[Wikidata-bugs] [Maniphest] [Commented On] T114772: [Task] Implement SiteIdMapper service

2020-06-11 Thread WMDE-leszek
WMDE-leszek added a comment. @Ladsgroup I am looking. Not immediately for certain. TASK DETAIL https://phabricator.wikimedia.org/T114772 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: Ladsgroup, Lydia_Pintscher, WMDE-leszek,

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

2020-06-11 Thread Ladsgroup
Ladsgroup added a comment. I want to add even if we need to load them somewhere, they still don't need to be fully PSR-4 compliant, you can just put them in AutoLoadClasses in the extension.json file, that would get rid of autoload.php and makes loading the extension though extension

[Wikidata-bugs] [Maniphest] [Updated] T114772: [Task] Implement SiteIdMapper service

2020-06-11 Thread Ladsgroup
Ladsgroup added subscribers: darthmon_wmde, WMDE-leszek, Lydia_Pintscher, Ladsgroup. Ladsgroup added a comment. @Lydia_Pintscher @WMDE-leszek @darthmon_wmde Can this be picked up in camp? This is blocking wiki renames (T30441 ) TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T172368: Make the Wikibase.git code base PSR-4 compatible

2020-06-11 Thread gerritbot
gerritbot added a comment. Change 604351 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Move some \Wikibase\Rdf classes to \Wikibase\Repo\Rdf https://gerrit.wikimedia.org/r/604351 TASK DETAIL https://phabricator.wikimedia.org/T172368 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T254485: Regression: Wikidata item missing in Monobook (WikibaseClient should use the SidebarBeforeOutput hook instead of BaseTemplateToolbox)

2020-06-11 Thread Sailko
Sailko added a comment. Thank you, it worked! Francesco Il giorno mer 10 giu 2020 alle ore 02:21 Rhadamante < no-re...@phabricator.wikimedia.org> ha scritto: > Rhadamante added a comment. View Task > https://phabricator.wikimedia.org/T254485 > > In T254485#6204761

[Wikidata-bugs] [Maniphest] [Commented On] T128173: Represent editions as interwiki links on Wikisource

2020-06-11 Thread Ankry
Ankry added a comment. In T128173#6214317 , @Tpt wrote: > I believe that the approach would be: > For each language: > > 1. If there is a local inter-language link to this language in the wikitext of the page, use it and stop the

[Wikidata-bugs] [Maniphest] [Commented On] T240373: Maxlag=5 for Edoderoobot

2020-06-11 Thread Edoderoo
Edoderoo added a comment. I believe this one can be closed? TASK DETAIL https://phabricator.wikimedia.org/T240373 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Edoderoo Cc: Lydia_Pintscher, Edoderoo, Addshore, Aklapper, Pintoch, darthmon_wmde,

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

2020-06-11 Thread Addshore
Addshore added a comment. > I’m not sure if the maintenance scripts need to be autoloadable at all Indeed they probably don't need to be, as they should be run directly. And DumpEntities afaik is the only exception, although it in itself isn't really a maintenance script. AFAIK

[Wikidata-bugs] [Maniphest] [Commented On] T172368: Make the Wikibase.git code base PSR-4 compatible

2020-06-11 Thread gerritbot
gerritbot added a comment. Change 604071 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Make DumpEntities follow PSR-4 https://gerrit.wikimedia.org/r/604071 TASK DETAIL https://phabricator.wikimedia.org/T172368 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T255108: Figure out what to do with autoload entries for repo maintenance scripts

2020-06-11 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. To recap: the problem is that the maintenance script file starts lowercase, but the file starts uppercase, therefore PSR-4 can’t be used to autoload e. g. `\Wikibase\Repo\Maintenance\DumpRdf` from `repo/maintenance/dumpRdf.php`, it would have to be

[Wikidata-bugs] [Maniphest] [Created] T255118: Font size in Extension:WikidataPageBanner is out of control at Russian Wikivoyage

2020-06-11 Thread Atsirlin
Atsirlin created this task. Atsirlin added a project: Wikidata-Page-Banner. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Table of contents created by Extension:WikidataPageBanner at Russian Wikivoyage is displayed in a

[Wikidata-bugs] [Maniphest] [Updated] T128173: Represent editions as interwiki links on Wikisource

2020-06-11 Thread Tpt
Tpt added a comment. In T128173#6214099 , @Addshore wrote: > Does that mean we should resolve this task? Or is the "other editions" bit also within this task? :) I believe the "other editions" bit is also in this task. I plan to

[Wikidata-bugs] [Maniphest] [Retitled] T255078: EntityLinkTargetEntityIdLookup RuntimeException when rendering links for wikidata items on commons using interwiki links

2020-06-11 Thread Addshore
Addshore renamed this task from "RuntimeException when trying to view history of [[c:Template talk:Wikidata Infobox]]" to "EntityLinkTargetEntityIdLookup RuntimeException when rendering links for wikidata items on commons using interwiki links". Addshore updated the task description. TASK

[Wikidata-bugs] [Maniphest] [Created] T255108: Figure out what to do with autoload entries for repo maintenance scripts

2020-06-11 Thread ItamarWMDE
ItamarWMDE created this task. ItamarWMDE added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, Wikibase Extension Decoupling and Registration (Sprint 1). TASK DESCRIPTION Consider the following: - If we leave `autoload.php` we will need to add a comment to stop people also

[Wikidata-bugs] [Maniphest] [Updated] T255078: RuntimeException when trying to view history of [[c:Template talk:Wikidata Infobox]]

2020-06-11 Thread Addshore
Addshore removed a parent task: T254173: 1.35.0-wmf.36 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T255078 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: thcipriani, WMDE-leszek, Pablo-WMDE, tstarling,

[Wikidata-bugs] [Maniphest] [Lowered Priority] T255078: RuntimeException when trying to view history of [[c:Template talk:Wikidata Infobox]]

2020-06-11 Thread Addshore
Addshore lowered the priority of this task from "Unbreak Now!" to "High". Addshore added a comment. Demoting to high and removing as a train blocker now that we understand this a bit more. This only happens on repos, and will also only really happen on commons. As no one has deemed it too

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T255054: PHP Warning: No RDF builder defined for data type wikibase-form nor for value type bad.

2020-06-11 Thread Pablo-WMDE
Pablo-WMDE added subscribers: WMDE-leszek, Lydia_Pintscher. Pablo-WMDE added a comment. @Lydia_Pintscher EM (e.g. @WMDE-leszek) will approach you for triage. TASK DETAIL https://phabricator.wikimedia.org/T255054 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T255052: Managed to lookup EntityId but got an unexpected type for namespace.

2020-06-11 Thread Addshore
Addshore added a comment. In T255052#6213631 , @Pablo-WMDE wrote: > Only having had a brief look at this, I //think// this is a duplicate of T255078: RuntimeException when trying to view history of [[c:Template talk:Wikidata Infobox]]

[Wikidata-bugs] [Maniphest] [Merged] T255078: RuntimeException when trying to view history of [[c:Template talk:Wikidata Infobox]]

2020-06-11 Thread Addshore
Addshore merged a task: T255052: Managed to lookup EntityId but got an unexpected type for namespace.. Addshore added a subscriber: thcipriani. TASK DETAIL https://phabricator.wikimedia.org/T255078 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Updated] T255052: Managed to lookup EntityId but got an unexpected type for namespace.

2020-06-11 Thread Addshore
Addshore closed this task as a duplicate of T255078: RuntimeException when trying to view history of [[c:Template talk:Wikidata Infobox]]. TASK DETAIL https://phabricator.wikimedia.org/T255052 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore

[Wikidata-bugs] [Maniphest] [Unblock] T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views

2020-06-11 Thread Addshore
Addshore closed subtask T249613: Cleanup rows from wb_items_per_site that should not be there any more as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T249565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: WMDE-leszek,

[Wikidata-bugs] [Maniphest] [Commented On] T128173: Represent editions as interwiki links on Wikisource

2020-06-11 Thread Addshore
Addshore added a comment. In T128173#6213769 , @Tpt wrote: > Since yesterday, if a Wikisource page is connected to a Wikidata item that states that it is an edition of the work using P629 ,

[Wikidata-bugs] [Maniphest] [Closed] T249613: Cleanup rows from wb_items_per_site that should not be there any more

2020-06-11 Thread Addshore
Addshore closed this task as "Resolved". Addshore added a comment. Closing this, as I'm pretty sure it has been announced and used already TASK DETAIL https://phabricator.wikimedia.org/T249613 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo,

[Wikidata-bugs] [Maniphest] [Closed] T254443: Refactor EntityRevisionLookup::LATEST_FROM_* to LookupConstants::

2020-06-11 Thread Addshore
Addshore closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T254443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan, Addshore Cc: Addshore, Aklapper, toan, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Closed] T254387: SpecialSetSiteLinkTest::testExecutePostRemoveSiteLink & testExecutePostModifySiteLink failing for no apparent reason

2020-06-11 Thread Addshore
Addshore closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T254387 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Addshore Cc: Ladsgroup, Addshore, Aklapper, toan, Liuxinyu970226, Hazizibinmahdi, Iflorez,

[Wikidata-bugs] [Maniphest] [Closed] T253737: Release and use wikibase/data-model 9.5.1 everywhere

2020-06-11 Thread Addshore
Addshore closed this task as "Resolved". Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T253737 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL

[Wikidata-bugs] [Maniphest] [Closed] T252019: Remove Wikibase assumption that a false dbname is the only way to refer to the local DB.

2020-06-11 Thread Addshore
Addshore closed this task as "Resolved". Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Addshore added a comment. The core of this is all deployed and working. The CloneDatabase thing is only related TASK DETAIL

[Wikidata-bugs] [Maniphest] [Edited] T253737: Release and use wikibase/data-model 9.5.1 everywhere

2020-06-11 Thread Addshore
Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T253737 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan, Addshore Cc: Aklapper, Addshore, Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Unblock] T242087: entitysources: Directly create entitySources config for WMF sites instead of using compat layer

2020-06-11 Thread Addshore
Addshore closed subtask T252019: Remove Wikibase assumption that a false dbname is the only way to refer to the local DB. as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T242087 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T255078: RuntimeException when trying to view history of [[c:Template talk:Wikidata Infobox]]

2020-06-11 Thread gerritbot
gerritbot added a comment. Change 604624 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] Fix entity id lookup for interwiki special page links https://gerrit.wikimedia.org/r/604624 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Updated] T255078: RuntimeException when trying to view history of [[c:Template talk:Wikidata Infobox]]

2020-06-11 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T255078 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, gerritbot Cc: WMDE-leszek, Pablo-WMDE, tstarling, Samuele2002, Agusbou2015, Liuxinyu970226,

  1   2   >