[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread Ammarpad
Ammarpad added a project: WikibaseMediaInfo. TASK DETAIL https://phabricator.wikimedia.org/T259745 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ammarpad Cc: Agusbou2015, Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, Un1tY,

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread Ammarpad
Ammarpad claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T259745 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ammarpad Cc: Agusbou2015, Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696,

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T259745 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Agusbou2015, Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, Un1tY,

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread gerritbot
gerritbot added a comment. Change 618643 had a related patch set uploaded (by Ammarpad; owner: Ammarpad): [mediawiki/extensions/WikibaseMediaInfo@master] Fix array unpacking as argument list https://gerrit.wikimedia.org/r/618643 TASK DETAIL https://phabricator.wikimedia.org/T259745

[Wikidata-bugs] [Maniphest] T205094: Investigate and restructure SQL directory, and use new MediaWiki abstract schema change features

2020-08-05 Thread Ladsgroup
Ladsgroup added a comment. In T205094#6364135 , @Izno wrote: > In T205094#6359681 , @Ladsgroup wrote: > >> Mediawiki core actually supports upgrading from basically any version. A

[Wikidata-bugs] [Maniphest] T205094: Investigate and restructure SQL directory, and use new MediaWiki abstract schema change features

2020-08-05 Thread Ladsgroup
Ladsgroup added a comment. Found it: T230317: Error: 1146 Table 'valid_tag' doesn't exist when upgrading from an ancient MediaWiki version TASK DETAIL https://phabricator.wikimedia.org/T205094 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T256875: The streaming updater should support page deletions

2020-08-05 Thread gerritbot
gerritbot added a comment. Change 618634 had a related patch set uploaded (by Mstyles; owner: Mstyles): [wikidata/query/rdf@master] Adds delete case to DecideMutationOperation https://gerrit.wikimedia.org/r/618634 TASK DETAIL https://phabricator.wikimedia.org/T256875 EMAIL

[Wikidata-bugs] [Maniphest] T256875: The streaming updater should support page deletions

2020-08-05 Thread Mstyles
Mstyles added a comment. What do we want to do if we get a PageDelete event for the same item multiple times? Right now we're not tracking deletes, so I'm assuming multiple deletes for the same item probably can't do that much harm. TASK DETAIL https://phabricator.wikimedia.org/T256875

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

2020-08-05 Thread Ladsgroup
Ladsgroup added a subscriber: toan. Ladsgroup added a comment. Caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/608628 Deployed this week: https://www.mediawiki.org/wiki/MediaWiki_1.36/wmf.3#Wikibase TASK DETAIL https://phabricator.wikimedia.org/T259744

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

2020-08-05 Thread Ladsgroup
Ladsgroup added subscribers: Michael, Pablo-WMDE, Addshore, Ladsgroup. Ladsgroup added a comment. Adding @Pablo-WMDE as this week's IM and @Addshore and @Michael who touched the code recently. TASK DETAIL https://phabricator.wikimedia.org/T259744 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread Catrope
Catrope added a comment. The relevant code is $layout->appendContent( ...$this->getCaptionsContent( $entity->getLabels(), $this->getLanguagesOrderedByFallbackChain( $entity )

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

2020-08-05 Thread Catrope
Catrope added a comment. The relevant code is $layout->appendContent( ...$this->getCaptionsContent( $entity->getLabels(), $this->getLanguagesOrderedByFallbackChain( $entity )

[Wikidata-bugs] [Maniphest] T205094: Investigate and restructure SQL directory, and use new MediaWiki abstract schema change features

2020-08-05 Thread Izno
Izno added a comment. In T205094#6359681 , @Ladsgroup wrote: > Mediawiki core actually supports upgrading from basically any version. A couple of months ago I got a ticket that I broke upgrading from 1.10 (and people are really

[Wikidata-bugs] [Maniphest] T248457: Fully terminate use of Wikidata item descriptions as short article descriptions for English Wikipedia articles

2020-08-05 Thread Jonesey95
Jonesey95 added a comment. In T248457#6361568 , @Iniquity wrote: > In T248457#6361440 , @kaldari wrote: > >>> There is not about local consensus of enwiki, they can do whatever they

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

2020-08-05 Thread brennen
brennen added a parent task: T257971: 1.36.0-wmf.3 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T259744 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana,

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

2020-08-05 Thread brennen
brennen triaged this task as "Unbreak Now!" priority. brennen added a comment. Since we're already rolled back due to T259745 , I'm going to err on the side of marking this a blocker until triaged. TASK DETAIL

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread brennen
brennen added a parent task: T257971: 1.36.0-wmf.3 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T259745 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana,

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread brennen
brennen triaged this task as "Unbreak Now!" priority. TASK DETAIL https://phabricator.wikimedia.org/T259745 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikidata-Campsite, Commons, OOjs, User-brennen. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Error - `MediaWiki version:`

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

2020-08-05 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikidata-Campsite, MediaWiki-extensions-Scribunto, Commons, User-brennen. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION name=Error message

[Wikidata-bugs] [Maniphest] T259529: Check if the extension registeration changes would break wikibase docker on MW 1.35

2020-08-05 Thread Ladsgroup
Ladsgroup moved this task from Doing to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 4) board. Ladsgroup added a comment. https://github.com/wmde/wikibase-docker/pull/130 I tested locally and it works fine. I also checked and there no complicated loading of

[Wikidata-bugs] [Maniphest] T248457: Fully terminate use of Wikidata item descriptions as short article descriptions for English Wikipedia articles

2020-08-05 Thread Iniquity
Iniquity added a comment. In T248457#6363684 , @kaldari wrote: > @Iniquity - Your continued arguments here are inappropriate and disruptive. Please stop. We have already agreed to implement this change at the request of the English

[Wikidata-bugs] [Maniphest] T248457: Fully terminate use of Wikidata item descriptions as short article descriptions for English Wikipedia articles

2020-08-05 Thread kaldari
kaldari added a comment. @Iniquity - Your continued arguments here are inappropriate and disruptive. Please stop. We have already agreed to implement this change at the request of the English Wikipedia community. If you have concerns about the merits of this change, please take them to that

[Wikidata-bugs] [Maniphest] T259389: QuickStatements Docker image broken

2020-08-05 Thread Michael
Michael edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review; removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T259389 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc:

[Wikidata-bugs] [Maniphest] T258590: Decide on HTTP vs HTTPS for concept URIs on Commons

2020-08-05 Thread CBogen
CBogen added a comment. Note that the SD team work to change the Concept URIs in Commons is estimated to be a small. TASK DETAIL https://phabricator.wikimedia.org/T258590 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: CBogen Cc: dcausse, mxn,

[Wikidata-bugs] [Maniphest] T254675: Rename WPBSkinBlacklist

2020-08-05 Thread Edtadros
Edtadros updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T254675 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ovasileva, Edtadros Cc: Edtadros, Peter.ovchyn, Ammarpad, Reedy, Aklapper, abi_, Amire80, Ladsgroup,

[Wikidata-bugs] [Maniphest] T254675: Rename WPBSkinBlacklist

2020-08-05 Thread Edtadros
Edtadros moved this task from Needs QA in Prod to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2020-21-Q1) board. Edtadros reassigned this task from Edtadros to ovasileva. Edtadros added a comment. Test Result - Prod -- **Status:** ✅ PASS **Environment:**

[Wikidata-bugs] [Maniphest] T259529: Check if the extension registeration changes would break wikibase docker on MW 1.35

2020-08-05 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from Backlog to Doing on the Wikibase Extension Decoupling and Registration (Sprint 4) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T259529 WORKBOARD

[Wikidata-bugs] [Maniphest] T249654: Categorize different types of Wikidata re-use within Wikimedia projects

2020-08-05 Thread GoranSMilovanovic
GoranSMilovanovic added a comment. @Isaac Thank you for this analysis - really useful! TASK DETAIL https://phabricator.wikimedia.org/T249654 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Isaac, GoranSMilovanovic Cc: Akuckartz, calbon, Addshore,

[Wikidata-bugs] [Maniphest] T249039: Security Readiness Review For Wikidata Bridge

2020-08-05 Thread darthmon_wmde
darthmon_wmde added a comment. Hey @sbassett , heads up: I am accepting the risk and we programmed the deploy to production. We have already fixed some of the dev dependencies - by yesterday there were no

[Wikidata-bugs] [Maniphest] T72246: provide incremental JSON dumps for Wikidata

2020-08-05 Thread Ikkingjinnammebetinke
Ikkingjinnammebetinke added a comment. Hello - i am extremely interested in incremental JSON dumps. The dumps are now over 80 GB so it feels a bit weird having to process over 88 million records every two weeks just to get new and updated records. The amount of unneccessary downloaded GBs

[Wikidata-bugs] [Maniphest] T88258: Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration

2020-08-05 Thread hashar
hashar added a comment. Thank you @darthmon_wmde for the link to #wikibase_extension_decoupling_and_registration :] To everyone involved: antoine-approve

[Wikidata-bugs] [Maniphest] T232584: Step 1: Production deployment checklist

2020-08-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Data Bridge is now deployed on Test Wikipedia and other Test Wikidata clients. I set up a rudimentary rudimentary test page at testwiki:Data bridge . TASK DETAIL https://phabricator.wikimedia.org/T232584

[Wikidata-bugs] [Maniphest] T232584: Step 1: Production deployment checklist

2020-08-05 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2020-08-05T11:10:26Z] Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:595542|Enable Data Bridge on Test Wikidata clients (T232584 )]] (duration: 01m 20s) TASK

[Wikidata-bugs] [Maniphest] T232584: Step 1: Production deployment checklist

2020-08-05 Thread gerritbot
gerritbot added a comment. Change 595542 **merged** by jenkins-bot: [operations/mediawiki-config@master] Enable Data Bridge on Test Wikidata clients https://gerrit.wikimedia.org/r/595542 TASK DETAIL https://phabricator.wikimedia.org/T232584 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T258184: Call to undefined method Wikibase\Client\Hooks\OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemId()

2020-08-05 Thread gerritbot
gerritbot added a comment. Change 618516 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] Add test for buildProjectLinkSidebarFromItemId https://gerrit.wikimedia.org/r/618516 TASK DETAIL

[Wikidata-bugs] [Maniphest] T255657: Strange result in Wikidata query (full URLs given instead of identifiers)

2020-08-05 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T255657 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: dcausse, Nikki, Lucas_Werkmeister_WMDE, Aklapper, Epidosis, CBogen,

[Wikidata-bugs] [Maniphest] T255657: Strange result in Wikidata query (full URLs given instead of identifiers)

2020-08-05 Thread gerritbot
gerritbot added a comment. Change 618354 **merged** by jenkins-bot: [wikidata/query/rdf@master] Add debug code to investigate T255657 https://gerrit.wikimedia.org/r/618354 TASK DETAIL https://phabricator.wikimedia.org/T255657 EMAIL

[Wikidata-bugs] [Maniphest] T259529: Check if the extension registeration changes would break wikibase docker on MW 1.35

2020-08-05 Thread darthmon_wmde
darthmon_wmde moved this task from Backlog to Sprint 4 on the Wikibase Extension Decoupling and Registration board. darthmon_wmde edited projects, added Wikibase Extension Decoupling and Registration (Sprint 4); removed Wikibase Extension Decoupling and Registration. TASK DETAIL

[Wikidata-bugs] [Maniphest] T256058: Extract PHP package/library for "changes" as a "subtree" from the Wikibase monorepo

2020-08-05 Thread Ladsgroup
Ladsgroup closed subtask T258393: Change instances of MWException to be a plain Exception as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T256058 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Addshore,

[Wikidata-bugs] [Maniphest] T256058: Extract PHP package/library for "changes" as a "subtree" from the Wikibase monorepo

2020-08-05 Thread Ladsgroup
Ladsgroup closed subtask T258395: Make git play nice as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T256058 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Addshore, Lucas_Werkmeister_WMDE, Ladsgroup, ItamarWMDE, Tarrow,

[Wikidata-bugs] [Maniphest] T258395: Make git play nice

2020-08-05 Thread Ladsgroup
Ladsgroup moved this task from Verification to Done on the Wikibase Extension Decoupling and Registration (Sprint 4) board. Ladsgroup closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T258395 WORKBOARD https://phabricator.wikimedia.org/project/board/4916/ EMAIL

[Wikidata-bugs] [Maniphest] T258393: Change instances of MWException to be a plain Exception

2020-08-05 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup moved this task from Verification to Done on the Wikibase Extension Decoupling and Registration (Sprint 4) board. TASK DETAIL https://phabricator.wikimedia.org/T258393 WORKBOARD https://phabricator.wikimedia.org/project/board/4916/ EMAIL

[Wikidata-bugs] [Maniphest] T257437: Deploy Client to production using extension registration

2020-08-05 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup moved this task from Verification to Done on the Wikibase Extension Decoupling and Registration (Sprint 4) board. TASK DETAIL https://phabricator.wikimedia.org/T257437 WORKBOARD https://phabricator.wikimedia.org/project/board/4916/ EMAIL

[Wikidata-bugs] [Maniphest] T259115: Import wikidata ttl dumps in a hive table

2020-08-05 Thread gerritbot
gerritbot added a comment. Change 611249 **merged** by jenkins-bot: [wikidata/query/rdf@master] Add support for hive tables https://gerrit.wikimedia.org/r/611249 TASK DETAIL https://phabricator.wikimedia.org/T259115 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T231188: documentation for configuring sitelink section on Items for 3rd party installations

2020-08-05 Thread Johentsch
Johentsch added a parent task: T259691: Configuring sitelinks in Wikibase. TASK DETAIL https://phabricator.wikimedia.org/T231188 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: lucamauri, Johentsch Cc: danshick-wmde, lucamauri, Addshore, Aklapper,

[Wikidata-bugs] [Maniphest] T259691: Configuring sitelinks in Wikibase

2020-08-05 Thread Johentsch
Johentsch added a subtask: T231188: documentation for configuring sitelink section on Items for 3rd party installations. TASK DETAIL https://phabricator.wikimedia.org/T259691 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Johentsch Cc: Johentsch,

[Wikidata-bugs] [Maniphest] T251497: Adapt munging process for SDoC

2020-08-05 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T251497 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Jheald, dcausse, Aklapper, Gehel, CBogen, Akuckartz, darthmon_wmde,

[Wikidata-bugs] [Maniphest] T259389: QuickStatements Docker image broken

2020-08-05 Thread Johentsch
Johentsch added a comment. I fixed this error by changing the absolute path to a relative one on my fork of magnustools . However, an error with the OAuth login remained which I've reported on the

[Wikidata-bugs] [Maniphest] T259691: Configuring sitelinks in Wikibase

2020-08-05 Thread Johentsch
Johentsch added a comment. By the way, I also tried adding $wgWBClientSettings['repositories']['']['repoDatabase'] = 'my_wiki'; $wgWBClientSettings['repositories']['']['changesDatabase'] = 'my_wiki'; which broke the entire wiki with the error counterexample Fatal

[Wikidata-bugs] [Maniphest] T259691: Configuring sitelinks in Wikibase

2020-08-05 Thread Johentsch
Johentsch created this task. Johentsch added a project: Wikibase-Containers. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Momentarily we are in the process of adapting our new Wikibase to our needs which is a

[Wikidata-bugs] [Maniphest] T251497: Adapt munging process for SDoC

2020-08-05 Thread gerritbot
gerritbot added a comment. Change 616105 **merged** by jenkins-bot: [wikidata/query/rdf@master] Allow usage of sdc prefixes https://gerrit.wikimedia.org/r/616105 TASK DETAIL https://phabricator.wikimedia.org/T251497 EMAIL PREFERENCES