[Wikidata-bugs] [Maniphest] [Updated] T238199: SpecialFewestRevisions::reallyDoQuery takes more than 9h to run

2020-02-29 Thread Krinkle
Krinkle edited projects, added Wikimedia-database-error; removed Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T238199 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lea_Lacroix_WMDE, jcrespo, Addshore

[Wikidata-bugs] [Maniphest] [Commented On] T246288: Using Special:NewItem on wikidata.org sometimes times out

2020-02-29 Thread Krinkle
Krinkle added a comment. @Addshore Time outs often happen in unrelated code. It is not an indicating that the unrelated code is where the time was spent, it is merely where the timeout was finally reached. In this case, the hypothesis would be that the main code behind Wikibase's

[Wikidata-bugs] [Maniphest] [Declined] T246288: Using Special:NewItem on wikidata.org sometimes times out

2020-02-29 Thread Krinkle
Krinkle closed this task as "Declined". TASK DETAIL https://phabricator.wikimedia.org/T246288 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Addshore, Hogue, Aklapper, Adidsone1, darthmon_wmde, DannyS712

[Wikidata-bugs] [Maniphest] [Retitled] T246288: Using Special:NewItem on wikidata.org sometimes times out

2020-02-29 Thread Krinkle
Krinkle renamed this task from "Internal Error in Wikidata" to "Using Special:NewItem on wikidata.org sometimes times out". TASK DETAIL https://phabricator.wikimedia.org/T246288 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T243779: Fatal UnresolvedEntityRedirectException when viewing certain Wikidata item pages

2020-02-24 Thread Krinkle
Krinkle added a comment. In T243779#5839611 <https://phabricator.wikimedia.org/T243779#5839611>, @Addshore wrote: > I created an example of this happening on test https://test.wikidata.org/w/index.php?title=Q211856=no > […] > The page content displays the fact the pag

[Wikidata-bugs] [Maniphest] [Commented On] T227699: Creating a Commons gallery page incorrectly states "This entity does not exist."

2020-02-13 Thread Krinkle
Krinkle added a comment. The bug is currently obscured on Wikimedia Commons. It looks like someone has overidden the "This entity interface message for English to say "This page" instead. My interface langauge is `en-gb`, which the community has not worked around fo

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-13 Thread Krinkle
Krinkle added a comment. @WMDE-leszek If I understand correctly, the issue is that an unsafe value is passed to `BagOStuff->get()`. Specifically, a value that has not gone through `makeKey()` on the same BagOStuff. A BagOStuff implementation may have any number of restrictions on its ca

[Wikidata-bugs] [Maniphest] [Raised Priority] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-13 Thread Krinkle
Krinkle raised the priority of this task from "High" to "Unbreak Now!". Restricted Application added a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferen

[Wikidata-bugs] [Maniphest] [Updated] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-13 Thread Krinkle
Krinkle added a parent task: T233867: 1.35.0-wmf.19 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Addshore, WMDE-leszek, Jdforrester-WMF, Aklapper

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-13 Thread Krinkle
Krinkle added a comment. There is another variation of this error: url: /w/api.php?origin=*=wbsearchentities=json=50=0=en=en=…%3AP17=property InvalidArgumentException: Invalid code "internal_api_error_class@anonymous from line 121 of /srv/mediawiki/php-1.35.0-w

[Wikidata-bugs] [Maniphest] [Edited] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-13 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Addshore, WMDE-leszek, Jdforrester-WMF, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-13 Thread Krinkle
Krinkle set Request URL to https://commons.wikimedia.org/wiki/Category:Kingdom_of_Romania?uselang=%E2%A7%BCLang%E2%A7%BD. Krinkle changed Request ID from AXA7UBxCh3Uj6x1z44vf to XkV86QpAICsAACWu934B. Krinkle updated the task description. Krinkle edited Stack Trace. TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Updated] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-13 Thread Krinkle
Krinkle added subscribers: WMDE-leszek, Addshore, Krinkle. Krinkle added a comment. Looks similar to T244562 <https://phabricator.wikimedia.org/T244562>. \cc @Addshore @WMDE-leszek > name=Beta Cluster > /wiki/Special:RecentChanges class@anonymous /srv/mediawik

[Wikidata-bugs] [Maniphest] [Updated] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-13 Thread Krinkle
Krinkle removed a project: MediaWiki-Cache. TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jdforrester-WMF, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Updated] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-13 Thread Krinkle
Krinkle edited projects, added MediaWiki-extensions-WikibaseRepository; removed MediaWiki-extensions-WikibaseClient. TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jdforrester-WMF

[Wikidata-bugs] [Maniphest] [Updated] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-13 Thread Krinkle
Krinkle added a project: MediaWiki-extensions-WikibaseClient. TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jdforrester-WMF, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Changed Project Column] T243779: Fatal UnresolvedEntityRedirectException when viewing certain Wikidata item pages

2020-02-06 Thread Krinkle
Krinkle moved this task from Jan 2020 / 1.35-wmf.14 to Nov 2019 / 1.35.wmf.5+ on the Wikimedia-production-error board. Krinkle added a comment. Moving back to match T238014 <https://phabricator.wikimedia.org/T238014>. TASK DETAIL https://phabricator.wikimedia.org/T243779 WORKBOARD

[Wikidata-bugs] [Maniphest] [Updated] T243915: Performance audit of Wikibase/Wikidata, Jan 2020

2020-01-29 Thread Krinkle
Krinkle added a project: Performance-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T243915 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Krinkle Cc: Aklapper, Addshore, Ladsgroup, Iflorez, darthmon_wmde, alaa_wmde, Nandana

[Wikidata-bugs] [Maniphest] [Edited] T243779: Fatal UnresolvedEntityRedirectException when viewing certain Wikidata item pages

2020-01-28 Thread Krinkle
Krinkle updated the task description. Krinkle edited Stack Trace. TASK DETAIL https://phabricator.wikimedia.org/T243779 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: RolandUnger, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Retitled] T243779: Fatal UnresolvedEntityRedirectException when viewing certain Wikidata item pages

2020-01-28 Thread Krinkle
Krinkle renamed this task from "Wikidata internal error" to "Fatal UnresolvedEntityRedirectException when viewing certain Wikidata item pages". Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T243779 EMAIL PREFERENCES https://phabr

[Wikidata-bugs] [Maniphest] [Updated] T183993: Fix Warning: According to a SiteLinkLookup Q-item is linked when actually is unlinked or non-existent

2020-01-28 Thread Krinkle
Krinkle removed projects: MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T183993 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, Krinkle Cc: aaron, Catrope, daniel

[Wikidata-bugs] [Maniphest] [Commented On] T183993: Fix Warning: According to a SiteLinkLookup Q-item is linked when actually is unlinked or non-existent

2020-01-28 Thread Krinkle
Krinkle added a comment. Untagging as it's no longer a prod error. The issue has been ack'ed and turned into a debug log message. If a functional problem exists, the task will continue to track the work related to that but it no longer raises affected prod stability metrics and automated

[Wikidata-bugs] [Maniphest] [Retitled] T183993: Fix Warning: According to a SiteLinkLookup Q-item is linked when actually is unlinked or non-existent

2020-01-28 Thread Krinkle
Krinkle renamed this task from "Investigate & Fix "According to a SiteLinkLookup Q47013093 is linked to frwiki while it is not or it does not exist" in logs" to "Fix Warning: According to a SiteLinkLookup Q-item is linked when actually is unlinked or non-ex

[Wikidata-bugs] [Maniphest] [Commented On] T227699: Creating a Commons gallery page incorrectly states "This entity does not exist."

2020-01-28 Thread Krinkle
Krinkle added a comment. It's on the address in the task description for me, but that might be different for you given that "Foo" is no longer a normally non-existent gallery, it is now a formerly-existant gallery (someone created it, someone deleted it). Try anything

[Wikidata-bugs] [Maniphest] [Retitled] T242958: InvalidArgumentException: "property is not provided by source" (via wbeditentity API)

2020-01-23 Thread Krinkle
Krinkle renamed this task from "Entities of type: property is not provided by source: local , using wbeditentity" to "InvalidArgumentException: "property is not provided by source" (via wbeditentity API)". Krinkle edited Stack Trace. TASK DETAIL https://pha

[Wikidata-bugs] [Maniphest] [Updated] T243415: Multiple repo/includes/Rdf errors, when wmgUseEntitySourceBasedFederation true on Wikidata.org

2020-01-23 Thread Krinkle
Krinkle removed a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21). TASK DETAIL https://phabricator.wikimedia.org/T243415 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Ladsgroup, WMDE-leszek, Aklapper, Michael, Addshore, Iflorez

[Wikidata-bugs] [Maniphest] [Created] T242392: Wikibase edit summary should display the value of the claim added

2020-01-09 Thread Krinkle
Krinkle created this task. Krinkle added projects: Machine vision, MediaWiki-extensions-WikibaseRepository, Commons. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION I've made a change to a file on Commons <ht

[Wikidata-bugs] [Maniphest] [Commented On] T240884: Standalone service to evaluate user-provided regular expressions

2020-01-08 Thread Krinkle
Krinkle added a comment. Based on today's TechCom meeting I've updated the task description to better separate the three proposals, and added a **Requirements** section. I've also fleshed out the re2-based solution description and clarified that gRPC is not itself a critical part of any

[Wikidata-bugs] [Maniphest] [Edited] T240884: Standalone service to evaluate user-provided regular expressions

2020-01-08 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T240884 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Agabi10, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, darthmon_wmde, DannyS712, Nandana

[Wikidata-bugs] [Maniphest] [Retitled] T240884: Standalone service to evaluate user-provided regular expressions

2020-01-08 Thread Krinkle
Krinkle renamed this task from "Stand-alone service to evaluate user-provided regular expressions" to "Standalone service to evaluate user-provided regular expressions". TASK DETAIL https://phabricator.wikimedia.org/T240884 EMAIL PREFERENCES https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Closed] T95116: Fix Doxygen "Warning: Found unknown command"

2020-01-07 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle claimed this task. Krinkle added a comment. This task is for mediaiwiki/core where I believe all of these have been fixed now. If there are any particularly challenging ones left, I suggest creating a separate task for that.

[Wikidata-bugs] [Maniphest] [Retitled] T240694: "OutOfRangeException: Latitude needs to be between -360 and 360" from action=wbparsevalue API

2019-12-17 Thread Krinkle
Krinkle renamed this task from "Exception when Latitude outside -360 and 360 is given to wbparsevalue" to ""OutOfRangeException: Latitude needs to be between -360 and 360" from action=wbparsevalue API". Krinkle updated the task description. TASK DETAIL htt

[Wikidata-bugs] [Maniphest] [Triaged] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

2019-12-17 Thread Krinkle
Krinkle moved this task from Untriaged to Dec 2019 / 1.35.wmf.10+ on the Wikimedia-production-error board. Krinkle triaged this task as "Medium" priority. TASK DETAIL https://phabricator.wikimedia.org/T240083 WORKBOARD https://phabricator.wikimedia.org/project/board/1055/ EMAIL P

[Wikidata-bugs] [Maniphest] [Commented On] T151789: Wikibase\\TermSqlIndex::deleteTerms: Deadlock found when trying to get lock; try restarting transaction

2019-12-17 Thread Krinkle
Krinkle added a comment. Seen 3,500 times (evenly spread out throughout the month). Logstash: https://logstash.wikimedia.org/goto/f12480d76fe5fa011e52110a94927d3e. @Ladsgroup I don't know if is the same issue or not. It does have the same stack trace from DataUpdateAdapter

[Wikidata-bugs] [Maniphest] [Commented On] T229982: SuggesterParamsParser: provide either entity-id parameter 'entity' or a list of properties 'properties'

2019-12-17 Thread Krinkle
Krinkle added a comment. Still reproducible. Adds noise to fatal error log. TASK DETAIL https://phabricator.wikimedia.org/T229982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, brennen, darthmon_wmde, Nandana, Lahi

[Wikidata-bugs] [Maniphest] [Commented On] T237067: "PHP Notice: A non well formed numeric value encountered" from DmsCoordinateParser.php in API action=wbparsevalue [Story Points 5]

2019-12-17 Thread Krinkle
Krinkle added a comment. In case there is confusion - the error reported in this case is logged by the PHP engine, not by our code. It comes from the following statement: Source: DmsCoordinateParser.php:L184 <https://github.com/DataValues/Geo/blob/4.2.0/src/Pars

[Wikidata-bugs] [Maniphest] [Updated] T238154: Clean removed wikibase config variables from production

2019-12-15 Thread Krinkle
Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation process). TASK DETAIL https://phabricator.wikimedia.org/T238154 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, darthmon_wmde, WMDE-leszek

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS)

2019-12-07 Thread Krinkle
Krinkle added subscribers: Nikerabbit, Addshore. Krinkle added a comment. @Nikerabbit @Addshore When your respective teams are investigating this and if you need help with how the constraint works and how it is typically dealt with, you'll probably want to tag #core-platform-team <ht

[Wikidata-bugs] [Maniphest] [Created] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS)

2019-12-07 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikimedia-production-error, UniversalLanguageSelector, MediaWiki-extensions-WikibaseClient, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION

[Wikidata-bugs] [Maniphest] [Commented On] T239594: Unexpected general module "jquery.ui.core.styles" in styles queue.

2019-12-04 Thread Krinkle
Krinkle added a comment. Deployments happen once a week through the train. This is expected to roll out later this week, unless backported sooner which I proposed with the above cherry pick, but not sure it'll happen. Is this a volume risk currently? In terms of MW functionality the message

[Wikidata-bugs] [Maniphest] [Updated] T238014: Viewing history version of double redirect results in UnresolvedEntityRedirectException

2019-12-03 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T238014 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, Bugreporter, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Updated] T238014: Viewing history version of double redirect results in UnresolvedEntityRedirectException

2019-12-03 Thread Krinkle
Krinkle added a comment. Likely related to T228293: [4h invstigation] RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job) <https://phabricator.wikimedia.org/T228293>. `RevisionedUnresolvedRedirectException` is a su

[Wikidata-bugs] [Maniphest] [Updated] T239192: WMFTimeoutException in Wikidata recentchanges

2019-12-03 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T239192 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Umherirrender, DannyS712, Aklapper, darthmon_wmde, Nandana, kostajh, Jony, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Edited] T239192: WMFTimeoutException in Wikidata recentchanges

2019-12-03 Thread Krinkle
Krinkle updated the task description. Krinkle edited Stack Trace. TASK DETAIL https://phabricator.wikimedia.org/T239192 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Umherirrender, DannyS712, Aklapper, darthmon_wmde, Nandana, kostajh

[Wikidata-bugs] [Maniphest] [Updated] T384: RfC: Dependency Injection for MediaWiki core

2019-12-03 Thread Krinkle
Krinkle edited projects, added TechCom-RFC (TechCom-Approved); removed TechCom-RFC. TASK DETAIL https://phabricator.wikimedia.org/T384 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, Krinkle Cc: MGChecker, Osnard, He7d3r, ArielGlenn

[Wikidata-bugs] [Maniphest] [Updated] T239594: Unexpected general module "jquery.ui.core.styles" in styles queue.

2019-12-03 Thread Krinkle
Krinkle added a project: Performance-Team. TASK DETAIL https://phabricator.wikimedia.org/T239594 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Krinkle, jijiki, darthmon_wmde, DannyS712, Nandana, Imarlier, Lahi, Gq86, Pablo

[Wikidata-bugs] [Maniphest] [Closed] T239594: Unexpected general module "jquery.ui.core.styles" in styles queue.

2019-12-03 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle edited projects, added MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error; removed Wikimedia-General-or-Unknown, MediaWiki-General, JavaScript. Krinkle claimed this task. Krinkle added a comment. In T2196

[Wikidata-bugs] [Maniphest] [Retitled] T237723: PHP Warning: [data-update-failed]: Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted

2019-11-23 Thread Krinkle
Krinkle renamed this task from "PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted into master. This should never happen, except for an edge

[Wikidata-bugs] [Maniphest] [Retitled] T237667: PHP Warning: preg_match(): Unknown modifier 'p' (from MwTimeIsoParser.php, API action=wbparsevalue)

2019-11-07 Thread Krinkle
Krinkle renamed this task from "PHP Warning: preg_match(): Unknown modifier 'p'" to "PHP Warning: preg_match(): Unknown modifier 'p' (from MwTimeIsoParser.php, API action=wbparsevalue)". Krinkle changed Request URL from /w/api.php?action=wbparsevalue=json=time=%1F1964=%7B%

[Wikidata-bugs] [Maniphest] [Commented On] T237667: PHP Warning: preg_match(): Unknown modifier 'p'

2019-11-07 Thread Krinkle
Krinkle added a comment. Fixed to restore full paths and url (was the fix for that in Phatality not yet deployed?). TASK DETAIL https://phabricator.wikimedia.org/T237667 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle

[Wikidata-bugs] [Maniphest] [Edited] T237667: PHP Warning: preg_match(): Unknown modifier 'p'

2019-11-07 Thread Krinkle
Krinkle updated the task description. Krinkle edited Stack Trace. TASK DETAIL https://phabricator.wikimedia.org/T237667 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, mmodell, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Merged] T237173: InvalidArgumentException breaking Commons "undo" functionality

2019-11-07 Thread Krinkle
Krinkle closed this task as a duplicate of T236320: Internal error while undoing file captions: Unsaved revision passed. TASK DETAIL https://phabricator.wikimedia.org/T237173 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krenair

[Wikidata-bugs] [Maniphest] [Commented On] T237067: "PHP Notice: A non well formed numeric value encountered" from DmsCoordinateParser.php in API action=wbparsevalue

2019-11-07 Thread Krinkle
Krinkle added a comment. Re-classifying from mediawiki-extensions-GeoData to mediawiki-extensions-WikibaseRepo. While it contains "Geo"-something, this specific error comes from the Wikibase code. TASK DETAIL https://phabricator.wikimedia.org/T237067 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] [Updated] T237067: "PHP Notice: A non well formed numeric value encountered" from DmsCoordinateParser.php in API action=wbparsevalue

2019-11-07 Thread Krinkle
Krinkle edited projects, added MediaWiki-extensions-WikibaseRepository, Wikidata, Wikidata-Campsite; removed GeoData, Discovery-Search. TASK DETAIL https://phabricator.wikimedia.org/T237067 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Updated] T236993: Sub-optimal transaction on DB(s) [10.64.48.172 (wikidatawiki) (TRX#7105a1)]: 0

2019-11-07 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error. Krinkle added a comment. (not an application error) TASK DETAIL https://phabricator.wikimedia.org/T236993 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, alaa_wmde

[Wikidata-bugs] [Maniphest] [Edited] T236150: Write an RFC describing in detail possible solutions for checking user-provided regexes in constraints

2019-11-05 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T236150 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Lucas_Werkmeister_WMDE, Joe, GWicke, daniel, tstarling, Smalyshev, Anomie, Nikerabbit

[Wikidata-bugs] [Maniphest] [Updated] T178806: Wikibase: Batch HTMLCacheUpdateJobs across changes

2019-10-31 Thread Krinkle
Krinkle added a project: Performance-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T178806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Addshore, hoo, Ladsgroup, Joe, elukey, Aklapper, daniel, darthmon_wmde, DannyS712

[Wikidata-bugs] [Maniphest] [Closed] T236372: Too few arguments to function Wikibase\DataAccess\SingleEntitySourceServices::__construct(), 9 passed in /extensions/Wikibase/repo/includes/WikibaseRepo.p

2019-10-24 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T236372 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: hashar, WMDE-leszek, matthiasmullie, Liuxinyu970226

[Wikidata-bugs] [Maniphest] [Closed] T236370: Call to undefined method Wikibase\Lib\EntityTypeDefinitions::getPrefetchingTermLookupCallbacks()

2019-10-24 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T236370 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: WMDE-leszek, matthiasmullie, Liuxinyu970226, Aklapper, Lar

[Wikidata-bugs] [Maniphest] [Updated] T236424: "Error: Call to a member function getTargetId() on null" from WikiPageEntityRevisionLookup.php

2019-10-24 Thread Krinkle
Krinkle changed Request URL from /w/api.php to https://commons.wikimedia.org/w/api.php. TASK DETAIL https://phabricator.wikimedia.org/T236424 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, darthmon_wmde, DannyS712

[Wikidata-bugs] [Maniphest] [Created] T236424: "Error: Call to a member function getTargetId() on null" from WikiPageEntityRevisionLookup.php

2019-10-24 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikimedia-production-error, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - `MediaWiki version:` **`1.35.0-wmf.3

[Wikidata-bugs] [Maniphest] [Changed Project Column] T231264: Lexeme tests produce errors on merge

2019-10-24 Thread Krinkle
Krinkle moved this task from Untriaged to Resolved on the Wikimedia-production-error (Shared Build Failure) board. Krinkle added a comment. Is this still an issue? TASK DETAIL https://phabricator.wikimedia.org/T231264 WORKBOARD https://phabricator.wikimedia.org/project/board/3298

[Wikidata-bugs] [Maniphest] [Updated] T231264: Lexeme tests produce errors on merge

2019-10-24 Thread Krinkle
Krinkle changed the subtype of this task from "Production Error" to "Task". TASK DETAIL https://phabricator.wikimedia.org/T231264 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Smalyshev, darthmon_wmde, DannyS712,

[Wikidata-bugs] [Maniphest] [Closed] T224030: Fatal when saving "Undo" edit on merged Wikidata item

2019-10-19 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle added a comment. In WMF Logstash the last 30 days contain no exception messages for `PatcherException`. I also checked the original user scenario from the task description. While it does still fail, it now fails with a user-faci

[Wikidata-bugs] [Maniphest] [Updated] T231799: LuaWikibaseEntityLibraryTest: CI failing en masse

2019-10-18 Thread Krinkle
Krinkle added a project: Wikimedia-production-error (Shared Build Failure). Krinkle added a comment. As I understand it, the problematic core commit has been reverted and Wikibase is unblocked. The commit in question (https://gerrit.wikimedia.org/r/533729), while nice, does not appear

[Wikidata-bugs] [Maniphest] [Updated] T229982: SuggesterParamsParser: provide either entity-id parameter 'entity' or a list of properties 'properties'

2019-10-17 Thread Krinkle
Krinkle edited projects, added Wikidata-Campsite; removed MediaWiki-REST-API. TASK DETAIL https://phabricator.wikimedia.org/T229982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, brennen, darthmon_wmde, DannyS712, Nandana, Lahi

[Wikidata-bugs] [Maniphest] [Edited] T235724: Remove old pcache metric compat from ParserCache.php

2019-10-16 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T235724 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: alaa_wmde, Ladsgroup, Krinkle, Addshore, Aklapper, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Created] T235724: Remove old pcache metric compat from ParserCache.php

2019-10-16 Thread Krinkle
Krinkle created this task. Krinkle added projects: Technical-Debt, Wikidata, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Follow-up from https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/486323/9/includes/parser/ParserCache.php. Transferring from

[Wikidata-bugs] [Maniphest] [Changed Project Column] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-16 Thread Krinkle
Krinkle moved this task from Peer Review to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Krinkle added a comment. 10 days have passed. TASK DETAIL https://phabricator.wikimedia.org/T229280 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL

[Wikidata-bugs] [Maniphest] [Unblock] T106523: Issues with srcset with browsers that do not properly support it

2019-10-14 Thread Krinkle
Krinkle closed subtask T111542: Update jquery.hidpi.js to support width/height specs as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: brion, gerritbot, Jdlrobson, Sumit

[Wikidata-bugs] [Maniphest] [Closed] T213349: wbgetentities BadMethodCallException when mediainfo entity is for a redirect page

2019-10-12 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle added a comment. Appears to have resolved itself. TASK DETAIL https://phabricator.wikimedia.org/T213349 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] [Updated] T213349: wbgetentities BadMethodCallException when mediainfo entity is for a redirect page

2019-10-12 Thread Krinkle
Krinkle added a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T213349 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jdforrester-WMF, Addshore, Aklapper, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T233293: wikibase/javascript-api (wikibase-api) should use datatype instead of deprecated parameter parser

2019-10-12 Thread Krinkle
Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation). TASK DETAIL https://phabricator.wikimedia.org/T233293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Tobi_WMDE_SW, WMDE-Fisch, Aklapper, thiemowmde

[Wikidata-bugs] [Maniphest] [Edited] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-12 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T229280 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, Mholloway

[Wikidata-bugs] [Maniphest] [Edited] T93273: UnresolvedRedirectException "Unresolved redirect to Q…" from WikiPageEntityRevisionLookup.php

2019-10-12 Thread Krinkle
Krinkle updated the task description. Krinkle edited Stack Trace. TASK DETAIL https://phabricator.wikimedia.org/T93273 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: gerritbot, PokestarFan, Krinkle, mmodell, Addshore, Bene, hoo

[Wikidata-bugs] [Maniphest] [Updated] T93273: UnresolvedRedirectException "Unresolved redirect to Q…" from WikiPageEntityRevisionLookup.php

2019-10-12 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T93273 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: gerritbot, PokestarFan, Krinkle, mmodell, Addshore, Bene, hoo, JanZerebecki, thiemowmde

[Wikidata-bugs] [Maniphest] [Retitled] T93273: UnresolvedRedirectException "Unresolved redirect to Q…" from WikiPageEntityRevisionLookup.php

2019-10-12 Thread Krinkle
Krinkle renamed this task from "[Bug] UnresolvedRedirectException from line 87 of WikiPageEntityRevisionLookup.php" to "UnresolvedRedirectException "Unresolved redirect to Q…" from WikiPageEntityRevisionLookup.php". TASK DETAIL https://phabricator.wikimedia

[Wikidata-bugs] [Maniphest] [Updated] T235317: Data update exception (Database::makeList: empty input for field wbxl_text_id) from Wikibase\Repo\Content\DataUpdateAdapter

2019-10-12 Thread Krinkle
Krinkle added a comment. The same class is also emitting a different error in production: - T233349: A data update callback triggered a fail-safe exception in DataUpdateAdapter <https://phabricator.wikimedia.org/T233349> TASK DETAIL https://phabricator.wikimedia.org/T235317

[Wikidata-bugs] [Maniphest] [Updated] T233349: A data update callback triggered a fail-safe exception in DataUpdateAdapter

2019-10-12 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. Krinkle added a comment. The same class is also emitting a different error in production: - T235317: Data update exception (Database::makeList: empty input for field wbxl_text_id) from Wikibase\Repo\Content\DataUpdateAdapter <ht

[Wikidata-bugs] [Maniphest] [Commented On] T235317: Data update exception (Database::makeList: empty input for field wbxl_text_id) from Wikibase\Repo\Content\DataUpdateAdapter

2019-10-11 Thread Krinkle
Krinkle added a comment. Reported over 1,200 times in the last few weeks in Logstash. Seems to have gotten more frequent in the last 1 week. F30638749: Screenshot 2019-10-12 at 06.15.41.png <https://phabricator.wikimedia.org/F30638749> TASK DETAIL https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Created] T235317: Data update exception (Database::makeList: empty input for field wbxl_text_id) from Wikibase\Repo\Content\DataUpdateAdapter

2019-10-11 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikimedia-production-error, MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Error - `MediaWiki

[Wikidata-bugs] [Maniphest] [Changed Project Column] T151789: Wikibase\\TermSqlIndex::deleteTerms: Deadlock found when trying to get lock; try restarting transaction

2019-10-11 Thread Krinkle
Krinkle moved this task from Found longer ago to Since Oct 2019 / 1.35.wmf1– on the Wikimedia-production-error board. Krinkle added a comment. Seems to have come back, now happening a few hundred times a day as of 1.35.0-wmf.1 TASK DETAIL https://phabricator.wikimedia.org/T151789

[Wikidata-bugs] [Maniphest] [Changed Status] T151789: Wikibase\\TermSqlIndex::deleteTerms: Deadlock found when trying to get lock; try restarting transaction

2019-10-11 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. Krinkle raised the priority of this task from "Normal" to "Needs Triage". Krinkle changed the task status from "Stalled" to "Open". TASK DETAIL https://phabricator.wikimedia.org/T151789 EMAIL PREFERENCES ht

[Wikidata-bugs] [Maniphest] [Updated] T151789: Wikibase\\TermSqlIndex::deleteTerms: Deadlock found when trying to get lock; try restarting transaction

2019-10-11 Thread Krinkle
Krinkle set Request URL to /w/api.php. Krinkle set Request ID to XaFW6QpAEMYAALXzYP0AAACN. Krinkle updated the task description. Krinkle edited Stack Trace. TASK DETAIL https://phabricator.wikimedia.org/T151789 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Merged] T233847: PHP Warning: [data-update-failed]: A data update callback triggered an exception

2019-10-11 Thread Krinkle
Krinkle closed this task as a duplicate of T151789: Wikibase\\TermSqlIndex::deleteTerms: Deadlock found when trying to get lock; try restarting transaction. TASK DETAIL https://phabricator.wikimedia.org/T233847 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Blocker] T86530: Replace wb_terms table with more specialized mechanisms for terms (tracking)

2019-10-11 Thread Krinkle
Krinkle changed the status of subtask T151789: Wikibase\\TermSqlIndex::deleteTerms: Deadlock found when trying to get lock; try restarting transaction from Stalled to Open. TASK DETAIL https://phabricator.wikimedia.org/T86530 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Updated] T151789: Wikibase\\TermSqlIndex::deleteTerms: Deadlock found when trying to get lock; try restarting transaction

2019-10-11 Thread Krinkle
Krinkle merged a task: T233847: PHP Warning: [data-update-failed]: A data update callback triggered an exception. Krinkle added subscribers: mmodell, Michael, alaa_wmde. TASK DETAIL https://phabricator.wikimedia.org/T151789 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

2019-10-08 Thread Krinkle
Krinkle added a comment. @Anomie Ah do you mean php-sqlite3 is not just a driver/client (like for mysql) but actual contains an embedded copy of the lib? If so then yeah, it should indeed behave better. I thought maybe they're separate in which case it's mildly more forgivable to return

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

2019-10-08 Thread Krinkle
Krinkle added a comment. In T234795#5554738 <https://phabricator.wikimedia.org/T234795#5554738>, @WMDE-leszek wrote: > I hacked up DatabaseSqlite to var dump the result of getServerVersion in upsert method calls (https://github.com/manicki/mediawiki/tree/travis-sql

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

2019-10-07 Thread Krinkle
Krinkle added a comment. @Ladsgroup Can you find out which version of sqlite it uses? https://packages.ubuntu.com/bionic/sqlite3 says it comes with 3.22.0, but not sure if it actually uses that plainly on Travis. @Aaron Can you check if this is using the old or new code? If using

[Wikidata-bugs] [Maniphest] [Updated] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

2019-10-07 Thread Krinkle
Krinkle added a project: Performance-Team. TASK DETAIL https://phabricator.wikimedia.org/T234795 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Anomie, Krinkle, aaron, Ladsgroup, Aklapper, WMDE-leszek, Iflorez, darthmon_wmde, alaa_wmde

[Wikidata-bugs] [Maniphest] [Updated] T228343: Huge delay for RecentChanges in test.wikidata

2019-10-07 Thread Krinkle
Krinkle removed a project: HHVM. TASK DETAIL https://phabricator.wikimedia.org/T228343 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Joe, Pchelolo, Addshore, Bugreporter, Aklapper, Smalyshev, darthmon_wmde, DannyS712, Nandana, Lahi

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-07 Thread Krinkle
Krinkle added a comment. @Cparle @Mholloway Looks like next step is CR for https://gerrit.wikimedia.org/r/534536. Is this something SDC can/should review internally, or is it blocked on WMDE? Looks like the expectation was for SDC to review internally but delayed due to offsites. Perhaps

[Wikidata-bugs] [Maniphest] [Retitled] T110022: Move HTTP-related code from MW to its own library

2019-10-07 Thread Krinkle
Krinkle renamed this task from "Move HTTP-related functions/classes from MW to its own library" to "Move HTTP-related code from MW to its own library". TASK DETAIL https://phabricator.wikimedia.org/T110022 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/pa

[Wikidata-bugs] [Maniphest] [Retitled] T110022: Move HTTP-related functions/classes from MW to its own library

2019-10-07 Thread Krinkle
Krinkle renamed this task from "Create a library with HTTP related functions/code" to "Move HTTP-related functions/classes from MW to its own library". TASK DETAIL https://phabricator.wikimedia.org/T110022 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/pa

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T234847: Performance review for Wikidata Bridge

2019-10-07 Thread Krinkle
Krinkle added a subscriber: Lydia_Pintscher. Krinkle added a comment. @Lydia_Pintscher We're pretty limited in capacity so the earlier it is scheduled, the earlier it might happen. Let us know when it is in a state that it is ready for perf review. At that time, it would also be good to have

[Wikidata-bugs] [Maniphest] [Created] T234847: Performance review for Wikidata Bridge

2019-10-07 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikidata-Bridge, Wikidata, Performance-Team. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION I'm not exactly sure that this is yet or what the deployment roadmap is. Creating this as placeholder task for its performance

[Wikidata-bugs] [Maniphest] [Commented On] T213426: Deprecate jquery.throttle-debounce in favour of mw.util.debounce or OO.ui.debounce/throttle

2019-10-01 Thread Krinkle
Krinkle added a comment. @Jdlrobson I can elaborate N weeks from now, but T213426#5477587 <https://phabricator.wikimedia.org/T213426#5477587> might help get you on the way. TASK DETAIL https://phabricator.wikimedia.org/T213426 EMAIL PREFERENCES https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-30 Thread Krinkle
Krinkle added a comment. Still reproducible at the example URL as well. TASK DETAIL https://phabricator.wikimedia.org/T229280 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Updated] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-30 Thread Krinkle
Krinkle set Request URL to https://commons.wikimedia.org/w/index.php?title=File:Buddha_with_Naga_(snake).jpg=no. Krinkle removed a project: Structured-Data-Team-Current-Work. Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T229280 EMAIL PREFERENCES https

<    1   2   3   4   5   6   7   8   9   10   >