Pchelolo added a comment.
ok. I guess I agree. let's squash them together.
TASK DETAIL
https://phabricator.wikimedia.org/T295357
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pchelolo
Cc: Michael, Aklapper, Ladsgroup, daniel, Pchelolo
Pchelolo added a comment.
Hm... Indeed you're right, it did remove it by making the content
uncacheable. But it was a bad thing.
I still stand firm in my believe that it's a problem with tests, not with the
patch :)
What's the possible fix on the server side? We can detect
Pchelolo added a comment.
'disablelimitreport' is a different thing 'saved in parser cache' comment.
These are 2 completely different comments from different systems. The reason
'saved in parser cache' started showing up is because we can not save more
things in parser cache, and I guess
Pchelolo added a comment.
> But isn’t this something that should be avoided?
The update to the tests made it ready for reordering of the 2 comments in
HTML. LimitReport comment now comes after the saved in parser cache comment,
not before.
I don't think reordering 2 comme
Pchelolo added a comment.
A different approach could be to implement MultiContentSave hook instead of
EditFilterMergedContent hook. MultiSaveComplete already gives us a
RenderedRevision that should be reused for page saving. Additional benefit - we
can replace multiple hook handlers
Pchelolo added a parent task: T292300: Tracking: duplicate parses.
TASK DETAIL
https://phabricator.wikimedia.org/T288639
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup, Pchelolo
Cc: WMDE-leszek, daniel, toan, Michael, Addshore
Pchelolo closed this task as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T290496
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Vlad.shapik, Pchelolo
Cc: xSavitar, Pchelolo, daniel, Aklapper, Vlad.shapik, Invadibot, maantieta
Pchelolo reassigned this task from Pchelolo to tchin.
TASK DETAIL
https://phabricator.wikimedia.org/T252934
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: tchin, Pchelolo
Cc: Pchelolo, Majavah, DannyS712, Aklapper, codebug, Invadibot, OTichonova
Pchelolo closed subtask T258485: On enwiki, action API requests with
prop=description should only return the local description as
Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T259617
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
Pchelolo added a comment.
> A better candidate for changing something is probably
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/677299. @Pchelolo is looking
into it.
This one is a partial revert of a previously added optimization that was not
needed, and is fixing PoolCoun
Pchelolo added a subscriber: daniel.
Pchelolo added a comment.
cc @Daniel as original author.
TASK DETAIL
https://phabricator.wikimedia.org/T279063
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pchelolo
Cc: daniel, Pchelolo
Pchelolo added a comment.
I think we can go even further and just eliminate the class entirely. It
provides no value - it has 3 lines of very simple code in it, no other classes
seem to have methods typed with "DBConnectionBase" - zero value.
For marking value objects th
Pchelolo claimed this task.
Pchelolo edited projects, added Platform Team Workboards (MW Expedition);
removed MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review,
MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Platform Team Workboards (External
Code Reviews).
Pchelolo updated the task
Pchelolo closed this task as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T275661
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE, Pchelolo
Cc: WMDE-leszek, Aklapper, Pchelolo, daniel, Lucas_Werkmeister_W
Pchelolo triaged this task as "High" priority.
TASK DETAIL
https://phabricator.wikimedia.org/T275661
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE, Pchelolo
Cc: WMDE-leszek, Aklapper, Pchelolo, daniel, Lucas_Werkme
Pchelolo added a project: Platform Team Workboards (MW Expedition).
Pchelolo added a comment.
Hm... This patch indeed touches that test, the idea there is to decrease the
amount of MWServices initialized in dataProvider - that's executed before the
tests are setup, so that's no good..
TASK
Pchelolo added a comment.
Currently it's not. It's possible to add a feature like that, but the API is
exposed via the API Gateway currently which is all OAuth based.
TASK DETAIL
https://phabricator.wikimedia.org/T259625
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
Pchelolo reassigned this task from Pchelolo to eprodromou.
Pchelolo moved this task from Documentation to PM Sign-off on the Platform Team
Workboards (Green) board.
Pchelolo added a comment.
I don't think there's anything to document here.
TASK DETAIL
https://phabricator.wikimedia.org
Pchelolo added a comment.
Now wmf.11 was redeployed, so now it should be ok to test.
TASK DETAIL
https://phabricator.wikimedia.org/T263493
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pchelolo
Cc: Aklapper, daniel, Pchelolo, kaldari
Pchelolo moved this task from Ready to Deploy to User Story Review on the
Platform Team Workboards (Green) board.
Pchelolo reassigned this task from Pchelolo to eprodromou.
Pchelolo added a comment.
This is deployed and ready.
TASK DETAIL
https://phabricator.wikimedia.org/T259622
Pchelolo moved this task from Ready to Deploy to User Story Review on the
Platform Team Workboards (Green) board.
Pchelolo reassigned this task from Pchelolo to eprodromou.
Pchelolo added a comment.
This is deployed and ready.
TASK DETAIL
https://phabricator.wikimedia.org/T263493
Pchelolo reassigned this task from Pchelolo to eprodromou.
Pchelolo moved this task from Blocked to User Story Review on the Platform Team
Workboards (Green) board.
Pchelolo added a comment.
See T259625#6502392 <https://phabricator.wikimedia.org/T259625#6502392> for
some handy CURLs
Pchelolo reassigned this task from Pchelolo to eprodromou.
Pchelolo added a comment.
Done:
enwiki:
curl
https://api.wikimedia.org/core/v1/wikipedia/en/page/San_Francisco/description
{"description":"Consolidated city-county in California, US"}
For lang-
Pchelolo moved this task from Blocked to User Story Review on the Platform Team
Workboards (Green) board.
Pchelolo reassigned this task from Pchelolo to eprodromou.
Pchelolo added a comment.
Done:
curl -XPUT -H 'Content-Type: application/json' -H 'Authorization: Bearer
$TOKEN' -H
Pchelolo claimed this task.
Pchelolo moved this task from Backlog to Waiting for Review on the Platform
Team Workboards (Green) board.
Pchelolo added a comment.
The patch I made before will cover this.
TASK DETAIL
https://phabricator.wikimedia.org/T263493
WORKBOARD
https
Pchelolo moved this task from Tasks Ready for Estimation to Doing on the
Platform Team Workboards (Green) board.
Pchelolo claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T259622
WORKBOARD
https://phabricator.wikimedia.org/project/board/4180/
EMAIL PREFERENCES
https
Pchelolo added a comment.
Setting the description
<https://www.wikidata.org/w/api.php?action=help=wbsetdescription> in
Wikidata requires a language parameter. We can infer the language from the
domain, however for wikis with language variants the user should be specifying
the vari
Pchelolo added a comment.
What about language variants? I think we will support language variants via
`accept-language` header.
TASK DETAIL
https://phabricator.wikimedia.org/T259624
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pchelolo
Cc
Pchelolo moved this task from Tasks Ready for Estimation to Doing on the
Platform Team Workboards (Green) board.
Pchelolo claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T259626
WORKBOARD
https://phabricator.wikimedia.org/project/board/4180/
EMAIL PREFERENCES
https
Pchelolo moved this task from Tasks Ready for Estimation to Doing on the
Platform Team Workboards (Green) board.
Pchelolo claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T259625
WORKBOARD
https://phabricator.wikimedia.org/project/board/4180/
EMAIL PREFERENCES
https
Pchelolo claimed this task.
Pchelolo moved this task from Tasks Ready for Estimation to Doing on the
Platform Team Workboards (Green) board.
TASK DETAIL
https://phabricator.wikimedia.org/T259624
WORKBOARD
https://phabricator.wikimedia.org/project/board/4180/
EMAIL PREFERENCES
https
Pchelolo set the point value for this task to "5".
TASK DETAIL
https://phabricator.wikimedia.org/T259617
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: eprodromou, Pchelolo
Cc: kaldari, Pchelolo, daniel, Aklapper, eprodromou, Naike,
Pchelolo set the point value for this task to "1".
TASK DETAIL
https://phabricator.wikimedia.org/T259626
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: eprodromou, Pchelolo
Cc: Aklapper, eprodromou, Naike, Akuckartz, apaskulin, dar
Pchelolo set the point value for this task to "1".
TASK DETAIL
https://phabricator.wikimedia.org/T259625
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: eprodromou, Pchelolo
Cc: Pchelolo, Aklapper, eprodromou, Naike, Akuckartz,
Pchelolo set the point value for this task to "1".
TASK DETAIL
https://phabricator.wikimedia.org/T259624
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: eprodromou, Pchelolo
Cc: Aklapper, eprodromou, Naike, Akuckartz, apaskulin, dar
Pchelolo added a comment.
Perhaps the implementation of this API should go into an extension as well,
like `HorriblyHackyWikimediaFeatures` extension? So that we do not pollute the
core with this until we have proper backend support for page descriptions from
the data model level upwards
Pchelolo added a comment.
WikiBase client, that implements Action API for descriptions uses
`allowLocalShortDesc` config variable. Whatever config we introduce mustn't
duplicate that one.
TASK DETAIL
https://phabricator.wikimedia.org/T259622
EMAIL PREFERENCES
https
Pchelolo added a comment.
- https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Short_descriptions
notes that's it's recommended to mention the source of the description in the
edit summary. Should we support optionally providing the page summary?
- The template on enwiki
<ht
Pchelolo added a comment.
Complete stack trace:
Expectation (writeQueryTime <= 1) by MediaWiki::main not met (actual:
3.366758108139):
query-m: SELECT GET_LOCK('X', N) AS lockstatus [TRX#7ad8fc]
#0
/srv/mediawiki/php-1.35.0-wmf.30/includes/libs/rdbms/TransactionProfiler.
Pchelolo added a comment.
It's PageEditStash. See my comment above.
TASK DETAIL
https://phabricator.wikimedia.org/T251457
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pchelolo
Cc: Agusbou2015, Pchelolo, daniel, DannyS712, Jdforrester-WMF
Pchelolo added a comment.
The other associated log actually gives more insight on which lock is making
the transaction timeout:
Expectation (writeQueryTime <= 1) by MediaWiki::main not met (actual:
3.366758108139):
query-m: SELECT GET_LOCK('X', N) AS lockstatus [TRX#7ad8fc]
Pchelolo added a comment.
@daniel I don't think this is that lock showing up here. Reading the code, it
seems like if that lock was taken, we should've seen a bunch more queries in
this transaction, like some deletes, read from the archive table etc.
TASK DETAIL
https
Pchelolo added a comment.
Looking at the requestId of one of these errors, the following log messages
are found: https://logstash.wikimedia.org/goto/3e387a16e01ae0f02e72b413d6691539
The interesting one there is:
Sub-optimal transaction on DB(s) [10.64.16.34 (frwiki) (TRX#7ad8fc
Pchelolo closed subtask T240213: Write integration tests for XML dumps with
multiple MCR slots per revision as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T238972
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: ArielGlenn, Pchelolo
Cc
Pchelolo edited projects, added Core Platform Team Workboards (Clinic Duty
Team); removed Core Platform Team.
TASK DETAIL
https://phabricator.wikimedia.org/T248459
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pchelolo
Cc: WDoranWMF, Pchelolo
Pchelolo added a comment.
These are caused by math extension not being able to connect to RESTBase from
CI. I think this is a separate issue from the wiki base one.
I somehow don't believe the problem is in RESTBase itself - if math rendering
was failing in RESTBase with such frequency
Pchelolo reopened subtask T240213: Write integration tests for XML dumps with
multiple MCR slots per revision as Open.
TASK DETAIL
https://phabricator.wikimedia.org/T238972
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: ArielGlenn, Pchelolo
Cc
Pchelolo closed subtask T240213: Write integration tests for XML dumps with
multiple MCR slots per revision as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T238972
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: ArielGlenn, Pchelolo
Cc
Pchelolo edited projects, added Core Platform Team Workboards (External Code
Reviews); removed Core Platform Team.
TASK DETAIL
https://phabricator.wikimedia.org/T245535
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pablo-WMDE, Pchelolo
Cc
Pchelolo added a comment.
Yeah, @Gehel analysis is correct - change-prop is pretty simple and doesn't
support any of the advanced features pointed in the task. We have never really
needed any of those, we mostly rely on the fact that systems updated by
change-prop are idempotent and don't
Pchelolo added a comment.
All uses have been eliminated.
TASK DETAIL
https://phabricator.wikimedia.org/T244039
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: DannyS712, Pchelolo
Cc: Pchelolo, DannyS712, Aklapper, Daimona, Un1tY, Hook696
Pchelolo updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T244927
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: DannyS712, Pchelolo
Cc: Aklapper, DannyS712, Liuxinyu970226, Un1tY, keithbrianpadilla, Hook696,
Adidsone1
Pchelolo closed subtask T198342: Remove all usages of the text flag
in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo(). as
Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T198341
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
Pchelolo closed this task as "Resolved".
Pchelolo moved this task from Blocked to Done on the Core Platform Team
Workboards (Purple) board.
Pchelolo claimed this task.
Pchelolo added a comment.
With the completion of the Translate extension, all references has been
either remove
Pchelolo closed subtask T198343: Replace all calls to
Revision::getRevisionText() as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T198341
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pchelolo
Cc: holger.knust, BPirkle, tstarling
Pchelolo closed this task as "Resolved".
Pchelolo moved this task from Blocked Externally to Done on the Core Platform
Team Workboards (Clinic Duty Team) board.
Pchelolo claimed this task.
Pchelolo added a comment.
Translate extension is done, all usages has been either remove
Pchelolo closed subtask T228675: Remove direct access to the text table from
the Translate extension. as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T198341
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pchelolo
Cc: holger.knust
Pchelolo closed subtask T228675: Remove direct access to the text table from
the Translate extension. as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T198343
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pchelolo
Cc: Pchelolo, Clarakosi
Pchelolo closed subtask T228675: Remove direct access to the text table from
the Translate extension. as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T198342
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pchelolo
Cc: Daimona, Nikerabbit
Pchelolo closed subtask T233353: EntitySchema: remove dependency on pre-MCR
database schema as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T198341
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pchelolo
Cc: holger.knust, BPirkle
Pchelolo closed this task as "Resolved".
Pchelolo moved this task from Doing to Done on the Core Platform Team
Workboards (Purple) board.
TASK DETAIL
https://phabricator.wikimedia.org/T233353
WORKBOARD
https://phabricator.wikimedia.org/project/board/4181/
EMAIL PREFERENC
Pchelolo closed subtask T233358: SpamBlacklist: remove dependency on pre-MCR
database schema as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T198342
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pchelolo
Cc: Daimona, Nikerabbit, BPirkle
Pchelolo closed subtask T233356: Flow: remove dependency on pre-MCR database
schema as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T198342
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pchelolo
Cc: Daimona, Nikerabbit, BPirkle
Pchelolo closed subtask T233356: Flow: remove dependency on pre-MCR database
schema as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T198341
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: holger.knust, Pchelolo
Cc: BPirkle, tstarling
Pchelolo added a comment.
The last usage of the method within core (apart from maintenance scripts) is
in ApiQueryDeletedrevs which was deprecated since 1.25.
Quick search reveals that it's still used in pywikibot ( there's a ticket
about that T75370 <https://phabricator.wikimedia.
Pchelolo added a comment.
On the JobQueue side, nothing specific is observed neither on graphs nor logs
for `recentChangesUpdate`.
TASK DETAIL
https://phabricator.wikimedia.org/T228343
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pchelolo
Cc
Pchelolo added a comment.
In #changeprop <https://phabricator.wikimedia.org/tag/changeprop/> for job
queue, we have a concept of concurrency - how many jobs of the same type can be
running in parallel. `wikibase-addUsagesForPage` had a special rule with
concurrency 30, so if this p
Pchelolo added a comment.
OMG! ❤️
TASK DETAIL
https://phabricator.wikimedia.org/T205045
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup, Pchelolo
Cc: Joe, mobrovac, Pchelolo, Michael, Lydia_Pintscher, jcrespo, Ladsgroup, hoo
Pchelolo edited projects, added Services (done), Core Platform Team Kanban (Done with CPT); removed Patch-For-Review, Core Platform Team Kanban (Blocked Externally), Services (blocked).Pchelolo closed this task as "Resolved".Pchelolo claimed this task.Pchelolo added a comment.
MW trai
Pchelolo added a comment.
We're getting closer. The last part of the puzzle would be to emit the event publically via event streams. In order to do that, we need to add the mediawiki.page-links-change topic to the list of exposed topics in puppet for production and for deployment-prepTASK
Pchelolo added a comment.
We have discovered that we would need to update LinkUpdates class in the core to support this functionality, so it will take a little bit more time then we anticipated, but we're making progress.TASK DETAILhttps://phabricator.wikimedia.org/T214706EMAIL PREFERENCEShttps
Pchelolo added a comment.
How should we handle the situation with long list of links? Is that really a problem? Should we create multiple events?
You should not worry about that unless you encounter a list of links that's > 4mb long :)TASK DETAILhttps://phabricator.wikimedia.org/T214706EM
Pchelolo added a comment.
Are links url encoded? (we probably want them to be so).
I agree with @Nuria on this. The 'meta.uri' is encoded, we need to be consistent. Whether the LinksUpdate in MW has encoded or not encoded links - needs to be tested.TASK DETAILhttps://phabricator.wikimedia.org
Pchelolo added a comment.
@Pchelolo yes, replacing "properties" with "links" should do it. I don't think we need the full list of links, just the changes.
Perfect. Just make a change request in gerrit with a new schema. I can point you to where to write the code for emitting t
Pchelolo added a comment.
@bmansurov look at the event schema for properties change I've linked, it contains all of the metadata you need and it's generated from the same hook. Will such a schema work for you if we replace removed_properties with removed_links and added_properties with added_links
Pchelolo edited projects, added Services (blocked); removed Services.Pchelolo added a comment.
Moving to services-blocked until #research comes up with the schema for the event.TASK DETAILhttps://phabricator.wikimedia.org/T214706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
Pchelolo added a comment.
The task at hand is very easy. There's LinksUpdateComplete hook in MW core, it gets the LinksUpdate which contains the list of external links and methods to get links insertions and removals. Writing code in EventBus extension to use the hook is simple. The important part
Pchelolo added a comment.
Change-Prop now has a separate rule for this job, so it doesn't interfere with low-traffic jobs. The concurrency is set to 30, which should be enough, however after deploying 100% we need to monitor the lag and increase concurrency if we see the job is steadily
Pchelolo added a comment.
Default low volume queue concurrency is 50 per https://github.com/wikimedia/mediawiki-services-change-propagation-jobqueue-deploy/blob/master/scap/vars.yaml#L101
So getting this to 100% without hitting the limit should be no problem.
However, those 50 slots are shared
Pchelolo added a comment.
I've noticed some errors in the JobQueue with the message like 'Cannot instantiate job 'constraintsRunCheck': bad spec!'
Here's the job:
{
"database": "wikidatawiki",
"mediawiki_signature": "5de8d10b6415ec7910a231f5234dd
Pchelolo added a comment.
Do you need the events for the last month to be replayed?TASK DETAILhttps://phabricator.wikimedia.org/T210451EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mobrovac, PcheloloCc: Stashbot, gerritbot, MisterSynergy, mobrovac
Pchelolo added a comment.
Not to be worried. We have all the failed events stored since 2018-04-18. If needed, I will fetch all the missing page deletes tomorrow.TASK DETAILhttps://phabricator.wikimedia.org/T210451EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
Pchelolo added a comment.
Yes, the fix has not been deployed yet.
Asked to put it on Euro Mid-day SWATTASK DETAILhttps://phabricator.wikimedia.org/T210451EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PcheloloCc: TerraCodes, Liuxinyu970226, Aklapper
Pchelolo added a comment.
Judging by the quick skim of the Jackson code it supports DateTimeFormatter.ISO_INSTANT format that should support fractional seconds parsing.
However, this incident raises a question whether the change applied to EventBus was indeed backward-compatible. We've checked
Pchelolo added a comment.
Maybe jackson just can't parse this microsecond stuff? Maybe milliseconds are fine?
Judging by the error message, it cripples on the . after seconds.
@Smalyshev Also please note we're only including microseconds and not milliseconds because of the HHVM incompatibility
Pchelolo added a comment.
We could rollback https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/EventBus/+/468482/ - we can workaround it in change-prop and the issue fixed by that is much rarer, but eventually, we'd want to include millisecond resolution into the dt of the events.TASK
Pchelolo added projects: WMF-JobQueue, Services (watching).Pchelolo added a comment.
Just to make sure - jobs now MUST be JSON-serializable, so please keep that in mind from the very beginning (no PHP classes in the job). Plus please ping #services when deploying it if the anticipated rate
Pchelolo moved this task from Backlog to watching on the Services board.Pchelolo edited projects, added Services (watching); removed Services.
TASK DETAILhttps://phabricator.wikimedia.org/T200594WORKBOARDhttps://phabricator.wikimedia.org/project/board/69/EMAIL PREFERENCEShttps
Pchelolo added a comment.
From the #services side there are 2 things to consider:
Invalidation. Right now we do not have summaries for wikidata, so new rules will need to be added to #changeprop for cache invalidation. In case we include information like number of sitelinks etc, that's
Pchelolo moved this task from Backlog to watching on the Services board.Pchelolo edited projects, added Services (watching); removed Services.
TASK DETAILhttps://phabricator.wikimedia.org/T199096WORKBOARDhttps://phabricator.wikimedia.org/project/board/69/EMAIL PREFERENCEShttps
Pchelolo added a comment.
If we add a new mediawiki topic, we need to remember to run this command for it.
Or implement T157092 :)TASK DETAILhttps://phabricator.wikimedia.org/T187296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ottomata, PcheloloCc: mforns
Pchelolo added a project: Services (watching).
TASK DETAILhttps://phabricator.wikimedia.org/T187296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ottomata, PcheloloCc: mforns, elukey, Ottomata, Aklapper, Nuria, Ladsgroup, Pchelolo, JAllemandou, Smalyshev
Pchelolo created this task.Pchelolo added projects: MediaWiki-extensions-WikibaseClient, Services (watching), Wikidata, JobRunner-Service.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONTrying to execute a ChangeNotification job with the following parameters:
{"database":&qu
Pchelolo closed this task as "Resolved".Pchelolo edited projects, added Services (done); removed Epic, Services (doing).Pchelolo added a comment.
We've already found all the current use-cases and implemented support for delayed jobs, so resolving.TASK DETAILhttps://phabricator.wik
Pchelolo added a comment.
Currently on kafka-main machines the disk utiliation is really low, so I think we can easily do it without kafka-jumbo.
dsh --group kafka_eqiad --remoteshell ssh -- 'df -h' | grep '/srv'
/dev/md17.2T 737G 6.1T 11% /srv
/dev/md17.2T 736G 6.1T 11
Pchelolo added a comment.
Currently on kafka-main machines the disk utiliation is really low, so I think we can easily do it without kafka-jumbo.
dsh --group kafka_eqiad --remoteshell ssh -- 'df -h' | grep '/srv'
/dev/md17.2T 737G 6.1T 11% /srv
/dev/md17.2T 736G 6.1T 11
Pchelolo added a comment.
Hm, actually if I just try to consume from that topic (any topic actually) with -F "%T" that should give me message timestamps it gives -1 as well.
I suppose that the problem is that we're actually producing these messages into Kafka 0.9 and perhaps not
Pchelolo closed this task as "Resolved".Pchelolo added a comment.
This is not happening any more, thank you for resolving.TASK DETAILhttps://phabricator.wikimedia.org/T178997EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PcheloloCc: thiemowmde,
Pchelolo added a comment.
Indeed. Created T182163 for updating kafkacat but it is a bit more complex then simply installing new version - it depends on newer librdkafka, so we firs should upgrade and test that.TASK DETAILhttps://phabricator.wikimedia.org/T161731EMAIL PREFERENCEShttps
Pchelolo added a comment.
In T161731#3814596, @Smalyshev wrote:
@Ottomata thanks, I can connect to the hosts above, but still not sure how to control the starting point. I'll try to look around for clients that can do this.
Java client has offsetsForTimes implemented and supports seek
1 - 100 of 117 matches
Mail list logo
