[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

[Pchelolo]

Pchelolo added a comment.


  Complete stack trace:
  
    Expectation (writeQueryTime <= 1) by MediaWiki::main not met (actual: 
3.366758108139):
    query-m: SELECT GET_LOCK('X', N) AS lockstatus [TRX#7ad8fc]
    #0 
/srv/mediawiki/php-1.35.0-wmf.30/includes/libs/rdbms/TransactionProfiler.php(255):
 
Wikimedia\Rdbms\TransactionProfiler->reportExpectationViolated('writeQueryTime',
 Object(Wikimedia\Rdbms\GeneralizedSql), 3.366758108139)
    #1 
/srv/mediawiki/php-1.35.0-wmf.30/includes/libs/rdbms/database/Database.php(1396):
 
Wikimedia\Rdbms\TransactionProfiler->recordQueryCompletion(Object(Wikimedia\Rdbms\GeneralizedSql),
 1588267688.055, true, 1)
    #2 
/srv/mediawiki/php-1.35.0-wmf.30/includes/libs/rdbms/database/Database.php(1278):
 Wikimedia\Rdbms\Database->executeQueryAttempt('SELECT GET_LOCK...', 'SELECT /* 
Media...', true, 'MediaWiki\\Stora...', 136)
    #3 
/srv/mediawiki/php-1.35.0-wmf.30/includes/libs/rdbms/database/Database.php(1211):
 Wikimedia\Rdbms\Database->executeQuery('SELECT GET_LOCK...', 
'MediaWiki\\Stora...', 136)
    #4 
/srv/mediawiki/php-1.35.0-wmf.30/includes/libs/rdbms/database/DatabaseMysqlBase.php(1216):
 Wikimedia\Rdbms\Database->query('SELECT GET_LOCK...', 'MediaWiki\\Stora...', 
136)
    #5 
/srv/mediawiki/php-1.35.0-wmf.30/includes/Storage/PageEditStash.php(324): 
Wikimedia\Rdbms\DatabaseMysqlBase->lock('frwiki:stashedi...', 
'MediaWiki\\Stora...', 30)
    #6 
/srv/mediawiki/php-1.35.0-wmf.30/includes/Storage/PageEditStash.php(222): 
MediaWiki\Storage\PageEditStash->getAndWaitForStashValue('frwiki:stashedi...')
    #7 
/srv/mediawiki/php-1.35.0-wmf.30/includes/Storage/DerivedPageDataUpdater.php(778):
 MediaWiki\Storage\PageEditStash->checkCache(Object(Title), 
Object(WikitextContent), Object(User))
    #8 /srv/mediawiki/php-1.35.0-wmf.30/includes/page/WikiPage.php(2044): 
MediaWiki\Storage\DerivedPageDataUpdater->prepareContent(Object(User), 
Object(MediaWiki\Storage\RevisionSlotsUpdate), true)
    #9 
/srv/mediawiki/php-1.35.0-wmf.30/extensions/SpamBlacklist/includes/SpamBlacklistHooks.php(30):
 WikiPage->prepareContentForEdit(Object(WikitextContent))
    #10 
/srv/mediawiki/php-1.35.0-wmf.30/includes/HookRunner/HookContainer.php(283): 
SpamBlacklistHooks::filterMergedContent(Object(DerivativeContext), 
Object(WikitextContent), Object(Status), 'Proposition de ...', Object(User), 
false)
    #11 
/srv/mediawiki/php-1.35.0-wmf.30/includes/HookRunner/HookContainer.php(126): 
MediaWiki\HookRunner\HookContainer->callLegacyHook('EditFilterMerge...', Array, 
Array, Array)
    #12 /srv/mediawiki/php-1.35.0-wmf.30/includes/Hooks.php(135): 
MediaWiki\HookRunner\HookContainer->run('EditFilterMerge...', Array, Array)
    #13 /srv/mediawiki/php-1.35.0-wmf.30/includes/EditPage.php(1931): 
Hooks::run('EditFilterMerge...', Array)
    #14 /srv/mediawiki/php-1.35.0-wmf.30/includes/EditPage.php(2388): 
EditPage->runPostMergeFilters(Object(WikitextContent), Object(Status), 
Object(User))
    #15 /srv/mediawiki/php-1.35.0-wmf.30/includes/EditPage.php(1748): 
EditPage->internalAttemptSave(NULL, false)
    #16 /srv/mediawiki/php-1.35.0-wmf.30/includes/EditPage.php(728): 
EditPage->attemptSave(NULL)
    #17 /srv/mediawiki/php-1.35.0-wmf.30/includes/actions/EditAction.php(59): 
EditPage->edit()
    #18 /srv/mediawiki/php-1.35.0-wmf.30/includes/actions/SubmitAction.php(38): 
EditAction->show()
    #19 /srv/mediawiki/php-1.35.0-wmf.30/includes/MediaWiki.php(519): 
SubmitAction->show()
    #20 /srv/mediawiki/php-1.35.0-wmf.30/includes/MediaWiki.php(305): 
MediaWiki->performAction(Object(Article), Object(Title))
    #21 /srv/mediawiki/php-1.35.0-wmf.30/includes/MediaWiki.php(973): 
MediaWiki->performRequest()
    #22 /srv/mediawiki/php-1.35.0-wmf.30/includes/MediaWiki.php(535): 
MediaWiki->main()
    #23 /srv/mediawiki/php-1.35.0-wmf.30/index.php(47): MediaWiki->run()
    #24 /srv/mediawiki/w/index.php(3): require('/srv/mediawiki/...')
    #25 {main}
  
  I'm not entirely sure I understand it correctly, but 
PageEditStash::getAndWaitForStashValue uses ILoadBalancer::getAnyOpenConnection 
and by chance acquires a connection where a transaction was already open for 
edit?

TASK DETAIL
  https://phabricator.wikimedia.org/T251457

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo
Cc: Agusbou2015, Pchelolo, daniel, DannyS712, Jdforrester-WMF, Krinkle, 
Marostegui, Liuxinyu970226, brennen, Bugreporter, LarsWirzenius, Hogue, 
Aklapper, Naike, eprodromou, darthmon_wmde, Nandana, Banyek, Rayssa-, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, 
Rxy, Jay8g, Krenair

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs