Tgr added a comment.
In T364273#9804281 <https://phabricator.wikimedia.org/T364273#9804281>,
@Lucas_Werkmeister_WMDE wrote:
> If I understand the `load_composer_autoloader` flag correctly, it’s
probably only needed if you’re not using the composer merge plugin?
Yeah,
Tgr added a comment.
I can't reproduce it anymore (I guess I would have to undo the migration
first) but I guess it's the thing where you have to tell extension.json you
have composer dependencies, otherwise it might or might not break depending on
how you use composer.
TASK DETAIL
https
Tgr created this task.
Tgr added a project: MediaWiki-extensions-WikibaseClient.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
[b044c19a718cc572f5c35d43] [no req] Error: Class
'Onoi\MessageReporter\NullMessageReporter' not found
Backtrace:
from
/vagrant
Tgr added a comment.
There is also a chance that T348388: Use central login wiki for login (SUL3)
<https://phabricator.wikimedia.org/T348388> will find a way to make central
login in the background work, and then this would become a non-issue. I
wouldn't bet on it though.
TASK
Tgr added a comment.
> But there’s a risk that the user will close the tab before finishing all
the edits, and then the redirect never happens.
Maybe we could build some way of tracking whether the session has been
"merged" into a central session, and force a central logi
Tgr added a comment.
> - **Language code**. If using Title::getPageViewLanguage to associate page
language outside a pageview perspective, it is likely incorrect. Consider using
`Title->getPageLanguage()` instead.
I'm not sure this is correct. I've just run into this in T353199:
Tgr added a comment.
Not sure which team that is, Wikibase is owned by WMDE and the past
prop=description projects were one-offs. (It seems fairly easy though. If
someone wants to try their hand at fixing it, they probably just need to add
some variant handling to the language logic here
Tgr added a comment.
There are two implementations of prop=description:
- fetching the description from the ParserOutput, used on enwiki only; in
theory just need to make sure we are using the ParserOutput in the right
language variant, but enwiki doesn't have variants so probably
Tgr added a project: MediaWiki-extensions-WikibaseClient.
Tgr added a comment.
Extracts seem to work fine to me.
extracts=100=1=1=zh-hk|https://zh.wikipedia.org/w/api.php?...=zh-hk
<https://zh.wikipedia.org/w/api.php?action=query=json=2=%E5%AE%87%E5%AE%99=description>
extracts
Tgr added subscribers: Anomie, Tgr.
Tgr closed this task as "Resolved".
Tgr claimed this task.
Tgr added a comment.
The specific issue described in the reproduction steps is working as intended
- we cannot share login state between www.wikidata.org and m.wikidata.org
because they d
Tgr added a comment.
In T318138#8754764 <https://phabricator.wikimedia.org/T318138#8754764>,
@Lucas_Werkmeister_WMDE wrote:
> Is this the same as T49647 <https://phabricator.wikimedia.org/T49647> for a
different wiki? We have a hack (actually, a “hack” and
Tgr added a parent task: T348573: All Wikimedia extensions that store their
data outside the main database should use a virtual database domain.
TASK DETAIL
https://phabricator.wikimedia.org/T348526
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
Tgr added a comment.
In T253280#8516612 <https://phabricator.wikimedia.org/T253280#8516612>,
@matthiasmullie wrote:
> @Tgr does that match your view?
In general, yes. Specifically for the DPI task, I'm not sure if that's
something that needs to be configured per-file
Tgr added a comment.
T325948: Provide an API for accessing alt text (and possibly other structured
data) stored with MediaWiki file uploads
<https://phabricator.wikimedia.org/T325948> and T325949: Allow access to (some)
structured image metadata across wikis
Tgr added a subscriber: TheDJ.
Tgr added a comment.
Some good points from another task:
In T166094#8310375 <https://phabricator.wikimedia.org/T166094#8310375>,
@TheDJ wrote:
> 1. Having a default alt tag, will increase the size of an img transclusion
on pages, which seems
Tgr updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T325948
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Aklapper, Tgr, Astuthiodit_1, G1964j, Zekwn, karapayneWMDE, the0001, bwang,
Invadibot, Mooeena
Tgr added a comment.
Because of T325949: Allow access to (some) structured image metadata across
wikis <https://phabricator.wikimedia.org/T325949>, there are two orthogonal
directions of abstraction here:
- how the alt text is stored (Wikibase property, or inside wikitext, or
som
Tgr renamed this task from "Provide an API for accessing alt text stored with
MediaWiki file uploads" to "Provide an API for accessing alt text (and possibly
other structured data) stored with MediaWiki file uploads".
Tgr updated the task description.
Tgr updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T325948
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Aklapper, Tgr, Astuthiodit_1, G1964j, Zekwn, karapayneWMDE, the0001, bwang,
Invadibot, Mooeena
Tgr updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T325948
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Aklapper, Tgr, Astuthiodit_1, G1964j, Zekwn, karapayneWMDE, the0001, bwang,
Invadibot, Mooeena
Tgr created this task.
Tgr added projects: Accessibility, SDC General, Commons, MediaWiki-General.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Wikimedia Commons stores alt text in the form of WikibaseMediaInfo claims
(see T166094: Allow editors to provide default alt
Tgr updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T166094
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: TheDJ, Chidgk1, El_Grafo, Metamorforme42, SyntaxTerror, Nikki, DrMel, Sdkb,
Base, FRomeo_WMF, Multichill
Tgr added a comment.
Filed T325944: Use a multlingual Wikibase property for storing alt text on
Commons <https://phabricator.wikimedia.org/T325944> for eventually replacing
with a multilingual property.
TASK DETAIL
https://phabricator.wikimedia.org/T166094
EMAIL PREFERENCES
Tgr added a parent task: T325944: Use a multlingual Wikibase property for
storing alt text on Commons.
TASK DETAIL
https://phabricator.wikimedia.org/T86517
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: KH32, mxn, DannyS712, Yurik, Wostr
Tgr closed this task as "Resolved".
Tgr claimed this task.
Tgr added a comment.
The Wikidata property proposal was accepted: P11265 (alt text)
<https://www.wikidata.org/wiki/Property:P11265>. Note that pending T86517:
[Story] Add a new datatype for multiling
Tgr added a subtask: T324910: Slot-aware action 'raw'.
TASK DETAIL
https://phabricator.wikimedia.org/T174022
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Magol, Lokal_Profil, AfroThundr3007730, Agabi10, Liuxinyu970226, TomT0m,
Smalyshev
Tgr added a comment.
I can see two approaches:
- encode the information in the thumbnail URL (similar to how e.g. the
thumnail URL of a low-quality JPG would be something like
`qlow-123px-Example.jpg`)
- encode the information in Swift headers
Encoding in the URL has the benefit
Tgr added a comment.
A new, similar CI break:
18:24:47 1)
Wikibase\Repo\Tests\Hooks\Formatters\EntityLinkFormatterFactoryTest::testGivenNotArrayOfCallbacks_throwsException
with data set #0 (array(null))
18:24:47 Wikimedia\Services\RecursiveServiceDependencyException: Recursive
Tgr added a comment.
I guess the nice thing to would be to properly dependency-inject UserNameInfo
into SessionBackend, so what dependency loading order we end with does not
depend on when session saving happens to be triggered.
TASK DETAIL
https://phabricator.wikimedia.org/T315489
EMAIL
Tgr added a project: ci-test-error (WMF-deployed Build Failure).
TASK DETAIL
https://phabricator.wikimedia.org/T315489
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot
Tgr removed a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T315489
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot,
caldera, maantietaja
Tgr added a comment.
Also, why is this affecting a single testcase in a single test file
<https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/23868774558b7e4f33ca8d375390f9535c6595cc/repo/tests/phpunit/includes/Hooks/Formatters/EntityLinkFormatterFactoryTest.php#51>?
It d
Tgr added a comment.
What a mess. The test calls `Language::factory`, which needs NamespaceInfo,
which tries to initialize a bunch of configuration settings. Somehow something
inside `new ServiceOptions( NamespaceInfo::CONSTRUCTOR_OPTIONS,
$services->getMainConfig() )` triggers sess
Tgr added a comment.
So it seems EarlyLifeCycleHooks is somehow causing this or contributing to
it. Presumably because it adds a UserOptionsLookup dependency to
language-related things (more specifically anything that would do message
loading during initialization), but then why doesn't
Tgr created this task.
Tgr added projects: MediaWiki-extensions-WikibaseRepository, GrowthExperiments.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Growth-Team.
TASK DESCRIPTION
Breaks CI for all patches in GrowthExperiments at least. Example
Tgr added a parent task: T298283: composer 2.2 requires plugins to be allowed
to run code.
TASK DETAIL
https://phabricator.wikimedia.org/T311812
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE, Tgr
Cc: TheresNoTime, Aklapper
Tgr removed a project: Growth-Team.
TASK DETAIL
https://phabricator.wikimedia.org/T300306
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jdlrobson, Tgr
Cc: Volker_E, Esanders, Aklapper, Tacsipacsi, Nikerabbit, Iniquity, Johan,
PeterBowman
Tgr removed a project: GrowthExperiments.
TASK DETAIL
https://phabricator.wikimedia.org/T300306
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jdlrobson, Tgr
Cc: Volker_E, Esanders, Aklapper, Tacsipacsi, Nikerabbit, Iniquity, Johan,
PeterBowman
Tgr added a subtask: T300346: Fix uses of (error|success|warning|message)box in
Growth extensions.
TASK DETAIL
https://phabricator.wikimedia.org/T300306
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jdlrobson, Tgr
Cc: Volker_E, Esanders, Aklapper
Tgr added a comment.
You are right, that was clearly meant to be a URL. (Which is the same as the
production one so the beta config can just be discarded.)
TASK DETAIL
https://phabricator.wikimedia.org/T296712
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
Tgr added a comment.
Wikibase's own documentation also says
<https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/be728a4541dd9382218edd006781d0ce3c3e406d/docs/topics/options.md#Echo>
`path` should be relative to the extensions directory. So the simplest fix is
to just
Tgr added a comment.
In T231084#7152005 <https://phabricator.wikimedia.org/T231084#7152005>,
@Krinkle wrote:
> In fact, MediaWiki generally doesn't allow you to change content models of
a page except from/to content modelse that have a common base type or otherwise
h
Tgr changed the task status from "Invalid" to "Declined".
TASK DETAIL
https://phabricator.wikimedia.org/T279829
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Luke081515, Ameisenigel, Tgr, MisterSynergy, Carn, Schnig
Tgr added a comment.
Yeah I think this should be a core hook, not a skin hook. There are several
uses for a short article description (I'd avoid "tagline" which is more about
where it is displayed than what it contains), e.g. currently VisualEditor is
using it for link s
Tgr added a project: MediaWiki-extensions-WikibaseRepository.
Tgr added a subscriber: kostajh.
Tgr added a comment.
@kostajh pointed out that the error only occurs in wmf.4 where that hook did
call that. (Was removed in rEGREa3226bd368ea: Change validation in ConfigHooks
to use
Tgr added a comment.
In T279829#7060056 <https://phabricator.wikimedia.org/T279829#7060056>,
@XanonymusX wrote:
> I am pretty sure that the short description will work in the same way as
the sort key does right now; thus we of course need to review the revision (in
the
Tgr added a comment.
Not a great solution though - it would be pretty confusing to have a
description structured data field and a description template field, with
completely different semantics. The obvious role for the description field
would be to be a plaintext equivalent
Tgr created this task.
Tgr added projects: WikibaseMediaInfo, SDC General, Commons.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
Currently, the HTML title (ie. the `` tag, ie. the text seen at the
very top
Tgr added a comment.
The title of the task made me think it's about refreshing the edited page
(ie. the page itself containing outdated/inconsistent data after the edit), but
I guess it's actually about refreshing the category page (ie. recursive links
update)? Those are different things. I
Tgr added a comment.
Can you confirm whether this has been fixed?
TASK DETAIL
https://phabricator.wikimedia.org/T237991
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Tgr, Addshore, Jarekt, Aklapper, CBogen, Akuckartz, darthmon_wmde
Tgr added a comment.
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/632685
16:31:51 [Chrome 73.0.3683.75 linux #0-3] 1) Wikitext Editor (Makes actual
saves) Redirects
16:31:51 [Chrome 73.0.3683.75 linux #0-3] element (".overlay
.wikitext-editor") still not exis
Tgr added a comment.
In T248457#6435718 <https://phabricator.wikimedia.org/T248457#6435718>,
@TheDJ wrote:
> I find the lack of action on this ticket stunning.
FWIW, there is some discussion on this on
https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(WM
Tgr added a comment.
@Iniquity this is not a good place to have this argument. If you want to
convince the English Wikipedia community that Wikidata descriptions do not
conflict with their policies, or that they should be used regardless of whether
they conflict with their policies, you
Tgr added a comment.
I have a hard time making sense of this bug report. What is the page where
you should have been logged in but weren't, and how is that related to the
OAuth server?
TASK DETAIL
https://phabricator.wikimedia.org/T254202
EMAIL PREFERENCES
https
Tgr updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T254202
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Aklapper, Epidosis, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi,
Gq86, GoranSMilovanovic
Tgr added a comment.
Ideally, `wbgetentities` should be a prop module. That would be useful for
both SDC/MediaInfo and for Wikidata, and in general fits with API conventions
better.
TASK DETAIL
https://phabricator.wikimedia.org/T206645
EMAIL PREFERENCES
https
Tgr edited projects, added Discovery-Search, Wikidata-Query-Service,
RESTBase-API; removed Operations, Traffic.
Tgr added a comment.
Restricted Application added a project: Wikidata.
Yeah, this is probably due to the lack of `Access-Control-Allow-Headers:
X-Wikimedia-Debug` in RESTBase
Tgr added a project: User-Tgr.
TASK DETAIL
https://phabricator.wikimedia.org/T166094
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Michael, Abbe98, Pigsonthewing, Bugreporter, Tgr, Dvorapa, thiemowmde,
Lydia_Pintscher, Izno, Whatamidoing
Tgr added a project: User-Tgr.
TASK DETAIL
https://phabricator.wikimedia.org/T213585
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Tgr, Dvorapa, RexxS, Pigsonthewing, ChristianFerrer, Abbe98, Aklapper,
CBogen, darthmon_wmde, Nandana
Tgr added a comment.
The page title is set in `DifferenceEngine::showDiffPage`, you'd have to
factor out that part into something that can be sanely overridden. Or, I guess,
change the title from the DifferenceEngineOldHeaderNoOldRev and
DifferenceEngineOldHeader hooks, although that's
Tgr added a project: good first task.
Tgr added a comment.
Short description handling currently lives in Wikibase, so mw.wikibase makes
sense nevertheless.
This should be reasonably easy, there's a service to return the description,
it just needs some scaffolding to make it available
Tgr added a comment.
This is unlikely to happen for the same reasons T243931: Allow a module to
load (require) another module from a global module repository wiki
<https://phabricator.wikimedia.org/T243931> didn't.
TASK DETAIL
https://phabricator.wikimedia.org/T191531
EMAIL PREFE
Tgr added a comment.
MediaWiki automatically wraps the entire request in a transaction if it
encounters a write which does not do its own transaction handling. So something
unrelated to saving could have started the transaction, like AbuseFilter taking
an action, or a session refresh
Tgr added a comment.
This has not been resolved. Declined, maybe?
TASK DETAIL
https://phabricator.wikimedia.org/T585
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Cparle, Abbe98, Ramesh2744, MarkTraceur, Abit, Ramsey-WMF, atgo, Matanya
Tgr added a comment.
I would suggest the opposite: keep `sql.php`, drop `patchSql.php`. I don't
think many people are familiar with the latter (compare patchSql
<https://www.mediawiki.org/w/index.php?title=Special:Search=500=0=1=1=1=1=1=1=%22patchSql.php%22={}>
vs sql
Tgr added a comment.
I guess the impact is a 20-min outage for requests not served from Varnish +
missing sitelinks / descriptions / infoboxes / other info from wikidata for
pages which have been edited since the end of the outage? Plus potentially some
automated editing tools getting wrong
Tgr added a comment.
I'd guess someone triggered T157651: sql.php runs LoadExtensionSchemaUpdates
<https://phabricator.wikimedia.org/T157651>. I actually made the same mistake
while trying to figure out what's broken:
tgr@mwmaint1002:~$ mwscript sql.php huwiki
>
Tgr added a project: MediaWiki-extensions-WikibaseRepository.
TASK DETAIL
https://phabricator.wikimedia.org/T249565
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Ahmad252, Dreamy_Jazz, Tgr, Liuxinyu970226, Koavf, DannyS712, Aklapper
Tgr added a comment.
> api.php?action=query=userinfo=json via OAuth to retrive the
username of the user
That works but it's not necessarily safe. You should use the OAuth identify
endpoint
<https://www.mediawiki.org/wiki/OAuth/For_Developers#Identifying_the_user>
Tgr added a comment.
Did you have both the wikidata and machinevision roles enabled? I'm not sure
that's supported.
TASK DETAIL
https://phabricator.wikimedia.org/T245845
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Tgr, Aklapper
Tgr added a comment.
In T231084#5839574 <https://phabricator.wikimedia.org/T231084#5839574>,
@Addshore wrote:
> With canDiffRevisions being implemented in DifferenceEngine which would see
if the 2 contents say they can be diffed with each other?
How would DifferenceEn
Tgr created this task.
Tgr added projects: MediaViewer, SDC General.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
MediaViewer has a caption and description area (above and below the fold,
respectively
Tgr updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T213585
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Tgr, Dvorapa, RexxS, Pigsonthewing, ChristianFerrer, Abbe98, Aklapper,
darthmon_wmde, Nandana, JKSTNK
Tgr updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T213585
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Tgr, Dvorapa, RexxS, Pigsonthewing, ChristianFerrer, Abbe98, Aklapper,
darthmon_wmde, Nandana, JKSTNK
Tgr added a comment.
Seems pretty clear there is no support for using the caption that way
(correctly, in my opinion), so rewrote the task to be agnostic of specifically
how the alt text is stored. (But it will probably be a dedicated Wikidata
property, see T166094: Allow editors to provide
Tgr renamed this task from "Images (on articles, on file/category pages, and in
the media viewer) should default to use their structured data caption as alt
text when available" to "Images (on articles, on file/category pages, and in
the media viewer) should default to use their
Tgr added a parent task: T166094: Allow editors to provide default alt text on
Wikimedia Commons file description pages.
TASK DETAIL
https://phabricator.wikimedia.org/T86517
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: DannyS712, Yurik
Tgr added a subtask: T86517: [Story] Add a new datatype for multilingual text.
TASK DETAIL
https://phabricator.wikimedia.org/T166094
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Tgr, Dvorapa, thiemowmde, Lydia_Pintscher, Izno, Whatamidoing
Tgr added a comment.
Repurposed this to be SDC-specific. The next step would be to write a
property proposal (and do it better than the rejected past attempts, which were
not very well written).
TASK DETAIL
https://phabricator.wikimedia.org/T166094
EMAIL PREFERENCES
https
Tgr renamed this task from "Please include suggested alt text for images" to
"Allow editors to provide default alt text on Wikimedia Commons file
description pages".
Tgr added a project: Commons.
Tgr updated the task description.
TASK DETAIL
https://phabricator.wikimedi
Tgr added a comment.
(See also T202763: Update extensions which customize content diff rendering
<https://phabricator.wikimedia.org/T202763>.)
DifferenceEngine calls the renderer of the right-hand item (so if you compare
wikibase item to wikitext, it will call TextSlotDiffRe
Tgr added a comment.
In T231084#5554961 <https://phabricator.wikimedia.org/T231084#5554961>, @Tgr
wrote:
> From a distance, the simple solution would be to create a UserPageError
subclass describing the situation and throw that instead of the assertion error.
One thin
Tgr added a comment.
The diff logic leaves it to the SlotDiffRenderer implementation to handle
incompatible types. Sorry about that, it's a bit shoddy. I don't remember if
there was some specific reason for not turning it into a user error, or it was
merely rushed.
From a distance
Tgr added a comment.
That's a duplicate of T231084: Assert.php: Bad value for parameter
$oldContent: must be a TextContent|null
<https://phabricator.wikimedia.org/T231084> (minus the pentesting aspect, which
I would not be worried about).
TASK DETAIL
https://phabricator.wikimed
Tgr added a comment.
In T230862#5503781 <https://phabricator.wikimedia.org/T230862#5503781>,
@Cparle wrote:
> So say we add a 'structured-data-mediainfo' tag to every revision that has
a `mediainfo` slot - would that be adequate? @EBernhardson ?
Given that this is a func
Tgr added a comment.
Thanks for lookig into it! These should be folded into the Vagrant role
settings. I can do that in a few weeks; if you want to do it before that, the
`mediainfo` role has an example of how to create Wikibase properties/entities
(that should probably be moved
Tgr added a comment.
IIRC this happens when Wikibase server code is loaded for a client wiki. I
tried to sort that apart in gerrit 524617
<https://gerrit.wikimedia.org/r/c/mediawiki/vagrant/+/524617> but maybe didn't
fully succeed.
(Note that enabling roles before the very
Tgr added a comment.
In T230862#5443414 <https://phabricator.wikimedia.org/T230862#5443414>,
@Anomie wrote:
> That has been proposed and opposed by various people for a long time.
I think it's worth revisiting, and there was unanimous agreement on that at
last TechConf's
Tgr added a comment.
In T230862#5442416 <https://phabricator.wikimedia.org/T230862#5442416>,
@Anomie wrote:
> OTOH, that would break it for any MediaWiki wikis not using Elastic...
IMO we'll have to bite that bullet at some point and change MediaWiki from a
PHP-based ap
Tgr added a comment.
In theory it would be something like `recentchanges JOIN revision ON
rc_this_oldid = rev_id JOIN slots ON slot_revision_id = rev_id AND slot_role_id
= whatever AND slot_origin = rev_id`. Except slot_origin is not used
consistently that way; this would miss rollbacks
Tgr added a project: Multi-Content-Revisions.
Tgr added a comment.
This is a special case of being able to filter by MCR slot type, which we'll
surely need in the long term.
TASK DETAIL
https://phabricator.wikimedia.org/T230862
EMAIL PREFERENCES
https://phabricator.wikimedia.org
Tgr added a comment.
rMWVA695fe0c8803c: Make wikidata and wikibase_repo roles work together
<https://phabricator.wikimedia.org/rMWVA695fe0c8803c2a5f10428b295249a4f63e97905c>
did this for Wikibase (in a very hacky way but I can't see any better one),
you should be able to generaliz
Tgr closed this task as "Resolved".
Tgr claimed this task.
Tgr added a comment.
Fixed, see T228428#5399031
<https://phabricator.wikimedia.org/T228428#5399031>. (Although as mentioned
there, the mediainfo role doesn't actually work. That was already the case
before th
Tgr closed this task as "Resolved".
Tgr claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T228593
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tgr
Cc: Mholloway, Agabi10, WMDE-leszek, Aklapper, Tgr, Hook696,
Tgr added a comment.
Actually it does get installed when I run Composer manually. So this is
probably just an ordering issue, with composer update running before the
merge-plugin fragment is added.
TASK DETAIL
https://phabricator.wikimedia.org/T228593
EMAIL PREFERENCES
https
Tgr added a comment.
Core's `composer.json` has an extra/merge-plugin entry for
`composer.local.json` which has one for `../settings.d/composer/*.json` which
includes a file created by the wikidata role which has a merge-plugin entry for
`extensions/Wikibase/composer.json`. Maybe recursive
Tgr created this task.
Tgr added projects: MediaWiki-Vagrant, Wikidata, Composer.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Wikibase does not use extension registration (T88258
<https://phabricator.wikimedia.org/T88258>) and it does not load the Composer
auto
Tgr closed this task as "Resolved".
Tgr added a comment.
This seems to be a composer-merge-plugin failure. Probably better to open a
separate task: T228593: Wikibase on Vagrant: composer-merge-plugin does not
install wikibase/data-model anymore <https://phabricator.wikimedi
Tgr updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T201615
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Smalyshev, Tgr
Cc: Mvolz, Jdforrester-WMF, gerritbot, ArielGlenn, Agabi10, Jdlrobson, bd808,
Smalyshev, WMDE
Tgr added a comment.
This is a problem on Vagrant, but that has its own task already: T201615:
Wikibase on Vagrant: Class 'Wikibase\DataModel\Entity\ItemId' not found
<https://phabricator.wikimedia.org/T201615>. Shouldn't be a problem in a manual
Wikibase install in theory.
TASK
1 - 100 of 320 matches
Mail list logo
