[Wikidata-bugs] [Maniphest] T353683: Unable to find a file by filename while adding a Commons media file statement

2024-01-09 Thread matthiasmullie
matthiasmullie added a comment. In T353683#9444888 <https://phabricator.wikimedia.org/T353683#9444888>, @Cparle wrote: > Don't remember for sure, but it seems unlikely that we excluded it on purpose. @matthiasmullie do you remember? Shouldn't be a huge deal to add it anyway

[Wikidata-bugs] [Maniphest] T253280: Per-file control for some thumbnail generation parameters

2023-01-11 Thread matthiasmullie
matthiasmullie added a comment. There is not currently a way for other wikis to retrieve structured data (statements/captions) from Commons other than calling the Wikibase action APIs on commons.wikimedia.org. Yes, T325948: Provide an API for accessing alt text (and possibly other

[Wikidata-bugs] [Maniphest] T316516: Bump Wikimedia world's copies of jQuery from 3.6.0 to 3.6.1

2022-10-21 Thread matthiasmullie
matthiasmullie updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T316516 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: Jdlrobson, Jdforrester-WMF, Jersione, PWaigi-WMF, Hellket777, LisafBia6531

[Wikidata-bugs] [Maniphest] T252443: Create dashboard to show growth of structured data on Commons over time

2022-04-22 Thread matthiasmullie
matthiasmullie added a comment. Question: the "SDC edits" tab mentions "only look[ing] at non-bot edits to files". MediaInfo submits all edits with a `bot: 1` flag via the API (code for statements <https://github.com/wikimedia/mediawiki-extensions-WikibaseMediaInf

[Wikidata-bugs] [Maniphest] T298700: [L] Remove coordinate location from Structured Data without putting the coordinates in the edit summary

2022-02-23 Thread matthiasmullie
matthiasmullie added a comment. 1. The relevant part in this summary (that we want removed) comes from `Wikibase\Repo\ChangeOp\ChangeOpRemoveStatement::getSummaryArgs`; that one must be prevented from returning the summary args (or its direct caller, `Wikibase\Repo\ChangeOp

[Wikidata-bugs] [Maniphest] T298700: [L] Remove coordinate location from Structured Data without putting the coordinates in the edit summary

2022-02-18 Thread matthiasmullie
matthiasmullie moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board. matthiasmullie claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T298700 WORKBOARD https://phabricator.wikimedia.org/project/board/4232/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T300830: When adding a date literal HTML with a span is shown

2022-02-03 Thread matthiasmullie
matthiasmullie added a comment. This hardly seems like a train blocker to me? This doesn't impact security, performance, data integrity or substantially break anything in any way. This looks terrible & we should fix it asap, but all in all it's just a minor (non-breaking) i

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

2021-12-09 Thread matthiasmullie
matthiasmullie added a comment. After above patch ends up deployed, support for references can be enabled by adding `?MediaInfoEnableReferences` to the uri. This will let us do some final tests on production before we switch it on for real. TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T297066: Unable to add multiple statements at once in Structured Data on Commons

2021-12-07 Thread matthiasmullie
matthiasmullie closed this task as "Resolved". matthiasmullie added a comment. I'll close this given that the author confirmed that their issue got resolved, and internal QA also flagged this in a separate ticket (T297171 <https://phabricator.wikimedia.org/T297171>) t

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

2021-12-07 Thread matthiasmullie
matthiasmullie added a comment. In T230315#7551764 <https://phabricator.wikimedia.org/T230315#7551764>, @Etonkovidova wrote: > (2) [minor] The mockup (**step 2**) displays connecting lines between statements/qualifiers/references in** Edit mode**. The current implementation

[Wikidata-bugs] [Maniphest] T297066: Unable to add multiple statements at once in Structured Data on Commons

2021-12-06 Thread matthiasmullie
matthiasmullie claimed this task. matthiasmullie edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T297066 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T297066: Unable to add multiple statements at once in Structured Data on Commons

2021-12-06 Thread matthiasmullie
matthiasmullie added a comment. This appears to still be broken. I assume I introduced this regression here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/742188 I'm reopening & will investigate - if anyone knows more about this and it should in fact be cl

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

2021-11-29 Thread matthiasmullie
matthiasmullie added a comment. This got stalled a bit because these additional UI elements & interaction revealed an issue with some of the code that renders all elements on the page (T296616 <https://phabricator.wikimedia.org/T296616>) - that has to be fixed before we roll o

[Wikidata-bugs] [Maniphest] T296616: Rendering error

2021-11-29 Thread matthiasmullie
matthiasmullie claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T296616 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: matthiasmullie, toberto, Invadibot, Surya742, GFontenelle_WMF, maantietaja, FRomeo_WMF

[Wikidata-bugs] [Maniphest] T296616: Rendering error

2021-11-29 Thread matthiasmullie
matthiasmullie created this task. matthiasmullie added projects: StructuredDataOnCommons, Wikidata, Wikimedia-Hackathon-2021, Structured-Data-Backlog (Current Work), GLAM, Patch-For-Review. Restricted Application removed a project: Patch-For-Review. TASK DESCRIPTION The patch that introduces

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

2021-11-08 Thread matthiasmullie
matthiasmullie added a comment. FYI concerning: "**//Note: This feature will be released behind a feature flag so that we can test thoroughly before release.//**" -> The feature flag will only toggle the "references" functionality. This work also affects how

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

2021-10-28 Thread matthiasmullie
matthiasmullie added a comment. In T230315#7431909 <https://phabricator.wikimedia.org/T230315#7431909>, @GFontenelle_WMF wrote: > I was wondering if you could record another one using actual references. Here's a video with the original example - does that clear

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

2021-10-21 Thread matthiasmullie
matthiasmullie added a comment. In T230315#7411907 <https://phabricator.wikimedia.org/T230315#7411907>, @John_Cummings wrote: > how is this different to how Wikidata does it? Not really; they're pretty much the same across Wikidata & Commons, just a little different

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

2021-10-08 Thread matthiasmullie
matthiasmullie added a comment. Implementation revealed a few additional questions around the design & interaction of the edit mode, for references and qualifiers. We've experimented with a few approaches, filled the gaps & landed on this: F34678804: references.m4

[Wikidata-bugs] [Maniphest] T230315: [XL] Create a way to see and add references to structured data on Commons (MediaInfo) statements

2021-09-22 Thread matthiasmullie
matthiasmullie claimed this task. matthiasmullie moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board. TASK DETAIL https://phabricator.wikimedia.org/T230315 WORKBOARD https://phabricator.wikimedia.org/project/board/4232/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T282654: Add separate 'language' param to pageterms & entityterms prop, to allow to differentiate from uselang

2021-07-15 Thread matthiasmullie
matthiasmullie closed this task as "Resolved". matthiasmullie claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T282654 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: Addshore, Lydia

[Wikidata-bugs] [Maniphest] T285969: Upload wizard structured data on Commons does not allow to enter values for statements

2021-07-02 Thread matthiasmullie
matthiasmullie closed this task as a duplicate of T285579: Add data step of Upload Wizard broken. TASK DETAIL https://phabricator.wikimedia.org/T285969 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: Geertivp, Aklapper, Invadibot

[Wikidata-bugs] [Maniphest] T282654: Add separate 'language' param to pageterms & entityterms prop, to allow to differentiate from uselang

2021-06-22 Thread matthiasmullie
matthiasmullie added a comment. In T282654#7145306 <https://phabricator.wikimedia.org/T282654#7145306>, @Lucas_Werkmeister_WMDE wrote: > Worth noting that a language parameter was suggested, but rejected, when the API module was first introduced: see https://gerrit.wikimedi

[Wikidata-bugs] [Maniphest] T274252: Let getLocationAgnosticMwApi accept API options

2021-04-09 Thread matthiasmullie
matthiasmullie removed projects: Wikidata-Campsite, Wikidata. matthiasmullie added a comment. Removing Wikidata tags since this ticket is no longer relevant for them, nor does it require any action on their part. TASK DETAIL https://phabricator.wikimedia.org/T274252 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T274252: Let getLocationAgnosticMwApi accept API options

2021-04-09 Thread matthiasmullie
matthiasmullie moved this task from Blocked to Code Review on the Structured-Data-Backlog (Current Work) board. matthiasmullie added a comment. Moving a copy of this into MediaSearch extension. This way, we are no longer blocked by the `wikibase/javascript-api`'s release schedule (which

[Wikidata-bugs] [Maniphest] T273506: [M] Sporadic “TypeError: Return value of EntityContentFactory::getTitleForId() must be an instance of Title, null returned” for Special:EntityData on Commons

2021-03-24 Thread matthiasmullie
matthiasmullie added a comment. Patches LGTM, but I didn't +2 the one in Wikibase repo (so that WMDE can look it over & approve) If they prefer me to +2, LMK, would be happy to. TASK DETAIL https://phabricator.wikimedia.org/T273506 EMAIL PREFERENCES https://phabricator.wikimedia

[Wikidata-bugs] [Maniphest] T273506: [M] Sporadic “TypeError: Return value of EntityContentFactory::getTitleForId() must be an instance of Title, null returned” for Special:EntityData on Commons

2021-03-01 Thread matthiasmullie
matthiasmullie added a comment. I suspect the correct solution within `MediaInfoHandler::getTitleForId` would probable be to throw an `InvalidArgumentException` in case there's no title for the given id (`EntityHandler::getTitleForId` is documented to throw that exception `if $id refers

[Wikidata-bugs] [Maniphest] T274252: Let getLocationAgnosticMwApi accept API options

2021-02-24 Thread matthiasmullie
matthiasmullie reopened this task as "Open". matthiasmullie added a comment. Actually - is there a timeline for releasing the next version of this repo? It looks like (except for this patch) nothing has happened in this repo for the past 8 months, so I'm worried it'll sit around

[Wikidata-bugs] [Maniphest] T274252: Let getLocationAgnosticMwApi accept API options

2021-02-11 Thread matthiasmullie
matthiasmullie closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T274252 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: matthiasmullie, Aklapper, CBogen, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T264296: [M] WikibaseMediaInfo does not support editing monolingual text in languages not supported by MediaWiki

2021-02-11 Thread matthiasmullie
matthiasmullie moved this task from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board. matthiasmullie claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T264296 WORKBOARD https://phabricator.wikimedia.org/project/board/4232/ EMAIL

[Wikidata-bugs] [Maniphest] T274252: Let getLocationAgnosticMwApi accept API options

2021-02-09 Thread matthiasmullie
matthiasmullie moved this task from Incoming to Blocked on the Structured-Data-Backlog (Current Work) board. matthiasmullie added a comment. Above patch should suffice, but needs someone with `wikibase/javascript-api` repo knowledge/access to CR. TASK DETAIL https

[Wikidata-bugs] [Maniphest] T274252: Let getLocationAgnosticMwApi accept API options

2021-02-09 Thread matthiasmullie
matthiasmullie created this task. matthiasmullie added projects: Wikidata-Campsite, Structured-Data-Backlog (Current Work). Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION This would allow passing in additional options

[Wikidata-bugs] [Maniphest] T271105: wbeditentity response does not contain lemma data

2021-01-28 Thread matthiasmullie
matthiasmullie added a comment. In T271105#6782179 <https://phabricator.wikimedia.org/T271105#6782179>, @CBogen wrote: > @Keegan and @matthiasmullie, do you have a sense of what this would break on our end and/or for the community? and @Keegan do you know of any

[Wikidata-bugs] [Maniphest] T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue

2021-01-25 Thread matthiasmullie
matthiasmullie claimed this task. Restricted Application added a project: wdwb-tech-focus. TASK DETAIL https://phabricator.wikimedia.org/T272508 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: egardner, matthiasmullie, MarkTraceur

[Wikidata-bugs] [Maniphest] T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue

2021-01-22 Thread matthiasmullie
matthiasmullie added a comment. Under normal conditions, it is not possible to submit invalid values like the one encountered here. I suspect there must've been a federation configuration issue >1y ago where test-commons thought it was linked to production wikidata rather t

[Wikidata-bugs] [Maniphest] T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue

2021-01-22 Thread matthiasmullie
matthiasmullie edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T272508 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: egardner

[Wikidata-bugs] [Maniphest] T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue

2021-01-20 Thread matthiasmullie
matthiasmullie added a comment. I think this error is unrelated to 1.36.0-wmf.27. The relevant code in WikibaseMediaInfo has not been touched in months, and it looks like the same is true for the calls to Wikidata code. As far as I can tell, it is a valid error, because the data

[Wikidata-bugs] [Maniphest] T257938: License type filter for media search

2020-12-10 Thread matthiasmullie
matthiasmullie added a comment. In T257938#6673206 <https://phabricator.wikimedia.org/T257938#6673206>, @matthiasmullie wrote: > In T257938#6645737 <https://phabricator.wikimedia.org/T257938#6645737>, @Multichill wrote: > >> I just noticed your patch. Not s

[Wikidata-bugs] [Maniphest] T257938: License type filter for media search

2020-12-07 Thread matthiasmullie
matthiasmullie added a comment. In T257938#6645737 <https://phabricator.wikimedia.org/T257938#6645737>, @Multichill wrote: > I just noticed your patch. Not sure how well this scales. Maybe put it somewhere in MediaWiki namespace on Commons as json in the future so it can be m

[Wikidata-bugs] [Maniphest] T257938: License type filter for media search

2020-11-13 Thread matthiasmullie
matthiasmullie moved this task from Code Review to Ready for Development on the Structured-Data-Backlog (Current Work) board. matthiasmullie added a comment. Moving back to "ready for development" for remaining work: - license mapping - UI TASK DETA

[Wikidata-bugs] [Maniphest] T257938: License type filter for media search

2020-11-13 Thread matthiasmullie
matthiasmullie added a comment. The code has been merged, but the complete mapping has not yet been compiled (AFAIK), so I guess that list will come in handy! TASK DETAIL https://phabricator.wikimedia.org/T257938 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] T237991: Changes to Structured Data on Commons should trigger page refresh

2020-11-03 Thread matthiasmullie
matthiasmullie added a comment. Here's a simplified example: Add `{{Sandbox/Mmullie_(WMF)/CheckIfHasStatement}}` to a file (e.g. https://commons.wikimedia.org/wiki/File:2019-09-16-tenerife-icod.jpg) That will add a category (`[[Category:No statements]]`) if there are no statements

[Wikidata-bugs] [Maniphest] T237991: Changes to Structured Data on Commons should trigger page refresh

2020-11-02 Thread matthiasmullie
matthiasmullie merged tasks: T245349: wbeditentity doesnt trigger page update on Wikimedia Commons, T251507: [Spike] Investigate page cache not being purged when SD edits are made. matthiasmullie added subscribers: Multichill, Cparle, Keegan. TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T237991: Changes to Structured Data on Commons should trigger page refresh

2020-11-02 Thread matthiasmullie
matthiasmullie added a comment. There are 4 tickets about what is likely the same thing - 1 Wikidata, 3 Commons. Since we're looking track, I'll merge the other 2 Commons-specific tickets into this one. Current status was already being tracked in 1 of these other tickets, but I'll

[Wikidata-bugs] [Maniphest] T216527: [Spike] How to deal with WB replacing their JS data model?

2020-09-03 Thread matthiasmullie
matthiasmullie closed subtask T218803: [Spike] investigate how much effort would be involved in wrapping wikibase datamodel in an Adapter as Declined. TASK DETAIL https://phabricator.wikimedia.org/T216527 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T216527: [Spike] How to deal with WB replacing their JS data model?

2020-09-01 Thread matthiasmullie
matthiasmullie closed this task as "Declined". matthiasmullie added a comment. Not worth pursuing ATM. Let’s figure this out and reconsider options if/when this becomes an actual issue in the future. TASK DETAIL https://phabricator.wikimedia.org/T216527 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] T204264: "Depicts crawling": Add displaying/editing statements to File page

2020-09-01 Thread matthiasmullie
matthiasmullie closed subtask T216527: [Spike] How to deal with WB replacing their JS data model? as Declined. Restricted Application added a project: Structured-Data-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T204264 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] T256617: Make link to entity/concept URI visible in left side menu for all Commons files

2020-07-31 Thread matthiasmullie
matthiasmullie moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board. matthiasmullie claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T256617 WORKBOARD https://phabricator.wikimedia.org/project/board/4232/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T256617: Make link to entity/concept URI visible in left side menu for all Commons files

2020-07-31 Thread matthiasmullie
matthiasmullie edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T256617 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: CBogen, Jheald

[Wikidata-bugs] [Maniphest] T173339: Categories tracking pages with wikidata links are not updated when items on Wikidata are modified

2020-07-15 Thread matthiasmullie
matthiasmullie added a comment. I believe that https://gerrit.wikimedia.org/r/602053 should fix this (and a couple of related issues), but it needs review. Anyone? :) TASK DETAIL https://phabricator.wikimedia.org/T173339 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Claimed] T256933: Alter the look of SDC GUI to hide input fields for properties which are not beeing edited

2020-07-02 Thread matthiasmullie
matthiasmullie claimed this task. matthiasmullie edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T256933 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Closed] T255601: MediaInfo UI breaks when repoDatabase set to "testcommonswiki" instead of false

2020-06-23 Thread matthiasmullie
matthiasmullie closed this task as "Resolved". matthiasmullie claimed this task. matthiasmullie added a comment. I redeployed the config patch (https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/605645) and this issue no longer seems present, so closing the ticket

[Wikidata-bugs] [Maniphest] [Unblock] T254315: entitysources: Directly create entitySources config for WMF production wikis

2020-06-23 Thread matthiasmullie
matthiasmullie closed subtask T255601: MediaInfo UI breaks when repoDatabase set to testcommonswiki instead of false as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T254315 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore

[Wikidata-bugs] [Maniphest] [Closed] T249556: Structured Data interface does not work on IE11

2020-06-22 Thread matthiasmullie
matthiasmullie closed this task as "Resolved". matthiasmullie added a comment. Things work & look fine now on my IE machine! TASK DETAIL https://phabricator.wikimedia.org/T249556 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mat

[Wikidata-bugs] [Maniphest] [Commented On] T255601: MediaInfo UI breaks when repoDatabase set to "testcommonswiki" instead of false

2020-06-19 Thread matthiasmullie
matthiasmullie added a comment. I can't reproduce locally ATM. Where did you get those errors? Test runs? In browser? On every page view or when editing structured data? TASK DETAIL https://phabricator.wikimedia.org/T255601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Closed] T244207: Revision 386521405 belongs to M43864745 instead of expected M79277318

2020-06-16 Thread matthiasmullie
matthiasmullie closed this task as "Resolved". matthiasmullie added a comment. Tested in prod (https://commons.wikimedia.org/wiki/File:2019-09-18-tenerife-teide-trees.jpg & https://commons.wikimedia.org/wiki/File:2019-09-18-tenerife-teide-trees-mv.jpg) and seems to work

[Wikidata-bugs] [Maniphest] [Commented On] T249556: Structured Data interface does not work on IE11

2020-06-10 Thread matthiasmullie
matthiasmullie added a comment. It looks like all JS errors in IE have now been resolved. There's still display issues, but I've just submitted a patch that should also resolve those. TASK DETAIL https://phabricator.wikimedia.org/T249556 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T238484: Entities returned by mw.wikibase.getEntity lua function differ based on language of the viewer

2020-04-10 Thread matthiasmullie
matthiasmullie added a comment. So, does anyone know whether this is a feature or a bug? This behavior appears to be intentional and not causing any trouble when testing whether or not languages match, in which case I believe we can close this ticket? TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Claimed] T249556: Structured Data interface does not work on IE11

2020-04-07 Thread matthiasmullie
matthiasmullie claimed this task. matthiasmullie added a project: Structured-Data-Backlog (Current Work). TASK DETAIL https://phabricator.wikimedia.org/T249556 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: LucasWerkmeister, Nikki

[Wikidata-bugs] [Maniphest] [Changed Project Column] T238484: Entities returned by mw.wikibase.getEntity lua function differ based on language of the viewer

2020-03-26 Thread matthiasmullie
matthiasmullie moved this task from Ready for Estimation to Blocked on the Structured-Data-Backlog (Current Work) board. matthiasmullie added a comment. Apologies it took awhile to get back to this! Unfortunately, this has not resolved itself over time :) This is not MediaInfo/Commons

[Wikidata-bugs] [Maniphest] [Retitled] T238484: Entities returned by mw.wikibase.getEntity lua function differ based on language of the viewer

2020-03-26 Thread matthiasmullie
matthiasmullie renamed this task from "Structured Data on Commons entities returned by mw.wikibase.getEntity lua function differ based on language of the viewer" to "Entities returned by mw.wikibase.getEntity lua function differ based on language of the viewer".

[Wikidata-bugs] [Maniphest] [Updated] T241338: Allow linking to specific statements in Structured data on Commons

2020-03-24 Thread matthiasmullie
matthiasmullie edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T241338 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: Tacsipacsi

[Wikidata-bugs] [Maniphest] [Merged] T246918: Wrong element selected when choosing from search results

2020-03-09 Thread matthiasmullie
matthiasmullie merged a task: T247118: An attempt to add structure data on Commons results in a wrong item. matthiasmullie added subscribers: Ymblanter, matthiasmullie, Jarekt, Cparle, Ramsey-WMF, TheDJ, Multichill. TASK DETAIL https://phabricator.wikimedia.org/T246918 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T247118: An attempt to add structure data on Commons results in a wrong item

2020-03-09 Thread matthiasmullie
matthiasmullie added a comment. Yes, this is the same as T246918 <https://phabricator.wikimedia.org/T246918> and should be fixed on next deployment (Wed) TASK DETAIL https://phabricator.wikimedia.org/T247118 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Updated] T247118: An attempt to add structure data on Commons results in a wrong item

2020-03-09 Thread matthiasmullie
matthiasmullie closed this task as a duplicate of T246918: Wrong element selected when choosing from search results. TASK DETAIL https://phabricator.wikimedia.org/T247118 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: Jarekt

[Wikidata-bugs] [Maniphest] [Claimed] T246918: Wrong element selected when choosing from search results

2020-03-05 Thread matthiasmullie
matthiasmullie claimed this task. matthiasmullie edited projects, added Structured-Data-Backlog (Current Work); removed Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T246918 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc

[Wikidata-bugs] [Maniphest] [Commented On] T241338: Allow linking to specific statements in Structured data on Commons

2020-03-03 Thread matthiasmullie
matthiasmullie added a comment. Correct: we can't rely on default browser behaviour of scrolling to anchors, because the content is hidden. But we can implement a similar behavior on our own. @Jarekt would you want to link to the specific statement (i.e. `File:Something.jpg#M63

[Wikidata-bugs] [Maniphest] [Updated] T239474: [M] Units support for quantity datatype

2020-02-11 Thread matthiasmullie
matthiasmullie added a comment. In T239474#5845899 <https://phabricator.wikimedia.org/T239474#5845899>, @Multichill wrote: > If we're building a new interface, can you make it a bit smarter so it actually suggests a relevant unit? If I'm adding things like height and width, I

[Wikidata-bugs] [Maniphest] [Commented On] T239474: [M] Units support for quantity datatype

2020-02-11 Thread matthiasmullie
matthiasmullie added a comment. Design update: see F31552245 <https://phabricator.wikimedia.org/F31552245> TASK DETAIL https://phabricator.wikimedia.org/T239474 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: Jarekt, Ad

[Wikidata-bugs] [Maniphest] [Claimed] T244207: Revision 386521405 belongs to M43864745 instead of expected M79277318

2020-02-05 Thread matthiasmullie
matthiasmullie claimed this task. matthiasmullie added a comment. This is similar to T231276 <https://phabricator.wikimedia.org/T231276>. This basically happens when a page's history gets split (https://commons.wikimedia.org/wiki/Commons:History_merging_and_splitting#History_spl

[Wikidata-bugs] [Maniphest] [Commented On] T239474: [M] Units support for quantity datatype

2020-02-03 Thread matthiasmullie
matthiasmullie added a comment. Actual (backend) support for other entities has already been merged. Patch to bring support to the frontend is in code review. Here's what that'll look like - pretty much the exact same as Wikidata & support for time inputs. Empty: F3154

[Wikidata-bugs] [Maniphest] [Claimed] T239474: [M] Units support for quantity datatype

2020-02-03 Thread matthiasmullie
matthiasmullie claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T239474 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: Jarekt, Addshore, Ramsey-WMF, Aklapper, egardner, PDrouin-WMF, Multichill, matthiasmullie

[Wikidata-bugs] [Maniphest] [Unblock] T239163: Inform users about constraint violation

2020-01-23 Thread matthiasmullie
matthiasmullie closed subtask T239939: [S] Deploy WikibaseQualityConstraints to beta commons as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T239163 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: Jheald

[Wikidata-bugs] [Maniphest] [Closed] T239939: [S] Deploy WikibaseQualityConstraints to beta commons

2020-01-23 Thread matthiasmullie
matthiasmullie closed this task as "Resolved". matthiasmullie added a comment. This is now on betacommons: https://commons.wikimedia.beta.wmflabs.org/wiki/Special:Version TASK DETAIL https://phabricator.wikimedia.org/T239939 EMAIL PREFERENCES https://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Claimed] T242331: Input field not cleared after selecting an entry

2020-01-14 Thread matthiasmullie
matthiasmullie claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T242331 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: Aklapper, Raymond, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente

[Wikidata-bugs] [Maniphest] [Closed] T237107: Extend mw.wikibase lua functions to allow accessing Structured Data on Commons items

2020-01-08 Thread matthiasmullie
matthiasmullie closed this task as "Resolved". matthiasmullie added a comment. As far as I can tell, all (relevant) methods where a MediaInfo implementation was missing now work. And since it's now possible to resolve page titles to MediaInfo ids (with functional `mw.wikibase

[Wikidata-bugs] [Maniphest] [Updated] T237107: Extend mw.wikibase lua functions to allow accessing Structured Data on Commons items

2020-01-06 Thread matthiasmullie
matthiasmullie merged a task: T236691: Implement alternative `SiteLinkLookup` for MediaInfo entities. matthiasmullie added subscribers: matthiasmullie, Addshore, Multichill. TASK DETAIL https://phabricator.wikimedia.org/T237107 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Closed] T239165: PHP Warning: count(): Parameter must be an array or an object that implements Countable in WikibaseMediaInfo

2019-12-17 Thread matthiasmullie
matthiasmullie closed this task as "Resolved". matthiasmullie claimed this task. matthiasmullie added a comment. No longer present in recent error logs. TASK DETAIL https://phabricator.wikimedia.org/T239165 EMAIL PREFERENCES https://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] [Closed] T240563: broken Lua's mw.wikibase.entity:getSitelink function

2019-12-16 Thread matthiasmullie
matthiasmullie added a project: Structured-Data-Backlog (Current Work). matthiasmullie closed this task as "Resolved". matthiasmullie claimed this task. matthiasmullie added a comment. Fix got deployed - I believe this is done, but please do re-open the ticket should you still disco

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

2019-12-16 Thread matthiasmullie
matthiasmullie added a comment. > Can we just keep `getSitelink` method, and make it return //nil// when applied to MediaInfo entities? Yes - bringing it back as a no-op (for now at least) > The difference between the two files is that the first one has SDC statements and

[Wikidata-bugs] [Maniphest] [Created] T240839: Make DataAccessSnakFormatterOutputFormatTest more robust

2019-12-16 Thread matthiasmullie
matthiasmullie created this task. matthiasmullie added a project: Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION It appears that DataAccessSnakFormatterOutputFormatTest can fail in certain circumstances

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

2019-12-12 Thread matthiasmullie
matthiasmullie added a comment. I believe that whatever I ended up doing to remove the `getSitelink` method from MediaInfo entities, accidentally took it away from the parent class as well. Am looking into it! TASK DETAIL https://phabricator.wikimedia.org/T240563 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

2019-12-12 Thread matthiasmullie
matthiasmullie added a comment. Yes, it looks like the removal of `getSitelink` for MediaInfo entities probably caused this. There's already a discussion about this on the module's talk page: https://commons.wikimedia.org/wiki/Module_talk:Wikidata_label

[Wikidata-bugs] [Maniphest] [Commented On] T239565: Create reportupdater reports that execute SDC requests

2019-12-10 Thread matthiasmullie
matthiasmullie added a comment. No it shouldn’t count pages more than once. UNION omits duplicates (UNION ALL doesn’t), so no need to DISTINCT again. TASK DETAIL https://phabricator.wikimedia.org/T239565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T239565: Create reportupdater reports that execute SDC requests

2019-12-10 Thread matthiasmullie
matthiasmullie added a comment. I'm not really sure what number we want to go with, but I can probably help clarify what kind of data is in which db tables (and what numbers derived from those actually mean) So, it seems we have 2 completely separate definitions of "structured

[Wikidata-bugs] [Maniphest] [Updated] T238878: Data about how many file pages on Commons contain at least one structured data element

2019-12-10 Thread matthiasmullie
matthiasmullie added a comment. > Ping @matthiasmullie to asses this info That is correct, except for 1 little detail: wbc_entity_usage will have some mediainfo entities, in cases where a file page uses another (or its own) mediainfo entity via Lua. wbc_entity_usage simply reco

[Wikidata-bugs] [Maniphest] [Commented On] T208517: Should Wikibase add a property to the page response object that indicates the embedded entities?

2019-12-10 Thread matthiasmullie
matthiasmullie added a comment. Alternatively, this API endpoint already includes the entity id: https://commons.wikimedia.beta.wmflabs.org/w/api.php?action=wbgetentities=commonswiki=File:Redsq.png TASK DETAIL https://phabricator.wikimedia.org/T208517 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Updated] T238484: Structured Data on Commons entities returned by mw.wikibase.getEntity lua function differ based on language of the viewer

2019-12-06 Thread matthiasmullie
matthiasmullie added a project: Structured-Data-Backlog (Current Work). TASK DETAIL https://phabricator.wikimedia.org/T238484 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: matthiasmullie, Marsupium, Jarekt, Aklapper

[Wikidata-bugs] [Maniphest] [Commented On] T238484: Structured Data on Commons entities returned by mw.wikibase.getEntity lua function differ based on language of the viewer

2019-12-06 Thread matthiasmullie
matthiasmullie added a comment. I am able to reproduce this on Commons, but not with my local setup. There are a few other related patches coming up soon-ish, and I'll pick this back up once those are settled. TASK DETAIL https://phabricator.wikimedia.org/T238484 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T238878: Data about how many file pages on Commons contain at least one structured data element

2019-12-03 Thread matthiasmullie
matthiasmullie added a comment. > If you want to count //pages//, then you are only looking at the current revision, right? And the current revision of a page is by definition never deleted/suppressed. So no need to check rev_deleted. So page_latest can never point to a revdel

[Wikidata-bugs] [Maniphest] [Commented On] T238878: Data about how many file pages on Commons contain at least one structured data element

2019-12-03 Thread matthiasmullie
matthiasmullie added a comment. @Milimetric it wasn't being used to omit deleted pages (see inline comments about archive table), but to **also** exclude those RevDel'ed revisions. I was thinking it made sense to exclude rev-deleted revisions: if a page only has (SDC) revisions

[Wikidata-bugs] [Maniphest] [Commented On] T238878: Data about how many file pages on Commons contain at least one structured data element

2019-11-25 Thread matthiasmullie
matthiasmullie added a comment. I don't really know much about how `mediawiki_history` gets populated, but `wbcreateclaim` & `wbeditentity` (in addition to `wbsetclaim`) could also be used to create (or edit) statements IIRC, so this last set of results is likely incomplete. A

[Wikidata-bugs] [Maniphest] [Commented On] T238878: Data about how many file pages on Commons contain at least one structured data element

2019-11-22 Thread matthiasmullie
matthiasmullie added a comment. As far as I can tell: @mpopov's queries (`wbc_entity_usage` based) include both MediaInfo items, along with Wikidata-items pulled in via Lua. @Addshore's queries are stricktly the amount of MediaInfo items. TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T181062: Adapt QuickStatements2 to be able to work with structured data on Commons as well

2019-11-22 Thread matthiasmullie
matthiasmullie added a comment. In T181062#5683735 <https://phabricator.wikimedia.org/T181062#5683735>, @Spinster wrote: > Can my colleagues from the #structureddataoncommons <https://phabricator.wikimedia.org/tag/structureddataoncommons/> team do anything to make it ea

[Wikidata-bugs] [Maniphest] [Commented On] T226093: Capacity planning for Commons Structured Data

2019-11-13 Thread matthiasmullie
matthiasmullie added a comment. In T226093#5657414 <https://phabricator.wikimedia.org/T226093#5657414>, @Ramsey-WMF wrote: > Matthias will look into discrepancies between number of files with mediainfo slots vs. what's indexed in Cirrus. It looks like the difference

[Wikidata-bugs] [Maniphest] [Closed] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

2019-10-28 Thread matthiasmullie
matthiasmullie closed this task as "Resolved". matthiasmullie added a comment. Currently being used in production: https://commons.wikimedia.org/w/index.php?title=File%3AJodrell_Bank_Mark_II_5.jpg=revision=371864746=149735587 Closing this one - let's open other more specif

[Wikidata-bugs] [Maniphest] [Unblock] T212144: Allow access to MediaInfo from wikitext on Commons

2019-10-28 Thread matthiasmullie
matthiasmullie closed subtask T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T212144 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T236370: Call to undefined method Wikibase\Lib\EntityTypeDefinitions::getPrefetchingTermLookupCallbacks()

2019-10-24 Thread matthiasmullie
matthiasmullie added a comment. Same as with T236372 <https://phabricator.wikimedia.org/T236372>, these happened at the exact time these changes were being scapped, and stopped immediately after: https://logstash.wikimedia.org/goto/cfd3017e60a6be127c9673fd9ff53536 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T236372: Too few arguments to function Wikibase\DataAccess\SingleEntitySourceServices::__construct(), 9 passed in /extensions/Wikibase/repo/includes/Wikibase

2019-10-24 Thread matthiasmullie
matthiasmullie added a comment. These all happened at 11:10 UTC, when the change was being deployed. This stopped immediately after: https://logstash.wikimedia.org/goto/39611d534c6b97d76c367f4e4878ab15 TASK DETAIL https://phabricator.wikimedia.org/T236372 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T236372: Too few arguments to function Wikibase\DataAccess\SingleEntitySourceServices::__construct(), 9 passed in /extensions/Wikibase/repo/includes/Wikibase

2019-10-24 Thread matthiasmullie
matthiasmullie added a comment. I'll doublecheck, but I think these only happened the minute the patches were being scapped, and then stopped. TASK DETAIL https://phabricator.wikimedia.org/T236372 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

  1   2   3   >