soeren.oldag added a comment.
There are 2 open changes (https://gerrit.wikimedia.org/r/#/c/222869,
https://gerrit.wikimedia.org/r/#/c/222867) addressing the mentioned issues for
ExternalValidation that need to be reviewed. Maybe you guys can have a look?
TASK DETAIL
JanZerebecki added a comment.
https://phabricator.wikimedia.org/T102992#1429298
TASK DETAIL
https://phabricator.wikimedia.org/T102992
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JanZerebecki
Cc: Lydia_Pintscher, JanZerebecki, thiemowmde,
Lydia_Pintscher added a subscriber: Lydia_Pintscher.
Lydia_Pintscher added a comment.
What's left to do here?
TASK DETAIL
https://phabricator.wikimedia.org/T102992
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lydia_Pintscher
Cc: Lydia_Pintscher,
thiemowmde added a subscriber: thiemowmde.
thiemowmde added a comment.
When looking at the v1 branch at
https://github.com/wikimedia/mediawiki-extensions-WikibaseQualityConstraints/blob/v1/sql/create_wbqc_constraints.sql
there seems to be one issue left:
- The field constraint_parameters is
JanZerebecki added a subscriber: JanZerebecki.
JanZerebecki added a comment.
On production TEXT makes the DB create table of type blob. Perhaps use that or
mediumblob instead?
TASK DETAIL
https://phabricator.wikimedia.org/T102992
EMAIL PREFERENCES
soeren.oldag added a subscriber: soeren.oldag.
soeren.oldag added a comment.
For all tables except wbq_violations, the issues should be solved. Since
wbq_violations was removed in v1, this should not block the deployment.
@jcrespo
- Only `wbq_evaluation`, which was removed recently, had no
gerritbot added a comment.
Change 222722 merged by jenkins-bot:
Database schema improvements (https://phabricator.wikimedia.org/T102992)
https://gerrit.wikimedia.org/r/222722
TASK DETAIL
https://phabricator.wikimedia.org/T102992
EMAIL PREFERENCES
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.
Change 222722 had a related patch set uploaded (by Soeren.oldag):
Database schema improvements (https://phabricator.wikimedia.org/T102992)
https://gerrit.wikimedia.org/r/222722
TASK DETAIL
gerritbot added a comment.
Change 222861 had a related patch set uploaded (by Soeren.oldag):
Database schema improvements (https://phabricator.wikimedia.org/T102992)
https://gerrit.wikimedia.org/r/222861
TASK DETAIL
https://phabricator.wikimedia.org/T102992
EMAIL PREFERENCES
gerritbot added a comment.
Change 222867 had a related patch set uploaded (by Soeren.oldag):
Database schema improvements (https://phabricator.wikimedia.org/T102992)
https://gerrit.wikimedia.org/r/222867
TASK DETAIL
https://phabricator.wikimedia.org/T102992
EMAIL PREFERENCES
gerritbot added a comment.
Change 222869 had a related patch set uploaded (by Soeren.oldag):
Database schema improvements (https://phabricator.wikimedia.org/T102992)
https://gerrit.wikimedia.org/r/222869
TASK DETAIL
https://phabricator.wikimedia.org/T102992
EMAIL PREFERENCES
gerritbot added a comment.
Change 222862 had a related patch set uploaded (by Soeren.oldag):
Database schema improvements (https://phabricator.wikimedia.org/T102992)
https://gerrit.wikimedia.org/r/222862
TASK DETAIL
https://phabricator.wikimedia.org/T102992
EMAIL PREFERENCES
gerritbot added a comment.
Change 222861 abandoned by Soeren.oldag:
Database schema improvements (https://phabricator.wikimedia.org/T102992)
https://gerrit.wikimedia.org/r/222861
TASK DETAIL
https://phabricator.wikimedia.org/T102992
EMAIL PREFERENCES
daniel added a comment.
The index names are off:
CREATE INDEX /*i*/wbqc_constraints_pid_index
ON /*_*/wbqc_constraints (pid);
is redundant, it should be
CREATE INDEX /*i*/pid
ON /*_*/wbqc_constraints (pid);
on mysql, this will create a pid index on the wbqc_constraints table. On
Jonaskeutel added a subscriber: Jonaskeutel.
Jonaskeutel added a comment.
In Version two we have a data issues special page where we want to be able to
filter all violations by constraint_type_qid, so we think, an index makes sense.
Yes, wbq_violations is unused in v1 and it actually is removed
daniel added a comment.
A first review of the schema and queries:
Queries run against wbqc_constraints seem to all use the (pid) index. What's
the (constraint_type_qid) index for?
Queries run against wbqev_external_data seem to all use the (dump_id,
external_id, pid) index. Unless
JAnstee_WMF added a comment.
I was subscribed to this task, likely in error, as I do not know how this task
relates to my work. I will unsubscribe, if it was not an error but
intentional, please let me know by resubscribing me in that case.
TASK DETAIL
jcrespo added a subscriber: jcrespo.
jcrespo added a comment.
First comments from a MySQL DBA, assuming that goes to production:
- Some tables lack of a `PRIMARY KEY`.** This should be a requirement for new
tables**.
- character strings do not have a specified `CHARACTER SET`. Check that those
Tamslo added a subscriber: Tamslo.
Tamslo added a comment.
The URL of the repositories changed, see the description.
TASK DETAIL
https://phabricator.wikimedia.org/T102992
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tamslo
Cc: Tamslo,
19 matches
Mail list logo
