[Wikidata-bugs] [Maniphest] [Commented On] T128191: Wikibase Scribunto tests are failing, with the tests depending on configuration

2016-02-26 Thread Stashbot
Stashbot added a comment. Mentioned in SAL [2016-02-27T00:51:41Z] salt -v --show-timeout '*slave*' cmd.run "bash -c 'cd /srv/deployment/integration/slave-scripts; git pull'" https://phabricator.wikimedia.org/T128191 TASK DETAIL https://phabricator.wikimedia.org/T128191 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T128191: Wikibase Scribunto tests are failing, with the tests depending on configuration

2016-02-26 Thread Legoktm
Legoktm added a comment. So...are we ready to try again? :) TASK DETAIL https://phabricator.wikimedia.org/T128191 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Legoktm Cc: Legoktm, hoo, JanZerebecki, Anomie, Stashbot, gerritbot, Aklapper, aude,

[Wikidata-bugs] [Maniphest] [Commented On] T128191: Wikibase Scribunto tests are failing, with the tests depending on configuration

2016-02-26 Thread JanZerebecki
JanZerebecki added a comment. Fix for the instanceof problem: https://gerrit.wikimedia.org/r/#/c/273494/ . TASK DETAIL https://phabricator.wikimedia.org/T128191 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: JanZerebecki,

[Wikidata-bugs] [Maniphest] [Commented On] T128191: Wikibase Scribunto tests are failing, with the tests depending on configuration

2016-02-26 Thread Anomie
Anomie added a comment. > That change is good, but we need to improve the tests so they don't depend on configuration like this. +1. Why are you calling `Scribunto::newDefaultEngine()` in Scribunto_LuaWikibaseLibraryTest.php and Scribunto_LuaWikibaseEntityLibraryTest.php instead

[Wikidata-bugs] [Maniphest] [Commented On] T128191: Wikibase Scribunto tests are failing, with the tests depending on configuration

2016-02-26 Thread Stashbot
Stashbot added a comment. Mentioned in SAL [2016-02-26T15:14:19Z] salt -v --show-timeout '*slave*' cmd.run "bash -c 'cd /srv/deployment/integration/slave-scripts; git pull'" https://phabricator.wikimedia.org/T128191 TASK DETAIL https://phabricator.wikimedia.org/T128191 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T128191: Wikibase Scribunto tests are failing, with the tests depending on configuration

2016-02-26 Thread gerritbot
gerritbot added a comment. Change 273460 merged by jenkins-bot: Revert "mediawiki.conf: Set $wgScribuntoDefaultEngine for speed" https://gerrit.wikimedia.org/r/273460 TASK DETAIL https://phabricator.wikimedia.org/T128191 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T128191: Wikibase Scribunto tests are failing, with the tests depending on configuration

2016-02-26 Thread gerritbot
gerritbot added a comment. Change 273460 had a related patch set uploaded (by Aude): Revert "mediawiki.conf: Set $wgScribuntoDefaultEngine for speed" https://gerrit.wikimedia.org/r/273460 TASK DETAIL https://phabricator.wikimedia.org/T128191 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T128191: Wikibase Scribunto tests are failing, with the tests depending on configuration

2016-02-26 Thread aude
aude added a comment. this is causing anything depending on the wikidata build to fail, such as ContentTranslation, and is causing Wikibase tests to also fail TASK DETAIL https://phabricator.wikimedia.org/T128191 EMAIL PREFERENCES