gerritbot added a comment.
Change 345292 abandoned by Thiemo Mättig (WMDE):
Remove $lexicalCategory and $language from Lexeme constructor
Reason:
Should use an actual builder class. I'm not happy with the one currently merged in this code base, and want to continue working on it. Whatever the outc
daniel added a comment.
Note that this doesn't make everything proposed in this ticket invalid. We might still add static constructors for convenience.
Yes, of course!TASK DETAILhttps://phabricator.wikimedia.org/T162809EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferen
thiemowmde added a comment.
Note that this doesn't make everything proposed in this ticket invalid. We might still add static constructors for convenience.TASK DETAILhttps://phabricator.wikimedia.org/T162809EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiem
WMDE-leszek added a comment.
I haven't digested this proposal, and going even more further as @daniel outlined in his comment at https://gerrit.wikimedia.org/r/#/c/345292/, thus I don't feel ready to comment on the whole proposal.
My two cents so far:
I like the idea of aiming to have no optiona
thiemowmde added a comment.
"Fully" initialized might be a confusing term we want to avoid.
For now we have Lexeme::isSufficientlyInitialized, which could act as the counter-part to one of the static constructors from the proposal above. We can think of naming one newSufficientlyInitialized or sim
daniel added a comment.
I would extend this to constructors of all Entities. And I think removing all parameters from all the constructors would be best. We can perhaps keep the optional ID parameter, but even that isn't very useful.
If we do this, the EntityDocument interface should get an isFull
gerritbot added a comment.
Change 345292 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Remove $lexicalCategory and $language from Lexeme constructor
https://gerrit.wikimedia.org/r/345292TASK DETAILhttps://phabricator.wikimedia.org/T162809E
