Reedy added a comment.
Many are likely to be false positives, and that's not too much of an issue as long as people have looked over them and deemed them as such :)TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL
Smalyshev added a comment.
CirrusSearch one seems to be false positive.TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, Paladox, Ottomata, gerritbot, Mattflaschen-WMF, Liuxinyu970226,
gerritbot added a comment.
Change 383289 merged by jenkins-bot:
[mediawiki/extensions/Gadgets@master] Remove nested foreach references
https://gerrit.wikimedia.org/r/383289TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL
gerritbot added a comment.
Change 383289 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Gadgets@master] Remove nested foreach references
https://gerrit.wikimedia.org/r/383289TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL
Reedy added a comment.
Looks like we've gone down from 30 plus func_get_args, to 3...TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReedyCc: Paladox, Ottomata, gerritbot, Mattflaschen-WMF, Liuxinyu970226,
Paladox added a comment.
I think they fixed most of the false positives now. Could someone re run the linter and update the description please?TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PaladoxCc:
Reedy added a comment.
In T173850#3542522, @Anomie wrote:
I'm not impressed with the false positive rate for this tool. The warnings in OAuth, CentralAuth, and Scribunto all appear to be bogus.
https://github.com/sstalle/php7cc/issues/127#issuecomment-330169791
gerritbot added a comment.
Change 374816 abandoned by Ottomata:
Fix PHP7 warnings
Reason:
Ha! Psshhh ok then, abandoning! :)
https://gerrit.wikimedia.org/r/374816TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL
Reedy added a comment.
Seems to come from.. https://github.com/sstalle/php7cc/blob/67f3586e4adadc79f0625d1de5a935ad0ed99178/src/NodeVisitor/BitwiseShiftVisitor.php#L49-L54TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL
Addshore added a comment.
Regarding Cognate:
File: /home/reedy/git/mediawiki/core/extensions/Cognate/src/CognateHooks.php
> Line 25: [Warning] Function argument(s) returned by "func_get_args" might have been modified
func_get_args();
> Line 43: [Warning] Function argument(s) returned by
Ottomata added a comment.
I fixed the two warnings from the EventLogging extension, but I have not been able to test them. If anyone knows how, I would be much obliged.
https://gerrit.wikimedia.org/r/#/c/374816/TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL
gerritbot added a comment.
Change 374816 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[mediawiki/extensions/EventLogging@master] Fix PHP7 warnings
https://gerrit.wikimedia.org/r/374816TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL
Reedy added a comment.
func_get_args is very false positive/naive check.
Upstream issue filed, with various examples provided at https://github.com/sstalle/php7cc/issues/127TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL
Anomie added a comment.
I'm not impressed with the false positive rate for this tool. The warnings in OAuth, CentralAuth, and Scribunto all appear to be bogus.TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
14 matches
Mail list logo
