[Wikidata-bugs] [Maniphest] [Commented On] T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().

daniel added a comment. In T198342#5354371 , @Daimona wrote: > So I see AF is mentioned here... I'm glad to help. To give you some context, we do access the text table directly in AbuseFilter::storeVarDump and AbuseFilter::loadVarDump,

[Wikidata-bugs] [Maniphest] [Commented On] T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().

Daimona added a comment. So I see AF is mentioned here... I'm glad to help. To give you some context, we do access the text table directly in AbuseFilter::storeVarDump and AbuseFilter::loadVarDump, but that's not for getting revision text, as we save our custom data in the text table. It's

[Wikidata-bugs] [Maniphest] [Commented On] T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().

gerritbot added a comment. Change 524593 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler): [mediawiki/extensions/Translate@master] Remove direct access to text table https://gerrit.wikimedia.org/r/524593 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().

gerritbot added a comment. Change 504797 had a related patch set uploaded (by BPirkle; owner: BPirkle): [mediawiki/extensions/SpamBlacklist@master] Remove usage of Revision::GetQueryInfo() with 'text' flag https://gerrit.wikimedia.org/r/504797 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().

gerritbot added a comment. Change 504369 **merged** by jenkins-bot: [mediawiki/core@master] Remove usages of 'text' flag in revision-related getQueryInfo() calls https://gerrit.wikimedia.org/r/504369 TASK DETAIL https://phabricator.wikimedia.org/T198342 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().

gerritbot added a comment. Change 504369 had a related patch set uploaded (by BPirkle; owner: BPirkle): [mediawiki/core@master] Remove usages of 'text' flag in revision-related getQueryInfo() calls https://gerrit.wikimedia.org/r/504369 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().

daniel added a comment. In T198342#5083815 , @BPirkle wrote: > Usages found: > > - includes/api/ApiQueryAllRevisions.php, line 85, in function run() > - includes/api/ApiQueryRevisions.php, line 162, in function run() (if

[Wikidata-bugs] [Maniphest] [Commented On] T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().

BPirkle added a comment. Usages found: - includes/api/ApiQueryAllRevisions.php, line 85, in function run() - includes/api/ApiQueryRevisions.php, line 162, in function run() (if $this->fetchContent is true) - maintenance/testCompression.php line 51 -

[Wikidata-bugs] [Maniphest] [Commented On] T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().

greg added a comment. @daniel: sorry, I don't see how/why this should go on the releng-kanban board?TASK DETAILhttps://phabricator.wikimedia.org/T198342EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gregCc: greg, Aklapper, aude, Addshore, Anomie,

[Wikidata-bugs] [Maniphest] [Commented On] T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().

gerritbot added a comment. Change 439976 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler): [mediawiki/core@master] Replace calls to Revision::getQueryInfo with the 'text' option set. https://gerrit.wikimedia.org/r/439976TASK